[GitHub] bvbharatk commented on a change in pull request #1965: CLOUDSTACK-9727 Password reset discrepancy in RVR when one of the Rou?

[gi...@git.apache.org]

bvbharatk commented on a change in pull request #1965: CLOUDSTACK-9727 Password reset discrepancy in RVR when one of the Rou?
URL: https://github.com/apache/cloudstack/pull/1965#discussion_r117665038
 
 

 ##########
 File path: server/src/org/apache/cloudstack/network/topology/AdvancedNetworkVisitor.java
 ##########
 @@ -61,13 +61,15 @@
     @Override
     public boolean visit(final UserdataPwdRules userdata) throws ResourceUnavailableException {
         final VirtualRouter router = userdata.getRouter();
-
         final Commands commands = new Commands(Command.OnError.Stop);
         final VirtualMachineProfile profile = userdata.getProfile();
         final NicVO nicVo = userdata.getNicVo();
         final UserVmVO userVM = userdata.getUserVM();
 
-        _commandSetupHelper.createPasswordCommand(router, profile, nicVo, commands);
+        if (router.getRedundantState() == VirtualRouter.RedundantState.MASTER) {
 
 Review comment:
   @ustcweizhou 
   I am also not sure about the VPC behavior, so for now i will not alter the behavior for vpc networks.  I have added the changes to ignore non redundant vrs and vpc vrs.
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services