You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@geode.apache.org by GitBox <gi...@apache.org> on 2020/09/22 19:41:36 UTC
[GitHub] [geode] pivotal-jbarrett opened a new pull request #5532: GEODE-8513: Remove (de)serialization of local sessions.
pivotal-jbarrett opened a new pull request #5532:
URL: https://github.com/apache/geode/pull/5532
Removes query that resulted in casting issue in antlr.
Clears all locally cached entries.
Thank you for submitting a contribution to Apache Geode.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [ ] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message?
- [ ] Has your PR been rebased against the latest commit within the target branch (typically `develop`)?
- [ ] Is your initial contribution a single, squashed commit?
- [ ] Does `gradlew build` run cleanly?
- [ ] Have you written or updated unit tests to verify your changes?
- [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?
### Note:
Please ensure that once the PR is submitted, check Concourse for build issues and
submit an update to your PR as soon as possible. If you need help, please send an
email to dev@geode.apache.org.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [geode] jdeppe-pivotal commented on pull request #5532: GEODE-8513: Remove (de)serialization of local sessions.
Posted by GitBox <gi...@apache.org>.
jdeppe-pivotal commented on pull request #5532:
URL: https://github.com/apache/geode/pull/5532#issuecomment-700826120
IIRC, the reason this functionality was added was so that webapps could be hot-deployed which would require sessions to be 'rebuilt' since the classloader would have changed. I'm not sure if this is still a valid scenario.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [geode] pivotal-jbarrett commented on pull request #5532: GEODE-8513: Remove (de)serialization of local sessions.
Posted by GitBox <gi...@apache.org>.
pivotal-jbarrett commented on pull request #5532:
URL: https://github.com/apache/geode/pull/5532#issuecomment-700840958
Two interesting things were happing in there. First was the serialization of the session to disk, which really only made sense in peer mode since in client server the persistence is off JVM already. In peer mode it makes more sense, and is more tested, to use region persistence to achieve this hot deployment behavior. The second thing going on was the removal from the local region. This was to avoid class loader casting issues. This was just simplified to a local clear operation rather than iterating over all the sessions specific to this web context. The upside is that it takes a lot less time and doesn't invoke any queries. The downside is that other web contexts will have to refresh their local caches too but this scenario should be very small.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [geode] metatype commented on pull request #5532: GEODE-8513: Remove (de)serialization of local sessions.
Posted by GitBox <gi...@apache.org>.
metatype commented on pull request #5532:
URL: https://github.com/apache/geode/pull/5532#issuecomment-700817211
I don't have any concerns about removing the `doUnload`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [geode] pivotal-jbarrett merged pull request #5532: GEODE-8513: Remove (de)serialization of local sessions.
Posted by GitBox <gi...@apache.org>.
pivotal-jbarrett merged pull request #5532:
URL: https://github.com/apache/geode/pull/5532
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org