You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hbase.apache.org by "Ted Yu (JIRA)" <ji...@apache.org> on 2016/02/13 16:33:18 UTC

[jira] [Comment Edited] (HBASE-15261) Make Throwable t in DaughterOpener volatile

    [ https://issues.apache.org/jira/browse/HBASE-15261?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15146015#comment-15146015 ] 

Ted Yu edited comment on HBASE-15261 at 2/13/16 3:33 PM:
---------------------------------------------------------

Is it possible to add test case ?


was (Author: yuzhihong@gmail.com):
This Throwable is accessed like this:
{code}
        if (aOpener.getException() == null) {
{code}
I don't see synchronization primitive around the access. Meaning, would the change to volatile be effective ?

> Make Throwable t in DaughterOpener volatile
> -------------------------------------------
>
>                 Key: HBASE-15261
>                 URL: https://issues.apache.org/jira/browse/HBASE-15261
>             Project: HBase
>          Issue Type: Bug
>          Components: regionserver
>            Reporter: huaxiang sun
>            Assignee: huaxiang sun
>            Priority: Minor
>         Attachments: HBASE-15261-001.patch
>
>
> In the region split process, daughter regions are opened in different threads, Throwable t is set in these threads and it is checked in the calling thread. Need to make it volatile so the checking will not miss any exceptions from opening daughter regions.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)