[jira] [Commented] (COUCHDB-2560) Revert changes made to external libs

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/COUCHDB-2560?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14316062#comment-14316062 ] 

ASF GitHub Bot commented on COUCHDB-2560:
-----------------------------------------

Github user robertkowalski commented on the pull request:

    https://github.com/apache/couchdb-fauxton/pull/262#issuecomment-73865917
  
    Hi Ben,
    
    we should never made any changes in external dependencies. If we have to we have to submit a PR to them and then pulling it down after they merged. I also noticed that you already patched internal libraries.
    
    I assigned https://issues.apache.org/jira/browse/COUCHDB-2560 to you, please revert the previous change. Probably that also fixes this issue we currently have. 
    
    If not, you can create an CSS selector in "our" less which is stronger than the one from ace. I remember that you already did that some time ago in `codeeditor.less`
    
    Patching external libraries makes updating them impossible as nobody can tell what happens when we run an update. Please stop doing so - it makes updates unpredictable for the person that updates the external library.


> Revert changes made to external libs
> ------------------------------------
>
>                 Key: COUCHDB-2560
>                 URL: https://issues.apache.org/jira/browse/COUCHDB-2560
>             Project: CouchDB
>          Issue Type: Bug
>      Security Level: public(Regular issues) 
>          Components: Fauxton
>            Reporter: Robert Kowalski
>            Assignee: Ben Keen
>
> Hey let's chat about b53a4db5a4d48320da28fd0f9dd173cb94c67f5b



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)