[GitHub] [incubator-doris] EmmyMiao87 commented on a change in pull request #4475: [Refactor] Refactor storage medium migration task process

[GitBox <gi...@apache.org>]

EmmyMiao87 commented on a change in pull request #4475:
URL: https://github.com/apache/incubator-doris/pull/4475#discussion_r508441859



##########
File path: be/src/agent/task_worker_pool.cpp
##########
@@ -916,19 +916,26 @@ void TaskWorkerPool::_storage_medium_migrate_worker_thread_callback() {
         }
 
         TStatusCode::type status_code = TStatusCode::OK;
-        vector<string> error_msgs;
-        TStatus task_status;
-        EngineStorageMigrationTask engine_task(storage_medium_migrate_req);
-        OLAPStatus res = _env->storage_engine()->execute_task(&engine_task);
-        if (res != OLAP_SUCCESS) {
-            LOG(WARNING) << "storage media migrate failed. status: " << res
-                         << ", signature: " << agent_task_req.signature;
-            status_code = TStatusCode::RUNTIME_ERROR;
+        // check request and get info
+        TabletSharedPtr tablet;
+        DataDir* dest_store;
+        if (_check_migrate_requset(storage_medium_migrate_req, tablet, &dest_store) != OLAP_SUCCESS) {
+            status_code = TStatusCode::RUNTIME_ERROR; 

Review comment:
       Doesn't it print out the reason for the check failure?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org