You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@nifi.apache.org by markap14 <gi...@git.apache.org> on 2016/03/23 16:23:32 UTC
[GitHub] nifi pull request: NIFI-1676: Do not allow Processor to be started...
GitHub user markap14 opened a pull request:
https://github.com/apache/nifi/pull/300
NIFI-1676: Do not allow Processor to be started if state is STOPPING
Need to ensure that processor state is STOPPED, not STOPPING
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/markap14/nifi NIFI-1676
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/nifi/pull/300.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #300
----
commit a87f7b6c0a7f7534ab8d30c0a3da7063ae6422c9
Author: Mark Payne <ma...@hotmail.com>
Date: 2016-03-23T15:19:31Z
NIFI-1676: Do not allow Processor to be started if state is STOPPING; ensure that it is STOPPED
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] nifi pull request: NIFI-1676: Do not allow Processor to be started...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/nifi/pull/300
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] nifi pull request: NIFI-1676: Do not allow Processor to be started...
Posted by apiri <gi...@git.apache.org>.
Github user apiri commented on a diff in the pull request:
https://github.com/apache/nifi/pull/300#discussion_r57181772
--- Diff: nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-framework-core/src/main/java/org/apache/nifi/controller/StandardProcessorNode.java ---
@@ -1117,8 +1117,9 @@ public void verifyCanStart() {
@Override
public void verifyCanStart(final Set<ControllerServiceNode> ignoredReferences) {
- if (this.getScheduledState() == ScheduledState.RUNNING) {
- throw new IllegalStateException(this + " cannot be started because it is already running");
+ final ScheduledState currentState = getPhysicalScheduledState();
+ if (currentState != ScheduledState.STOPPED && currentState != ScheduledState.DISABLED) {
--- End diff --
This should be an || (or), correct?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] nifi pull request: NIFI-1676: Do not allow Processor to be started...
Posted by apiri <gi...@git.apache.org>.
Github user apiri commented on the pull request:
https://github.com/apache/nifi/pull/300#issuecomment-200414177
Okay, code looks good and I have played with this a bit confirming the anticipated behavior for those processes that linger when stopping. +1 from me and can merge into master.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---