You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@harmony.apache.org by Salikh Zakirov <Sa...@Intel.com> on 2006/08/15 09:19:43 UTC
[drlvm] newlines in .cpp and .h files
Nathan,
your last commit
r431519 | ndbeyer | 2006-08-15 07:46:26 +0400 (Tue, 15 Aug 2006) | 1 line
Apply patch for HARMONY-1144: [j.u.c integration with DRLVM - step#1]: implement getFieldOffset and modify compareAndSet<*> methods
changed the newlines of the touched files from LF to CRLF.
Could you please configure your editor to prevent converting line breaks?
And could you please commit the back conversion to LF line endings?
Thanks!
---------------------------------------------------------------------
Terms of use : http://incubator.apache.org/harmony/mailing.html
To unsubscribe, e-mail: harmony-dev-unsubscribe@incubator.apache.org
For additional commands, e-mail: harmony-dev-help@incubator.apache.org
Re: [drlvm] newlines in .cpp and .h files
Posted by Salikh Zakirov <Sa...@Intel.com>.
Hi Nathan,
Thanks a lot for help.
Setting svn:eol-style property helps, so the line endings on Linux become
normal LF.
However, you missed several files, which still have CRLF endings (and no eol-style set):
vm/vmcore/src/kernel_classes/native/org_apache_harmony_util_concurrent_Atomics.h
vm/vmcore/src/kernel_classes/native/org_apache_harmony_util_concurrent_Atomics.cpp
vm/vmcore/src/kernel_classes/javasrc/org/apache/harmony/util/concurrent/Atomics.java
In fact, it seems that almost none of the DRLVM sources have eol-style configured,
so this may be some work for the committer... (only 19 out of 1006 files have it set).
I think I will take my time and prepare a script to do so on all DRLVM files.
Will send it in a few hours.
Nathan Beyer wrote:
> I looked at the files and there are any properties set, so I guess SVN isn't
> taking care of anything in this case. It wasn't my editor that changed
> anything (Eclipse) it was that the patch was submitted with CRLF endings.
>
> I looked at some of the native source files in classlib and everyone that I
> found was using the CRLF. The opposite seems to be true for all of the DRLVM
> source files.
>
> I set the SVN property on the atomics.h and atomics.ccp. Let me know if that
> fixes the issue for you. If it does, we can do a mass property set or just
> set the properties of files as they change.
>
> -Nathan
>
>> -----Original Message-----
>> From: Nathan Beyer [mailto:nbeyer@kc.rr.com]
>> Sent: Tuesday, August 15, 2006 9:51 PM
>> To: harmony-dev@incubator.apache.org
>> Subject: RE: [drlvm] newlines in .cpp and .h files
>>
>> All of the files in the commit or just one?
>>
>> I thought SVN took care of this via the svn:eol-style = native property?
>> I'll check the files, maybe this isn't set there.
>>
>> -Nathan
>>
>>> -----Original Message-----
>>> From: news [mailto:news@sea.gmane.org] On Behalf Of Salikh Zakirov
>>> Sent: Tuesday, August 15, 2006 2:20 AM
>>> To: harmony-dev@incubator.apache.org
>>> Subject: [drlvm] newlines in .cpp and .h files
>>>
>>> Nathan,
>>>
>>> your last commit
>>>
>>> r431519 | ndbeyer | 2006-08-15 07:46:26 +0400 (Tue, 15 Aug 2006) | 1
>>> line
>>> Apply patch for HARMONY-1144: [j.u.c integration with DRLVM - step#1]:
>>> implement getFieldOffset and modify compareAndSet<*> methods
>>>
>>> changed the newlines of the touched files from LF to CRLF.
>>>
>>> Could you please configure your editor to prevent converting line
>> breaks?
>>> And could you please commit the back conversion to LF line endings?
>>>
>>> Thanks!
>>>
>>>
>>> ---------------------------------------------------------------------
>>> Terms of use : http://incubator.apache.org/harmony/mailing.html
>>> To unsubscribe, e-mail: harmony-dev-unsubscribe@incubator.apache.org
>>> For additional commands, e-mail: harmony-dev-help@incubator.apache.org
>>
>> ---------------------------------------------------------------------
>> Terms of use : http://incubator.apache.org/harmony/mailing.html
>> To unsubscribe, e-mail: harmony-dev-unsubscribe@incubator.apache.org
>> For additional commands, e-mail: harmony-dev-help@incubator.apache.org
>
>
> ---------------------------------------------------------------------
> Terms of use : http://incubator.apache.org/harmony/mailing.html
> To unsubscribe, e-mail: harmony-dev-unsubscribe@incubator.apache.org
> For additional commands, e-mail: harmony-dev-help@incubator.apache.org
>
>
---------------------------------------------------------------------
Terms of use : http://incubator.apache.org/harmony/mailing.html
To unsubscribe, e-mail: harmony-dev-unsubscribe@incubator.apache.org
For additional commands, e-mail: harmony-dev-help@incubator.apache.org
RE: [drlvm] newlines in .cpp and .h files
Posted by Nathan Beyer <nb...@kc.rr.com>.
> -----Original Message-----
> From: Alexey Petrenko [mailto:alexey.a.petrenko@gmail.com]
>
> AWT natives should be with LFs :)
It looks like the AWT module's native source files all have the
svn:eol-style = native, so if you're on Linux, then that's what you'll be
seeing.
-Nathan
>
> SY, Alexey
>
> 2006/8/16, Nathan Beyer <nb...@kc.rr.com>:
> > I looked at the files and there are any properties set, so I guess SVN
> isn't
> > taking care of anything in this case. It wasn't my editor that changed
> > anything (Eclipse) it was that the patch was submitted with CRLF
> endings.
> >
> > I looked at some of the native source files in classlib and everyone
> that I
> > found was using the CRLF. The opposite seems to be true for all of the
> DRLVM
> > source files.
> >
> > I set the SVN property on the atomics.h and atomics.ccp. Let me know if
> that
> > fixes the issue for you. If it does, we can do a mass property set or
> just
> > set the properties of files as they change.
> >
> > -Nathan
> >
> > > -----Original Message-----
> > > From: Nathan Beyer [mailto:nbeyer@kc.rr.com]
> > > Sent: Tuesday, August 15, 2006 9:51 PM
> > > To: harmony-dev@incubator.apache.org
> > > Subject: RE: [drlvm] newlines in .cpp and .h files
> > >
> > > All of the files in the commit or just one?
> > >
> > > I thought SVN took care of this via the svn:eol-style = native
> property?
> > > I'll check the files, maybe this isn't set there.
> > >
> > > -Nathan
> > >
> > > > -----Original Message-----
> > > > From: news [mailto:news@sea.gmane.org] On Behalf Of Salikh Zakirov
> > > > Sent: Tuesday, August 15, 2006 2:20 AM
> > > > To: harmony-dev@incubator.apache.org
> > > > Subject: [drlvm] newlines in .cpp and .h files
> > > >
> > > > Nathan,
> > > >
> > > > your last commit
> > > >
> > > > r431519 | ndbeyer | 2006-08-15 07:46:26 +0400 (Tue, 15 Aug 2006) |
> 1
> > > > line
> > > > Apply patch for HARMONY-1144: [j.u.c integration with DRLVM -
> step#1]:
> > > > implement getFieldOffset and modify compareAndSet<*> methods
> > > >
> > > > changed the newlines of the touched files from LF to CRLF.
> > > >
> > > > Could you please configure your editor to prevent converting line
> > > breaks?
> > > >
> > > > And could you please commit the back conversion to LF line endings?
> > > >
> > > > Thanks!
> > > >
> > > >
> > > > --------------------------------------------------------------------
> -
> > > > Terms of use : http://incubator.apache.org/harmony/mailing.html
> > > > To unsubscribe, e-mail: harmony-dev-unsubscribe@incubator.apache.org
> > > > For additional commands, e-mail: harmony-dev-
> help@incubator.apache.org
> > >
> > >
> > > ---------------------------------------------------------------------
> > > Terms of use : http://incubator.apache.org/harmony/mailing.html
> > > To unsubscribe, e-mail: harmony-dev-unsubscribe@incubator.apache.org
> > > For additional commands, e-mail: harmony-dev-help@incubator.apache.org
> >
> >
> > ---------------------------------------------------------------------
> > Terms of use : http://incubator.apache.org/harmony/mailing.html
> > To unsubscribe, e-mail: harmony-dev-unsubscribe@incubator.apache.org
> > For additional commands, e-mail: harmony-dev-help@incubator.apache.org
> >
> >
>
>
> --
> Alexey A. Petrenko
> Intel Middleware Products Division
>
> ---------------------------------------------------------------------
> Terms of use : http://incubator.apache.org/harmony/mailing.html
> To unsubscribe, e-mail: harmony-dev-unsubscribe@incubator.apache.org
> For additional commands, e-mail: harmony-dev-help@incubator.apache.org
---------------------------------------------------------------------
Terms of use : http://incubator.apache.org/harmony/mailing.html
To unsubscribe, e-mail: harmony-dev-unsubscribe@incubator.apache.org
For additional commands, e-mail: harmony-dev-help@incubator.apache.org
Re: [drlvm] newlines in .cpp and .h files
Posted by Alexey Petrenko <al...@gmail.com>.
AWT natives should be with LFs :)
SY, Alexey
2006/8/16, Nathan Beyer <nb...@kc.rr.com>:
> I looked at the files and there are any properties set, so I guess SVN isn't
> taking care of anything in this case. It wasn't my editor that changed
> anything (Eclipse) it was that the patch was submitted with CRLF endings.
>
> I looked at some of the native source files in classlib and everyone that I
> found was using the CRLF. The opposite seems to be true for all of the DRLVM
> source files.
>
> I set the SVN property on the atomics.h and atomics.ccp. Let me know if that
> fixes the issue for you. If it does, we can do a mass property set or just
> set the properties of files as they change.
>
> -Nathan
>
> > -----Original Message-----
> > From: Nathan Beyer [mailto:nbeyer@kc.rr.com]
> > Sent: Tuesday, August 15, 2006 9:51 PM
> > To: harmony-dev@incubator.apache.org
> > Subject: RE: [drlvm] newlines in .cpp and .h files
> >
> > All of the files in the commit or just one?
> >
> > I thought SVN took care of this via the svn:eol-style = native property?
> > I'll check the files, maybe this isn't set there.
> >
> > -Nathan
> >
> > > -----Original Message-----
> > > From: news [mailto:news@sea.gmane.org] On Behalf Of Salikh Zakirov
> > > Sent: Tuesday, August 15, 2006 2:20 AM
> > > To: harmony-dev@incubator.apache.org
> > > Subject: [drlvm] newlines in .cpp and .h files
> > >
> > > Nathan,
> > >
> > > your last commit
> > >
> > > r431519 | ndbeyer | 2006-08-15 07:46:26 +0400 (Tue, 15 Aug 2006) | 1
> > > line
> > > Apply patch for HARMONY-1144: [j.u.c integration with DRLVM - step#1]:
> > > implement getFieldOffset and modify compareAndSet<*> methods
> > >
> > > changed the newlines of the touched files from LF to CRLF.
> > >
> > > Could you please configure your editor to prevent converting line
> > breaks?
> > >
> > > And could you please commit the back conversion to LF line endings?
> > >
> > > Thanks!
> > >
> > >
> > > ---------------------------------------------------------------------
> > > Terms of use : http://incubator.apache.org/harmony/mailing.html
> > > To unsubscribe, e-mail: harmony-dev-unsubscribe@incubator.apache.org
> > > For additional commands, e-mail: harmony-dev-help@incubator.apache.org
> >
> >
> > ---------------------------------------------------------------------
> > Terms of use : http://incubator.apache.org/harmony/mailing.html
> > To unsubscribe, e-mail: harmony-dev-unsubscribe@incubator.apache.org
> > For additional commands, e-mail: harmony-dev-help@incubator.apache.org
>
>
> ---------------------------------------------------------------------
> Terms of use : http://incubator.apache.org/harmony/mailing.html
> To unsubscribe, e-mail: harmony-dev-unsubscribe@incubator.apache.org
> For additional commands, e-mail: harmony-dev-help@incubator.apache.org
>
>
--
Alexey A. Petrenko
Intel Middleware Products Division
---------------------------------------------------------------------
Terms of use : http://incubator.apache.org/harmony/mailing.html
To unsubscribe, e-mail: harmony-dev-unsubscribe@incubator.apache.org
For additional commands, e-mail: harmony-dev-help@incubator.apache.org
RE: [drlvm] newlines in .cpp and .h files
Posted by Nathan Beyer <nb...@kc.rr.com>.
I looked at the files and there are any properties set, so I guess SVN isn't
taking care of anything in this case. It wasn't my editor that changed
anything (Eclipse) it was that the patch was submitted with CRLF endings.
I looked at some of the native source files in classlib and everyone that I
found was using the CRLF. The opposite seems to be true for all of the DRLVM
source files.
I set the SVN property on the atomics.h and atomics.ccp. Let me know if that
fixes the issue for you. If it does, we can do a mass property set or just
set the properties of files as they change.
-Nathan
> -----Original Message-----
> From: Nathan Beyer [mailto:nbeyer@kc.rr.com]
> Sent: Tuesday, August 15, 2006 9:51 PM
> To: harmony-dev@incubator.apache.org
> Subject: RE: [drlvm] newlines in .cpp and .h files
>
> All of the files in the commit or just one?
>
> I thought SVN took care of this via the svn:eol-style = native property?
> I'll check the files, maybe this isn't set there.
>
> -Nathan
>
> > -----Original Message-----
> > From: news [mailto:news@sea.gmane.org] On Behalf Of Salikh Zakirov
> > Sent: Tuesday, August 15, 2006 2:20 AM
> > To: harmony-dev@incubator.apache.org
> > Subject: [drlvm] newlines in .cpp and .h files
> >
> > Nathan,
> >
> > your last commit
> >
> > r431519 | ndbeyer | 2006-08-15 07:46:26 +0400 (Tue, 15 Aug 2006) | 1
> > line
> > Apply patch for HARMONY-1144: [j.u.c integration with DRLVM - step#1]:
> > implement getFieldOffset and modify compareAndSet<*> methods
> >
> > changed the newlines of the touched files from LF to CRLF.
> >
> > Could you please configure your editor to prevent converting line
> breaks?
> >
> > And could you please commit the back conversion to LF line endings?
> >
> > Thanks!
> >
> >
> > ---------------------------------------------------------------------
> > Terms of use : http://incubator.apache.org/harmony/mailing.html
> > To unsubscribe, e-mail: harmony-dev-unsubscribe@incubator.apache.org
> > For additional commands, e-mail: harmony-dev-help@incubator.apache.org
>
>
> ---------------------------------------------------------------------
> Terms of use : http://incubator.apache.org/harmony/mailing.html
> To unsubscribe, e-mail: harmony-dev-unsubscribe@incubator.apache.org
> For additional commands, e-mail: harmony-dev-help@incubator.apache.org
---------------------------------------------------------------------
Terms of use : http://incubator.apache.org/harmony/mailing.html
To unsubscribe, e-mail: harmony-dev-unsubscribe@incubator.apache.org
For additional commands, e-mail: harmony-dev-help@incubator.apache.org
RE: [drlvm] newlines in .cpp and .h files
Posted by Nathan Beyer <nb...@kc.rr.com>.
All of the files in the commit or just one?
I thought SVN took care of this via the svn:eol-style = native property?
I'll check the files, maybe this isn't set there.
-Nathan
> -----Original Message-----
> From: news [mailto:news@sea.gmane.org] On Behalf Of Salikh Zakirov
> Sent: Tuesday, August 15, 2006 2:20 AM
> To: harmony-dev@incubator.apache.org
> Subject: [drlvm] newlines in .cpp and .h files
>
> Nathan,
>
> your last commit
>
> r431519 | ndbeyer | 2006-08-15 07:46:26 +0400 (Tue, 15 Aug 2006) | 1
> line
> Apply patch for HARMONY-1144: [j.u.c integration with DRLVM - step#1]:
> implement getFieldOffset and modify compareAndSet<*> methods
>
> changed the newlines of the touched files from LF to CRLF.
>
> Could you please configure your editor to prevent converting line breaks?
>
> And could you please commit the back conversion to LF line endings?
>
> Thanks!
>
>
> ---------------------------------------------------------------------
> Terms of use : http://incubator.apache.org/harmony/mailing.html
> To unsubscribe, e-mail: harmony-dev-unsubscribe@incubator.apache.org
> For additional commands, e-mail: harmony-dev-help@incubator.apache.org
---------------------------------------------------------------------
Terms of use : http://incubator.apache.org/harmony/mailing.html
To unsubscribe, e-mail: harmony-dev-unsubscribe@incubator.apache.org
For additional commands, e-mail: harmony-dev-help@incubator.apache.org