[GitHub] [flink] MartijnVisser commented on a change in pull request #18780: [FLINK-26160][pulsar][doc] update the doc of setUnboundedStopCursor()

[GitBox <gi...@apache.org>]

MartijnVisser commented on a change in pull request #18780:
URL: https://github.com/apache/flink/pull/18780#discussion_r808789593



##########
File path: flink-connectors/flink-connector-pulsar/src/main/java/org/apache/flink/connector/pulsar/source/PulsarSourceBuilder.java
##########
@@ -311,6 +311,11 @@
      * return {@link Boundedness#CONTINUOUS_UNBOUNDED} even though it will stop at the stopping
      * offsets specified by the stopping offsets {@link StopCursor}.
      *
+     * <p>However. to stop the connector user has to disable the auto partition discovery. As auto
+     * partition discovery always expected new splits to come and not exiting. To disable auto
+     * partition discovery, use builder.setConfig({@link
+     * PulsarSourceOptions.PULSAR_PARTITION_DISCOVERY_INTERVAL_MS}, -1).
+     *

Review comment:
       This is probably also worthwhile to include below line 93? 

##########
File path: flink-connectors/flink-connector-pulsar/src/main/java/org/apache/flink/connector/pulsar/source/PulsarSourceBuilder.java
##########
@@ -311,6 +311,11 @@
      * return {@link Boundedness#CONTINUOUS_UNBOUNDED} even though it will stop at the stopping

Review comment:
       For consistency purposes, I think it would be great if the text from line 89-93 and and 303-307 can be copied over, except for the different methods of course. 




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org