[GitHub] [tvm] Hzfengsy commented on a change in pull request #7923: [TensorIR][PASS][M1c] CompactBufferAllocation

[GitBox <gi...@apache.org>]

Hzfengsy commented on a change in pull request #7923:
URL: https://github.com/apache/tvm/pull/7923#discussion_r620755304



##########
File path: include/tvm/tir/stmt.h
##########
@@ -991,13 +992,22 @@ class BufferRegion : public ObjectRef {
   TVM_DLL explicit BufferRegion(Buffer buffer, Array<Range> region);
 
   /*!
-   * \brief Create a BufferRegion which is full region of the given buffer..
+   * \brief Create a BufferRegion which is full region of the given buffer.
    * \param buffer The buffer to generate full BufferRegion.
    * \return The BufferRegion which covers all region of the given buffer
    */
   TVM_DLL static BufferRegion FullRegion(Buffer buffer);
 
+  /*!
+   * \brief Create a BufferRegion which is a single point of the given buffer.
+   * \param buffer The buffer to generate single point BufferRegion.
+   * \param indices The access point indices of the buffer
+   * \return The BufferRegion which is the single point of the given buffer.
+   */
+  TVM_DLL static BufferRegion FromPoint(Buffer buffer, Array<PrimExpr> indices);

Review comment:
       `FromRegion` is not accurate. I guess `FullRegion` is good or we can call it `FromFullRegion`




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org