You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by me...@apache.org on 2021/08/04 11:38:15 UTC

[shardingsphere] branch master updated: Add java doc for some metrics class (#11644)

This is an automated email from the ASF dual-hosted git repository.

menghaoran pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/shardingsphere.git


The following commit(s) were added to refs/heads/master by this push:
     new 94fdd47  Add java doc for some metrics class (#11644)
94fdd47 is described below

commit 94fdd47a2cd15de979b78a9e00c5be68ade586d8
Author: Dachuan J <46...@users.noreply.github.com>
AuthorDate: Wed Aug 4 19:37:43 2021 +0800

    Add java doc for some metrics class (#11644)
---
 .../shardingsphere/agent/metrics/api/advice/DataSourceAdvice.java   | 6 +++---
 .../shardingsphere/agent/metrics/api/advice/PacketCodecAdvice.java  | 3 +++
 .../agent/metrics/prometheus/handler/PrometheusMetricsHandler.java  | 3 +++
 3 files changed, 9 insertions(+), 3 deletions(-)

diff --git a/shardingsphere-agent/shardingsphere-agent-plugins/shardingsphere-agent-plugin-metrics/shardingsphere-agent-metrics-api/src/main/java/org/apache/shardingsphere/agent/metrics/api/advice/DataSourceAdvice.java b/shardingsphere-agent/shardingsphere-agent-plugins/shardingsphere-agent-plugin-metrics/shardingsphere-agent-metrics-api/src/main/java/org/apache/shardingsphere/agent/metrics/api/advice/DataSourceAdvice.java
index f5cf3a2..101c26d 100644
--- a/shardingsphere-agent/shardingsphere-agent-plugins/shardingsphere-agent-plugin-metrics/shardingsphere-agent-metrics-api/src/main/java/org/apache/shardingsphere/agent/metrics/api/advice/DataSourceAdvice.java
+++ b/shardingsphere-agent/shardingsphere-agent-plugins/shardingsphere-agent-plugin-metrics/shardingsphere-agent-metrics-api/src/main/java/org/apache/shardingsphere/agent/metrics/api/advice/DataSourceAdvice.java
@@ -17,7 +17,6 @@
 
 package org.apache.shardingsphere.agent.metrics.api.advice;
 
-import lombok.extern.slf4j.Slf4j;
 import org.apache.shardingsphere.agent.api.advice.ClassStaticMethodAroundAdvice;
 import org.apache.shardingsphere.agent.api.result.MethodInvocationResult;
 import org.apache.shardingsphere.agent.metrics.api.MetricsPool;
@@ -25,7 +24,9 @@ import org.apache.shardingsphere.agent.metrics.api.constant.MetricIds;
 
 import java.lang.reflect.Method;
 
-@Slf4j
+/**
+ * Data Source advice.
+ */
 public final class DataSourceAdvice implements ClassStaticMethodAroundAdvice {
     
     static {
@@ -35,6 +36,5 @@ public final class DataSourceAdvice implements ClassStaticMethodAroundAdvice {
     @Override
     public void afterMethod(final Class<?> clazz, final Method method, final Object[] args, final MethodInvocationResult result) {
         MetricsPool.get(MetricIds.HIKARI_SET_METRICS_FACTORY).ifPresent(m -> m.delegate(result.getResult()));
-        log.info("Set metrics factory to {}", result.getResult());
     }
 }
diff --git a/shardingsphere-agent/shardingsphere-agent-plugins/shardingsphere-agent-plugin-metrics/shardingsphere-agent-metrics-api/src/main/java/org/apache/shardingsphere/agent/metrics/api/advice/PacketCodecAdvice.java b/shardingsphere-agent/shardingsphere-agent-plugins/shardingsphere-agent-plugin-metrics/shardingsphere-agent-metrics-api/src/main/java/org/apache/shardingsphere/agent/metrics/api/advice/PacketCodecAdvice.java
index e50a0f3..eb30f8e 100644
--- a/shardingsphere-agent/shardingsphere-agent-plugins/shardingsphere-agent-plugin-metrics/shardingsphere-agent-metrics-api/src/main/java/org/apache/shardingsphere/agent/metrics/api/advice/PacketCodecAdvice.java
+++ b/shardingsphere-agent/shardingsphere-agent-plugins/shardingsphere-agent-plugin-metrics/shardingsphere-agent-metrics-api/src/main/java/org/apache/shardingsphere/agent/metrics/api/advice/PacketCodecAdvice.java
@@ -26,6 +26,9 @@ import org.apache.shardingsphere.agent.metrics.api.constant.MetricIds;
 
 import java.lang.reflect.Method;
 
+/**
+ * Packet codec advice.
+ */
 public final class PacketCodecAdvice implements InstanceMethodAroundAdvice {
     
     public static final String METHOD_ENCODE = "encode";
diff --git a/shardingsphere-agent/shardingsphere-agent-plugins/shardingsphere-agent-plugin-metrics/shardingsphere-agent-metrics-prometheus/src/main/java/org/apache/shardingsphere/agent/metrics/prometheus/handler/PrometheusMetricsHandler.java b/shardingsphere-agent/shardingsphere-agent-plugins/shardingsphere-agent-plugin-metrics/shardingsphere-agent-metrics-prometheus/src/main/java/org/apache/shardingsphere/agent/metrics/prometheus/handler/PrometheusMetricsHandler.java
index 1d91ab6..809659a 100644
--- a/shardingsphere-agent/shardingsphere-agent-plugins/shardingsphere-agent-plugin-metrics/shardingsphere-agent-metrics-prometheus/src/main/java/org/apache/shardingsphere/agent/metrics/prometheus/handler/PrometheusMetricsHandler.java
+++ b/shardingsphere-agent/shardingsphere-agent-plugins/shardingsphere-agent-plugin-metrics/shardingsphere-agent-metrics-prometheus/src/main/java/org/apache/shardingsphere/agent/metrics/prometheus/handler/PrometheusMetricsHandler.java
@@ -19,12 +19,14 @@ package org.apache.shardingsphere.agent.metrics.prometheus.handler;
 
 import com.zaxxer.hikari.HikariDataSource;
 import io.prometheus.client.CollectorRegistry;
+import lombok.extern.slf4j.Slf4j;
 import org.apache.shardingsphere.agent.metrics.api.constant.MetricIds;
 import org.apache.shardingsphere.agent.metrics.prometheus.hikari.HikariMetricsTrackerFactory;
 
 /**
  * Prometheus metrics handler.
  */
+@Slf4j
 public final class PrometheusMetricsHandler {
     
     /**
@@ -38,6 +40,7 @@ public final class PrometheusMetricsHandler {
             if (object instanceof HikariDataSource) {
                 HikariDataSource dataSource = (HikariDataSource) object;
                 dataSource.setMetricsTrackerFactory(HikariMetricsTrackerFactory.getInstance(CollectorRegistry.defaultRegistry));
+                log.info("Set metrics factory to {}", dataSource);
             }
         }
     }