You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "tustvold (via GitHub)" <gi...@apache.org> on 2023/07/13 16:06:21 UTC
[GitHub] [arrow-rs] tustvold opened a new pull request, #4518: Handle empty S3 payloads (#4514)
tustvold opened a new pull request, #4518:
URL: https://github.com/apache/arrow-rs/pull/4518
# Which issue does this PR close?
<!--
We generally require a GitHub issue to be filed for all bug fixes and enhancements and this helps us generate change logs for our releases. You can link an issue to this PR using the GitHub syntax. For example `Closes #123` indicates that this PR will close issue #123.
-->
Closes #4514
# Rationale for this change
<!--
Why are you proposing this change? If this is already explained clearly in the issue then this section is not needed.
Explaining clearly why changes are proposed helps reviewers understand your changes and offer better suggestions for fixes.
-->
# What changes are included in this PR?
<!--
There is no need to duplicate the description in the issue here but it is sometimes worth providing a summary of the individual changes in this PR.
-->
# Are there any user-facing changes?
<!--
If there are user-facing changes then we may require documentation to be updated before approving the PR.
-->
<!---
If there are any breaking changes to public APIs, please add the `breaking change` label.
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] alamb commented on pull request #4518: Handle empty S3 payloads (#4514)
Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb commented on PR #4518:
URL: https://github.com/apache/arrow-rs/pull/4518#issuecomment-1635682858
@tustvold can you give me the command you used run the tests against a real S3 bucket (obviously I will supply my own AWS credentials)
I got this far (but then I stumbled on what the "metadata endpoint" should be
```
TEST_INTEGRATION=1 OBJECT_STORE_BUCKET=foo cargo test -p object_store --features=aws
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] tustvold commented on pull request #4518: Handle empty S3 payloads (#4514)
Posted by "tustvold (via GitHub)" <gi...@apache.org>.
tustvold commented on PR #4518:
URL: https://github.com/apache/arrow-rs/pull/4518#issuecomment-1635756351
Just omit the endpoint, note also that the credential names should be prefixed by OBJECT_STORE
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] alamb commented on a diff in pull request #4518: Handle empty S3 payloads (#4514)
Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb commented on code in PR #4518:
URL: https://github.com/apache/arrow-rs/pull/4518#discussion_r1263068253
##########
object_store/src/lib.rs:
##########
@@ -1258,6 +1258,15 @@ mod tests {
}
delete_fixtures(storage).await;
+
+ let path = Path::from("empty");
Review Comment:
This test appears to pass even without the code changes in this PR. See https://github.com/apache/arrow-rs/pull/4519 for example
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] tustvold merged pull request #4518: Handle empty S3 payloads (#4514)
Posted by "tustvold (via GitHub)" <gi...@apache.org>.
tustvold merged PR #4518:
URL: https://github.com/apache/arrow-rs/pull/4518
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] alamb commented on pull request #4518: Handle empty S3 payloads (#4514)
Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb commented on PR #4518:
URL: https://github.com/apache/arrow-rs/pull/4518#issuecomment-1635675703
> You need to test against real S3, the emulator doesn't seem to exhibit the same issue
I will try
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] tustvold commented on pull request #4518: Handle empty S3 payloads (#4514)
Posted by "tustvold (via GitHub)" <gi...@apache.org>.
tustvold commented on PR #4518:
URL: https://github.com/apache/arrow-rs/pull/4518#issuecomment-1634953875
You need to test against real S3, the emulator doesn't seem to exhibit the same issue
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org