You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Guangya Liu <gy...@gmail.com> on 2016/02/22 02:54:28 UTC
Review Request 43814: Enabled volume propagation for docker volume.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43814/
-----------------------------------------------------------
Review request for mesos, Jie Yu and Timothy Chen.
Bugs: MESOS-4717
https://issues.apache.org/jira/browse/MESOS-4717
Repository: mesos
Description
-------
Enabled volume propagation for docker volume.
Diffs
-----
include/mesos/mesos.proto 11a71cbe25acbc232cea6b5d72484e2e9eef6167
include/mesos/v1/mesos.proto 84e933e0bc30aa8f9b6d6047402f449666a80a23
src/docker/docker.cpp 52728707d985517e57525af7e470ccb468039373
Diff: https://reviews.apache.org/r/43814/diff/
Testing
-------
make
make check
Will rebase after https://reviews.apache.org/r/42516 , as https://reviews.apache.org/r/42516 is going to add a docker version in Docker class.
Thanks,
Guangya Liu
Re: Review Request 43814: Enabled volume propagation for docker
volume.
Posted by Guangya Liu <gy...@gmail.com>.
> On 二月 22, 2016, 3:53 a.m., haosdent huang wrote:
> > include/mesos/mesos.proto, line 1498
> > <https://reviews.apache.org/r/43814/diff/1/?file=1263750#file1263750line1498>
> >
> > I think we could not mix `rw` and propagation modes when mount, right?
Yes, we cannot. I was now asking the relationship of rw and propagation modes here: https://github.com/docker/docker/issues/20555
- Guangya
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43814/#review120098
-----------------------------------------------------------
On 二月 22, 2016, 1:54 a.m., Guangya Liu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43814/
> -----------------------------------------------------------
>
> (Updated 二月 22, 2016, 1:54 a.m.)
>
>
> Review request for mesos, Jie Yu and Timothy Chen.
>
>
> Bugs: MESOS-4717
> https://issues.apache.org/jira/browse/MESOS-4717
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Enabled volume propagation for docker volume.
>
>
> Diffs
> -----
>
> include/mesos/mesos.proto 11a71cbe25acbc232cea6b5d72484e2e9eef6167
> include/mesos/v1/mesos.proto 84e933e0bc30aa8f9b6d6047402f449666a80a23
> src/docker/docker.cpp 52728707d985517e57525af7e470ccb468039373
>
> Diff: https://reviews.apache.org/r/43814/diff/
>
>
> Testing
> -------
>
> make
> make check
>
> Will rebase after https://reviews.apache.org/r/42516 , as https://reviews.apache.org/r/42516 is going to add a docker version in Docker class.
>
>
> Thanks,
>
> Guangya Liu
>
>
Re: Review Request 43814: Enabled volume propagation for docker
volume.
Posted by haosdent huang <ha...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43814/#review120098
-----------------------------------------------------------
Ship it!
Ship It!
include/mesos/mesos.proto (line 1498)
<https://reviews.apache.org/r/43814/#comment181476>
I think we could not mix `rw` and propagation modes when mount, right?
- haosdent huang
On Feb. 22, 2016, 1:54 a.m., Guangya Liu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43814/
> -----------------------------------------------------------
>
> (Updated Feb. 22, 2016, 1:54 a.m.)
>
>
> Review request for mesos, Jie Yu and Timothy Chen.
>
>
> Bugs: MESOS-4717
> https://issues.apache.org/jira/browse/MESOS-4717
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Enabled volume propagation for docker volume.
>
>
> Diffs
> -----
>
> include/mesos/mesos.proto 11a71cbe25acbc232cea6b5d72484e2e9eef6167
> include/mesos/v1/mesos.proto 84e933e0bc30aa8f9b6d6047402f449666a80a23
> src/docker/docker.cpp 52728707d985517e57525af7e470ccb468039373
>
> Diff: https://reviews.apache.org/r/43814/diff/
>
>
> Testing
> -------
>
> make
> make check
>
> Will rebase after https://reviews.apache.org/r/42516 , as https://reviews.apache.org/r/42516 is going to add a docker version in Docker class.
>
>
> Thanks,
>
> Guangya Liu
>
>
Re: Review Request 43814: Enabled volume propagation for docker
volume.
Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43814/#review120095
-----------------------------------------------------------
Patch looks great!
Reviews applied: [43814]
Passed command: export OS='ubuntu:14.04' CONFIGURATION='--verbose' COMPILER='gcc' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh
- Mesos ReviewBot
On Feb. 22, 2016, 1:54 a.m., Guangya Liu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43814/
> -----------------------------------------------------------
>
> (Updated Feb. 22, 2016, 1:54 a.m.)
>
>
> Review request for mesos, Jie Yu and Timothy Chen.
>
>
> Bugs: MESOS-4717
> https://issues.apache.org/jira/browse/MESOS-4717
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Enabled volume propagation for docker volume.
>
>
> Diffs
> -----
>
> include/mesos/mesos.proto 11a71cbe25acbc232cea6b5d72484e2e9eef6167
> include/mesos/v1/mesos.proto 84e933e0bc30aa8f9b6d6047402f449666a80a23
> src/docker/docker.cpp 52728707d985517e57525af7e470ccb468039373
>
> Diff: https://reviews.apache.org/r/43814/diff/
>
>
> Testing
> -------
>
> make
> make check
>
> Will rebase after https://reviews.apache.org/r/42516 , as https://reviews.apache.org/r/42516 is going to add a docker version in Docker class.
>
>
> Thanks,
>
> Guangya Liu
>
>