You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Joris Van Remoortere <jo...@gmail.com> on 2016/02/15 19:55:35 UTC

Re: Review Request 43582: Added flag to disable systemd support.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43582/
-----------------------------------------------------------

(Updated Feb. 15, 2016, 6:55 p.m.)


Review request for mesos and Benjamin Hindman.


Changes
-------

re-ordering flags.


Summary (updated)
-----------------

Added flag to disable systemd support.


Bugs: MESOS-4675
    https://issues.apache.org/jira/browse/MESOS-4675


Repository: mesos


Description (updated)
-------

Added flag to disable systemd support.


Diffs (updated)
-----

  docs/configuration.md eea985cc251d6edd8476ade174b10a58aebefab1 
  src/linux/systemd.hpp d868fda3d77eb8f42a5ec9877af2e6a79bbec228 
  src/linux/systemd.cpp 13b5c8212c97912cae44fd0d7c92c93a714f695d 
  src/slave/flags.hpp 20232d645175d0d574c6d896188435277619010d 
  src/slave/flags.cpp 14ad4dcc0dfb1d7745e58e11e8f66386288395d7 
  src/slave/main.cpp 222198ca89f672332cb80773a3f36fe1f0438f64 

Diff: https://reviews.apache.org/r/43582/diff/


Testing
-------

run on systemd system with flag disabled.


Thanks,

Joris Van Remoortere

Re: Review Request 43582: Added flag to disable systemd support.

Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43582/#review119237
-----------------------------------------------------------



Patch looks great!

Reviews applied: [43582]

Passed command: export OS='ubuntu:14.04' CONFIGURATION='--verbose' COMPILER='gcc' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh

- Mesos ReviewBot


On Feb. 15, 2016, 6:55 p.m., Joris Van Remoortere wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43582/
> -----------------------------------------------------------
> 
> (Updated Feb. 15, 2016, 6:55 p.m.)
> 
> 
> Review request for mesos and Benjamin Hindman.
> 
> 
> Bugs: MESOS-4675
>     https://issues.apache.org/jira/browse/MESOS-4675
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added flag to disable systemd support.
> 
> 
> Diffs
> -----
> 
>   docs/configuration.md eea985cc251d6edd8476ade174b10a58aebefab1 
>   src/linux/systemd.hpp d868fda3d77eb8f42a5ec9877af2e6a79bbec228 
>   src/linux/systemd.cpp 13b5c8212c97912cae44fd0d7c92c93a714f695d 
>   src/slave/flags.hpp 20232d645175d0d574c6d896188435277619010d 
>   src/slave/flags.cpp 14ad4dcc0dfb1d7745e58e11e8f66386288395d7 
>   src/slave/main.cpp 222198ca89f672332cb80773a3f36fe1f0438f64 
> 
> Diff: https://reviews.apache.org/r/43582/diff/
> 
> 
> Testing
> -------
> 
> run on systemd system with flag disabled.
> 
> 
> Thanks,
> 
> Joris Van Remoortere
> 
>