You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Benjamin Hindman <be...@berkeley.edu> on 2014/10/13 06:54:53 UTC
Review Request 26635: Fixes necessary due to JSON::Array::values
change to std::vector.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26635/
-----------------------------------------------------------
Review request for mesos and Timothy Chen.
Repository: mesos-git
Description
-------
See summary.
Diffs
-----
src/docker/docker.cpp e09b51c4f5101c3a8e77caf12b208c88f47fbcb2
Diff: https://reviews.apache.org/r/26635/diff/
Testing
-------
make check
Thanks,
Benjamin Hindman
Re: Review Request 26635: Fixes necessary due to JSON::Array::values
change to std::vector.
Posted by Mesos ReviewBot <de...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26635/#review56378
-----------------------------------------------------------
Patch looks great!
Reviews applied: [26634, 26635]
All tests passed.
- Mesos ReviewBot
On Oct. 13, 2014, 4:54 a.m., Benjamin Hindman wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/26635/
> -----------------------------------------------------------
>
> (Updated Oct. 13, 2014, 4:54 a.m.)
>
>
> Review request for mesos and Timothy Chen.
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> src/docker/docker.cpp e09b51c4f5101c3a8e77caf12b208c88f47fbcb2
>
> Diff: https://reviews.apache.org/r/26635/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Benjamin Hindman
>
>
Re: Review Request 26635: Fixes necessary due to JSON::Array::values
change to std::vector.
Posted by Timothy Chen <tn...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26635/#review56376
-----------------------------------------------------------
Ship it!
Ship It!
- Timothy Chen
On Oct. 13, 2014, 4:54 a.m., Benjamin Hindman wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/26635/
> -----------------------------------------------------------
>
> (Updated Oct. 13, 2014, 4:54 a.m.)
>
>
> Review request for mesos and Timothy Chen.
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> src/docker/docker.cpp e09b51c4f5101c3a8e77caf12b208c88f47fbcb2
>
> Diff: https://reviews.apache.org/r/26635/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Benjamin Hindman
>
>