You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by GitBox <gi...@apache.org> on 2022/07/03 08:10:36 UTC
[GitHub] [doris] carlvinhust2012 opened a new pull request, #10570: [bug] fix the compile error
carlvinhust2012 opened a new pull request, #10570:
URL: https://github.com/apache/doris/pull/10570
# Proposed changes
1. fix the compile error when we compile doris be.
the compile error is as follow:
/home/disk1/hugo_work/doris_dev/baidu/bdg/doris/core/be/src/exec/mysql_scan_node.cpp:140:37: required from here
/home/disk1/hugo_work/doris_dev/baidu/bdg/doris/core/thirdparty/installed/include/fmt/core.h:1423:7: error: static assertion failed: Cannot format an argument. To make type T formattable provide a formatter<T> specialization: https://fmt.dev/latest/api.html#udt
1423 | formattable<T>(),
/home/disk1/hugo_work/doris_dev/baidu/bdg/doris/core/thirdparty/installed/include/fmt/core.h:1423:7: error: static assertion failed: Cannot format an argument. To make type T formattable provide a formatter<T> specialization: https://fmt.dev/latest/api.html#udt
1423 | formattable<T>(),
| ^~~~~~~~~~~~~~~~
/home/disk1/hugo_work/doris_dev/baidu/bdg/doris/core/thirdparty/installed/include/fmt/core.h:1423:7: note: 'fmt::v7::formattable<doris::TypeDescriptor>{std::integral_constant<bool, false>()}' evaluates to false
Issue Number: close #xxx
## Problem Summary:
Describe the overview of changes.
## Checklist(Required)
1. Does it affect the original behavior: (No)
3. Has unit tests been added: (Yes/No/No Need)
4. Has document been added or modified: (Yes/No/No Need)
5. Does it need to update dependencies: (Yes/No)
6. Are there any changes that cannot be rolled back: (Yes/No)
## Further comments
If this is a relatively large or complex change, kick off the discussion at [dev@doris.apache.org](mailto:dev@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] carlvinhust2012 commented on pull request #10570: [bug] fix the compile error
Posted by GitBox <gi...@apache.org>.
carlvinhust2012 commented on PR #10570:
URL: https://github.com/apache/doris/pull/10570#issuecomment-1173102818
> I can do the compile without your PR. Is there any special in your env?
no special.I just run "git pull --rebase upstream master" to update the local code.
I have a test that create a new branch from master branch with pr9533 and it also report compile error.
after I revert the pr9533，it can compile successfully.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] morningman commented on pull request #10570: [bug] fix the compile error
Posted by GitBox <gi...@apache.org>.
morningman commented on PR #10570:
URL: https://github.com/apache/doris/pull/10570#issuecomment-1173072758
The PR #9533 pass the checks, why it still cause compilation error?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #10570: [bug] fix the compile error
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #10570:
URL: https://github.com/apache/doris/pull/10570#issuecomment-1173290183
PR approved by anyone and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] BiteTheDDDDt merged pull request #10570: [bug] fix the compile error
Posted by GitBox <gi...@apache.org>.
BiteTheDDDDt merged PR #10570:
URL: https://github.com/apache/doris/pull/10570
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] carlvinhust2012 commented on pull request #10570: [bug] fix the compile error
Posted by GitBox <gi...@apache.org>.
carlvinhust2012 commented on PR #10570:
URL: https://github.com/apache/doris/pull/10570#issuecomment-1173075315
> The PR #9533 pass the checks, why it still cause compilation error?
I also confuse the pr 9533 how to pass the checks.
Because slot->type() just overload the operator <<, and can’t support the fmt.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] morningman commented on pull request #10570: [bug] fix the compile error
Posted by GitBox <gi...@apache.org>.
morningman commented on PR #10570:
URL: https://github.com/apache/doris/pull/10570#issuecomment-1173096935
I can do the compile without your PR. Is there any special in your env?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #10570: [bug] fix the compile error
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #10570:
URL: https://github.com/apache/doris/pull/10570#issuecomment-1173290164
PR approved by at least one committer and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] BiteTheDDDDt commented on pull request #10570: [bug] fix the compile error
Posted by GitBox <gi...@apache.org>.
BiteTheDDDDt commented on PR #10570:
URL: https://github.com/apache/doris/pull/10570#issuecomment-1173288473
I had same problem, build fail with clang.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org