You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@ofbiz.apache.org by si...@apache.org on 2008/08/15 20:15:39 UTC
svn commit: r686301 - in /ofbiz/trunk/framework/webapp: dtd/site-conf.xsd
src/org/ofbiz/webapp/control/ConfigXMLReader.java
src/org/ofbiz/webapp/control/RequestHandler.java
Author: sichen
Date: Fri Aug 15 11:15:39 2008
New Revision: 686301
URL: http://svn.apache.org/viewvc?rev=686301&view=rev
Log:
OFBIZ-1915 from Jeremy Wickersheimer for request-redirect-filter-param
Modified:
ofbiz/trunk/framework/webapp/dtd/site-conf.xsd
ofbiz/trunk/framework/webapp/src/org/ofbiz/webapp/control/ConfigXMLReader.java
ofbiz/trunk/framework/webapp/src/org/ofbiz/webapp/control/RequestHandler.java
Modified: ofbiz/trunk/framework/webapp/dtd/site-conf.xsd
URL: http://svn.apache.org/viewvc/ofbiz/trunk/framework/webapp/dtd/site-conf.xsd?rev=686301&r1=686300&r2=686301&view=diff
==============================================================================
--- ofbiz/trunk/framework/webapp/dtd/site-conf.xsd (original)
+++ ofbiz/trunk/framework/webapp/dtd/site-conf.xsd Fri Aug 15 11:15:39 2008
@@ -235,11 +235,14 @@
<xs:enumeration value="request"/>
<xs:enumeration value="request-redirect"/>
<xs:enumeration value="request-redirect-noparam"/>
+ <xs:enumeration value="request-redirect-filterparam"/>
<xs:enumeration value="url"/>
</xs:restriction>
</xs:simpleType>
</xs:attribute>
<xs:attribute type="xs:string" name="value"/>
+ <xs:attribute type="xs:string" name="allowed-params"/>
+ <xs:attribute type="xs:string" name="allowed-attributes"/>
</xs:attributeGroup>
<xs:element name="view-map">
<xs:complexType>
Modified: ofbiz/trunk/framework/webapp/src/org/ofbiz/webapp/control/ConfigXMLReader.java
URL: http://svn.apache.org/viewvc/ofbiz/trunk/framework/webapp/src/org/ofbiz/webapp/control/ConfigXMLReader.java?rev=686301&r1=686300&r2=686301&view=diff
==============================================================================
--- ofbiz/trunk/framework/webapp/src/org/ofbiz/webapp/control/ConfigXMLReader.java (original)
+++ ofbiz/trunk/framework/webapp/src/org/ofbiz/webapp/control/ConfigXMLReader.java Fri Aug 15 11:15:39 2008
@@ -22,10 +22,12 @@
import java.io.IOException;
import java.net.MalformedURLException;
import java.net.URL;
+import java.util.Arrays;
import java.util.Iterator;
import java.util.List;
import java.util.Map;
import java.util.Set;
+import java.util.HashSet;
import javolution.util.FastList;
import javolution.util.FastMap;
@@ -210,6 +212,8 @@
public static final String RESPONSE_TYPE = "type";
public static final String RESPONSE_VALUE = "value";
public static final String RESPONSE_MAP = "response-map";
+ public static final String RESPONSE_ALLOWEDPARAMS = "allowed-params";
+ public static final String RESPONSE_ALLOWEDATTRIBUTES = "allowed-attributes";
/** View Config Variables */
public static final String VIEW_MAPPING = "view-map";
@@ -331,7 +335,7 @@
uriMap.put(REQUEST_DESCRIPTION, UtilValidate.isNotEmpty(description) ? description : "");
// Get the response(s).
- Map<String, String> responseMap = FastMap.newInstance();
+ Map<String, Object> responseMap = FastMap.newInstance();
uriMap.put(RESPONSE_MAP, responseMap);
for (Element responseElement: UtilXml.childElementList(requestMapElement, RESPONSE)) {
@@ -339,6 +343,20 @@
String type = responseElement.getAttribute(RESPONSE_TYPE);
String value = responseElement.getAttribute(RESPONSE_VALUE);
+ String allowedParams = responseElement.getAttribute(RESPONSE_ALLOWEDPARAMS);
+ if (allowedParams != null && allowedParams.length() > 0) {
+ String[] allowedParamsList = allowedParams.split(",");
+ Set allowedParamsSet = new HashSet();
+ allowedParamsSet.addAll(Arrays.asList(allowedParamsList));
+ responseMap.put(RESPONSE_ALLOWEDPARAMS, allowedParamsSet);
+ }
+ String allowedAttributes = responseElement.getAttribute(RESPONSE_ALLOWEDATTRIBUTES);
+ if (allowedAttributes != null && allowedAttributes.length() > 0) {
+ String[] allowedAttributesList = allowedAttributes.split(",");
+ Set allowedAttributesSet = new HashSet();
+ allowedAttributesSet.addAll(Arrays.asList(allowedAttributesList));
+ responseMap.put(RESPONSE_ALLOWEDATTRIBUTES, allowedAttributesSet);
+ }
responseMap.put(name, type + ":" + value);
}
Modified: ofbiz/trunk/framework/webapp/src/org/ofbiz/webapp/control/RequestHandler.java
URL: http://svn.apache.org/viewvc/ofbiz/trunk/framework/webapp/src/org/ofbiz/webapp/control/RequestHandler.java?rev=686301&r1=686300&r2=686301&view=diff
==============================================================================
--- ofbiz/trunk/framework/webapp/src/org/ofbiz/webapp/control/RequestHandler.java (original)
+++ ofbiz/trunk/framework/webapp/src/org/ofbiz/webapp/control/RequestHandler.java Fri Aug 15 11:15:39 2008
@@ -418,6 +418,15 @@
Debug.logInfo("[RequestHandler.doRequest]: Response is a Request redirect with no parameters." + " sessionId=" + UtilHttp.getSessionId(request), module);
nextView = nextView.substring(25);
callRedirect(makeLink(request, response, nextView), response, request);
+ } else if (nextView != null && nextView.startsWith("request-redirect-filterparam:")) {
+ // check for a Request redirect
+ Debug.logInfo("[RequestHandler.doRequest]: Response is a Request redirect with filtered parameters." + " sessionId=" + UtilHttp.getSessionId(request), module);
+ nextView = nextView.substring(29);
+ Set allowedParams = (Set)requestManager.getRequestMapMap(requestUri).get(ConfigXMLReader.RESPONSE_MAP).get(ConfigXMLReader.RESPONSE_ALLOWEDPARAMS);
+ Set allowedAttributes = (Set)requestManager.getRequestMapMap(requestUri).get(ConfigXMLReader.RESPONSE_MAP).get(ConfigXMLReader.RESPONSE_ALLOWEDATTRIBUTES);
+ if (allowedParams != null) Debug.logInfo("Filtering parameters : "+allowedParams, module);
+ if (allowedAttributes != null) Debug.logInfo("Filtering attributes : "+allowedAttributes, module);
+ callRedirect(makeLinkWithQueryString(request, response, "/" + nextView, allowedParams, allowedAttributes), response, request);
} else if (nextView != null && nextView.startsWith("view:")) {
// check for a View
Debug.logInfo("[RequestHandler.doRequest]: Response is a view." + " sessionId=" + UtilHttp.getSessionId(request), module);
@@ -466,12 +475,23 @@
queryString.append(name);
queryString.append("=");
queryString.append(value);
+ } else {
+ Debug.logInfo("found param not a String: "+name+" = "+value, module);
}
+
}
}
return queryString.toString();
}
+ public String makeQueryString(HttpServletRequest request, Set allowedParams) {
+ return makeQueryString(request, null, null);
+ }
+
+ public String makeQueryString(HttpServletRequest request) {
+ return makeQueryString(request, null);
+ }
+
/** Returns the RequestManager Object. */
public RequestManager getRequestManager() {
return requestManager;
@@ -696,12 +716,16 @@
}
- public String makeLinkWithQueryString(HttpServletRequest request, HttpServletResponse response, String url) {
+ public String makeLinkWithQueryString(HttpServletRequest request, HttpServletResponse response, String url, Set allowedParams, Set allowedAttributes) {
String initialLink = this.makeLink(request, response, url);
- String queryString = this.makeQueryString(request);
+ String queryString = this.makeQueryString(request, allowedParams, allowedAttributes);
return initialLink + queryString;
}
+ public String makeLinkWithQueryString(HttpServletRequest request, HttpServletResponse response, String url) {
+ return makeLinkWithQueryString(request, response, url, null, null);
+ }
+
public String makeLink(HttpServletRequest request, HttpServletResponse response, String url) {
return makeLink(request, response, url, false, false, true);
}
Re: Fwd: svn commit: r686301 - in /ofbiz/trunk/framework/webapp: dtd/site-conf.xsd src/org/ofbiz/webapp/control/ConfigXMLReader.java src/org/ofbiz/webapp/control/RequestHandler.java
Posted by Scott Gray <le...@gmail.com>.
I don't personally have a problem with it, mostly because there aren't
many commits from Si and they seem to do more good than harm.
-Scott
2008/8/16 Adam Heath <do...@brainfood.com>:
> Scott Gray wrote:
>>
>> Forwarding since Si doesn't subscribe to the dev list
>
> Er, he has commit access, but doesn't subscribe? Should this be disallowed?
>
Re: svn commit: r686301 - in /ofbiz/trunk/framework/webapp: dtd/site-conf.xsd src/org/ofbiz/webapp/control/ConfigXMLReader.java src/org/ofbiz/webapp/control/RequestHandler.java
Posted by Jacques Le Roux <ja...@les7arts.com>.
I agree with Scoot and so with you, David
Jacques
From: "David E Jones" <jo...@hotwaxmedia.com>
>
> On Aug 15, 2008, at 2:20 PM, Adam Heath wrote:
>
>> Scott Gray wrote:
>>> Forwarding since Si doesn't subscribe to the dev list
>>
>> Er, he has commit access, but doesn't subscribe? Should this be
>> disallowed?
>
> There are definitely people that have a problem with this, and it is a
> weird situation. It is true that all committers should follow the dev
> list and watch for things for them, as well as for things that relate
> to things they have worked on. They should also monitor the commits
> list to monitor all changes to areas of the project they are familiar
> with.
>
> Unfortunately Si seems to have chosen not to do this, and not to stay
> involved in this way with OFBiz. It's also unfortunate that he doesn't
> discuss his changes a whole lot, and issues do tend to come up with
> them that are often not resolved or not adequately resolved. In other
> words, he usually uses his commit privileges to get things into the
> project quickly for his convenience and isn't really participating in
> the community.
>
> While unfortunate, what to do about it is another question. Should the
> PMC really vote to remove his commit privileges? My guess is no, that
> wouldn't be a good action or conducive to community building.
>
> So instead we keep a close eye on his commits, knowing that dues to
> his infrequent community interactions and commits that he may have a
> harder time with things that he puts in. Along with this, as Scott
> mentioned, he does contribute valuable things here and there and that
> is great for the project. There are other people in this boat to, and
> really all committers should review the work of other committers for
> the sake of the project.
>
> Anyway, it's something on the back-burner and not something that there
> seems to be something to do about right away, and whether there is
> anything the PMC could do to improve the situation or not is still a
> big question.
>
> -David
>
>
Re: svn commit: r686301 - in /ofbiz/trunk/framework/webapp: dtd/site-conf.xsd src/org/ofbiz/webapp/control/ConfigXMLReader.java src/org/ofbiz/webapp/control/RequestHandler.java
Posted by Tim Ruppert <ti...@hotwaxmedia.com>.
That's kinda ridiculous BJ. There are committer guidelines that if
they are not being followed, then as a community we have to figure out
what to do in that case. If non-committers don't follow the rules of
posting, do we still get their contributions in there? I don't think
so. So, my only point is that there's no one out there who should get
special treatment, but their history should be thought of and they
should be asked to comply to the guidelines that the community has
agreed upon.
Cheers,
Tim
--
Tim Ruppert
HotWax Media
http://www.hotwaxmedia.com
o:801.649.6594
f:801.649.6595
On Aug 16, 2008, at 10:23 AM, BJ Freeman wrote:
> So it comes down to :is his contribution worth the hassle".
> That would, imho, be like saying those that don't have commit rights
> should not be considered.
> But I find there are committers that are willing to make the extra
> effort to help those that can not.
> On that note as long as there is one commiter that is willing to
> monitor
> or facilitate the changes Si makes, there should not be any action
> taken.
>
> Only when every committer has voice a negative should there be any
> action take.
>
>
>
> Tim Ruppert sent the following on 8/16/2008 8:55 AM:
>> My position would be that if he doesn't want to be part of the
>> community, why should everyone else bear the burden of watching him
>> more
>> closely than anyone else? It's kinda ridiculous.
>>
>> That being said, Si has made invaluable contributions throughout the
>> years, so my vote would be to talk with him about following the best
>> practices of being a committer and give him this leeway to comply.
>> Should he continue to decide not too, it is not the responsibility of
>> the rest of the community to perform additional work because of it
>> and
>> his rights should be removed.
>>
>> My two cents.
>>
>> Cheers,
>> Tim
>> --
>> Tim Ruppert
>> HotWax Media
>> http://www.hotwaxmedia.com
>>
>> o:801.649.6594
>> f:801.649.6595
>>
>>
>> On Aug 16, 2008, at 9:04 AM, Jacopo Cappellato wrote:
>>
>>> I know this is an annoying situation, but since Si in the past few
>>> months has ignored our suggestion to discuss things in the mailing
>>> lists, instead of just writing uni-directional messages using
>>> Jira, I
>>> don't think we will have any luck in this. I am sure he understands
>>> this is far from an optimal setup (as I am sure that he would be
>>> able
>>> to create message filters for managing the volume of the ml
>>> traffic),
>>> and we can't (nor want) force him to do something he has decided to
>>> not concede us.
>>>
>>> Jacopo
>>>
>>> On Aug 16, 2008, at 4:26 PM, Adrian Crum wrote:
>>>
>>>> How about we issue a "strongly worded letter?" ;-)
>>>>
>>>> Seriously though, when I first subscribed to the lists, I balked at
>>>> the volume of incoming mail. I still needed to read it so I set up
>>>> filters to sort it. I'm sure Si could do the same.
>>>>
>>>> I agree he should retain his commit privileges, but I also
>>>> believe he
>>>> needs to participate in the dev list (at least).
>>>>
>>>> -Adrian
>>>>
>>>>
>>>> --- On Fri, 8/15/08, David E Jones <jo...@hotwaxmedia.com> wrote:
>>>>
>>>>> From: David E Jones <jo...@hotwaxmedia.com>
>>>>> Subject: Re: svn commit: r686301 - in /ofbiz/trunk/framework/
>>>>> webapp:
>>>>> dtd/site-conf.xsd src/org/ofbiz/webapp/control/
>>>>> ConfigXMLReader.java
>>>>> src/org/ofbiz/webapp/control/RequestHandler.java
>>>>> To: dev@ofbiz.apache.org
>>>>> Date: Friday, August 15, 2008, 9:01 PM
>>>>> On Aug 15, 2008, at 2:20 PM, Adam Heath wrote:
>>>>>
>>>>>> Scott Gray wrote:
>>>>>>> Forwarding since Si doesn't subscribe to the
>>>>> dev list
>>>>>>
>>>>>> Er, he has commit access, but doesn't subscribe?
>>>>> Should this be
>>>>>> disallowed?
>>>>>
>>>>> There are definitely people that have a problem with this,
>>>>> and it is a
>>>>> weird situation. It is true that all committers should
>>>>> follow the dev
>>>>> list and watch for things for them, as well as for things
>>>>> that relate
>>>>> to things they have worked on. They should also monitor the
>>>>> commits
>>>>> list to monitor all changes to areas of the project they
>>>>> are familiar
>>>>> with.
>>>>>
>>>>> Unfortunately Si seems to have chosen not to do this, and
>>>>> not to stay
>>>>> involved in this way with OFBiz. It's also unfortunate
>>>>> that he doesn't
>>>>> discuss his changes a whole lot, and issues do tend to come
>>>>> up with
>>>>> them that are often not resolved or not adequately
>>>>> resolved. In other
>>>>> words, he usually uses his commit privileges to get things
>>>>> into the
>>>>> project quickly for his convenience and isn't really
>>>>> participating in
>>>>> the community.
>>>>>
>>>>> While unfortunate, what to do about it is another question.
>>>>> Should the
>>>>> PMC really vote to remove his commit privileges? My guess
>>>>> is no, that
>>>>> wouldn't be a good action or conducive to community
>>>>> building.
>>>>>
>>>>> So instead we keep a close eye on his commits, knowing that
>>>>> dues to
>>>>> his infrequent community interactions and commits that he
>>>>> may have a
>>>>> harder time with things that he puts in. Along with this,
>>>>> as Scott
>>>>> mentioned, he does contribute valuable things here and
>>>>> there and that
>>>>> is great for the project. There are other people in this
>>>>> boat to, and
>>>>> really all committers should review the work of other
>>>>> committers for
>>>>> the sake of the project.
>>>>>
>>>>> Anyway, it's something on the back-burner and not
>>>>> something that there
>>>>> seems to be something to do about right away, and whether
>>>>> there is
>>>>> anything the PMC could do to improve the situation or not
>>>>> is still a
>>>>> big question.
>>>>>
>>>>> -David
>>>>
>>>>
>>>>
>>>
>>
>
Re: svn commit: r686301 - in /ofbiz/trunk/framework/webapp: dtd/site-conf.xsd
src/org/ofbiz/webapp/control/ConfigXMLReader.java src/org/ofbiz/webapp/control/RequestHandler.java
Posted by BJ Freeman <bj...@free-man.net>.
So it comes down to :is his contribution worth the hassle".
That would, imho, be like saying those that don't have commit rights
should not be considered.
But I find there are committers that are willing to make the extra
effort to help those that can not.
On that note as long as there is one commiter that is willing to monitor
or facilitate the changes Si makes, there should not be any action taken.
Only when every committer has voice a negative should there be any
action take.
Tim Ruppert sent the following on 8/16/2008 8:55 AM:
> My position would be that if he doesn't want to be part of the
> community, why should everyone else bear the burden of watching him more
> closely than anyone else? It's kinda ridiculous.
>
> That being said, Si has made invaluable contributions throughout the
> years, so my vote would be to talk with him about following the best
> practices of being a committer and give him this leeway to comply.
> Should he continue to decide not too, it is not the responsibility of
> the rest of the community to perform additional work because of it and
> his rights should be removed.
>
> My two cents.
>
> Cheers,
> Tim
> --
> Tim Ruppert
> HotWax Media
> http://www.hotwaxmedia.com
>
> o:801.649.6594
> f:801.649.6595
>
>
> On Aug 16, 2008, at 9:04 AM, Jacopo Cappellato wrote:
>
>> I know this is an annoying situation, but since Si in the past few
>> months has ignored our suggestion to discuss things in the mailing
>> lists, instead of just writing uni-directional messages using Jira, I
>> don't think we will have any luck in this. I am sure he understands
>> this is far from an optimal setup (as I am sure that he would be able
>> to create message filters for managing the volume of the ml traffic),
>> and we can't (nor want) force him to do something he has decided to
>> not concede us.
>>
>> Jacopo
>>
>> On Aug 16, 2008, at 4:26 PM, Adrian Crum wrote:
>>
>>> How about we issue a "strongly worded letter?" ;-)
>>>
>>> Seriously though, when I first subscribed to the lists, I balked at
>>> the volume of incoming mail. I still needed to read it so I set up
>>> filters to sort it. I'm sure Si could do the same.
>>>
>>> I agree he should retain his commit privileges, but I also believe he
>>> needs to participate in the dev list (at least).
>>>
>>> -Adrian
>>>
>>>
>>> --- On Fri, 8/15/08, David E Jones <jo...@hotwaxmedia.com> wrote:
>>>
>>>> From: David E Jones <jo...@hotwaxmedia.com>
>>>> Subject: Re: svn commit: r686301 - in /ofbiz/trunk/framework/webapp:
>>>> dtd/site-conf.xsd src/org/ofbiz/webapp/control/ConfigXMLReader.java
>>>> src/org/ofbiz/webapp/control/RequestHandler.java
>>>> To: dev@ofbiz.apache.org
>>>> Date: Friday, August 15, 2008, 9:01 PM
>>>> On Aug 15, 2008, at 2:20 PM, Adam Heath wrote:
>>>>
>>>>> Scott Gray wrote:
>>>>>> Forwarding since Si doesn't subscribe to the
>>>> dev list
>>>>>
>>>>> Er, he has commit access, but doesn't subscribe?
>>>> Should this be
>>>>> disallowed?
>>>>
>>>> There are definitely people that have a problem with this,
>>>> and it is a
>>>> weird situation. It is true that all committers should
>>>> follow the dev
>>>> list and watch for things for them, as well as for things
>>>> that relate
>>>> to things they have worked on. They should also monitor the
>>>> commits
>>>> list to monitor all changes to areas of the project they
>>>> are familiar
>>>> with.
>>>>
>>>> Unfortunately Si seems to have chosen not to do this, and
>>>> not to stay
>>>> involved in this way with OFBiz. It's also unfortunate
>>>> that he doesn't
>>>> discuss his changes a whole lot, and issues do tend to come
>>>> up with
>>>> them that are often not resolved or not adequately
>>>> resolved. In other
>>>> words, he usually uses his commit privileges to get things
>>>> into the
>>>> project quickly for his convenience and isn't really
>>>> participating in
>>>> the community.
>>>>
>>>> While unfortunate, what to do about it is another question.
>>>> Should the
>>>> PMC really vote to remove his commit privileges? My guess
>>>> is no, that
>>>> wouldn't be a good action or conducive to community
>>>> building.
>>>>
>>>> So instead we keep a close eye on his commits, knowing that
>>>> dues to
>>>> his infrequent community interactions and commits that he
>>>> may have a
>>>> harder time with things that he puts in. Along with this,
>>>> as Scott
>>>> mentioned, he does contribute valuable things here and
>>>> there and that
>>>> is great for the project. There are other people in this
>>>> boat to, and
>>>> really all committers should review the work of other
>>>> committers for
>>>> the sake of the project.
>>>>
>>>> Anyway, it's something on the back-burner and not
>>>> something that there
>>>> seems to be something to do about right away, and whether
>>>> there is
>>>> anything the PMC could do to improve the situation or not
>>>> is still a
>>>> big question.
>>>>
>>>> -David
>>>
>>>
>>>
>>
>
Re: svn commit: r686301 - in /ofbiz/trunk/framework/webapp: dtd/site-conf.xsd src/org/ofbiz/webapp/control/ConfigXMLReader.java src/org/ofbiz/webapp/control/RequestHandler.java
Posted by Tim Ruppert <ti...@hotwaxmedia.com>.
+1 - if we have requirements - let's follow them.
Cheers,
Tim
--
Tim Ruppert
HotWax Media
http://www.hotwaxmedia.com
o:801.649.6594
f:801.649.6595
On Aug 16, 2008, at 8:04 PM, Adam Heath wrote:
> Scott Gray wrote:
>> I'm pretty sure that if we removed Si's commit access then we would
>> probably never see another contribution from him. So I guess the
>> community needs to decide if we would rather look a little closer at
>> his commits or not have them at all.
>
> Er, maybe.
>
> I've been a committer to OfBiz at two different times. I was
> removed the first time due to lack of involvment, and time. OfBiz
> switched hosting providers, and didn't bother to add me on the new
> system, due to those two issues. I was a little upset, it was true;
> not because I was removed, but because I wasn't told I was removed.
> However, I got over it. I admitted I was too busy.
>
> However, that has now changed now. I realized that it was worth my
> while.
>
> To put it bluntly: commit access is not a right, but a privilege.
> There are requirements one must follow to keep it. The time
> required to participate is not that much.
>
> I've worked with debian in the past, I know full well how much time
> it takes; OfBiz participation is much simpler. And, at least with
> OfBiz, the payoffs to me and to who I work for are obvious. Is it
> too much to ask to be subscribed to this mailing list?
Re: svn commit: r686301 - in /ofbiz/trunk/framework/webapp: dtd/site-conf.xsd
src/org/ofbiz/webapp/control/ConfigXMLReader.java src/org/ofbiz/webapp/control/RequestHandler.java
Posted by Adam Heath <do...@brainfood.com>.
Scott Gray wrote:
> I'm pretty sure that if we removed Si's commit access then we would
> probably never see another contribution from him. So I guess the
> community needs to decide if we would rather look a little closer at
> his commits or not have them at all.
Er, maybe.
I've been a committer to OfBiz at two different times. I was removed
the first time due to lack of involvment, and time. OfBiz switched
hosting providers, and didn't bother to add me on the new system, due to
those two issues. I was a little upset, it was true; not because I was
removed, but because I wasn't told I was removed. However, I got over
it. I admitted I was too busy.
However, that has now changed now. I realized that it was worth my while.
To put it bluntly: commit access is not a right, but a privilege. There
are requirements one must follow to keep it. The time required to
participate is not that much.
I've worked with debian in the past, I know full well how much time it
takes; OfBiz participation is much simpler. And, at least with OfBiz,
the payoffs to me and to who I work for are obvious. Is it too much to
ask to be subscribed to this mailing list?
Re: svn commit: r686301 - in /ofbiz/trunk/framework/webapp: dtd/site-conf.xsd src/org/ofbiz/webapp/control/ConfigXMLReader.java src/org/ofbiz/webapp/control/RequestHandler.java
Posted by Scott Gray <le...@gmail.com>.
I'm pretty sure that if we removed Si's commit access then we would
probably never see another contribution from him. So I guess the
community needs to decide if we would rather look a little closer at
his commits or not have them at all.
Regards
Scott
2008/8/17 Tim Ruppert <ti...@hotwaxmedia.com>:
> My position would be that if he doesn't want to be part of the community,
> why should everyone else bear the burden of watching him more closely than
> anyone else? It's kinda ridiculous.
>
> That being said, Si has made invaluable contributions throughout the years,
> so my vote would be to talk with him about following the best practices of
> being a committer and give him this leeway to comply. Should he continue to
> decide not too, it is not the responsibility of the rest of the community to
> perform additional work because of it and his rights should be removed.
>
> My two cents.
>
> Cheers,
> Tim
> --
> Tim Ruppert
> HotWax Media
> http://www.hotwaxmedia.com
>
> o:801.649.6594
> f:801.649.6595
>
>
> On Aug 16, 2008, at 9:04 AM, Jacopo Cappellato wrote:
>
>> I know this is an annoying situation, but since Si in the past few months
>> has ignored our suggestion to discuss things in the mailing lists, instead
>> of just writing uni-directional messages using Jira, I don't think we will
>> have any luck in this. I am sure he understands this is far from an optimal
>> setup (as I am sure that he would be able to create message filters for
>> managing the volume of the ml traffic), and we can't (nor want) force him to
>> do something he has decided to not concede us.
>>
>> Jacopo
>>
>> On Aug 16, 2008, at 4:26 PM, Adrian Crum wrote:
>>
>>> How about we issue a "strongly worded letter?" ;-)
>>>
>>> Seriously though, when I first subscribed to the lists, I balked at the
>>> volume of incoming mail. I still needed to read it so I set up filters to
>>> sort it. I'm sure Si could do the same.
>>>
>>> I agree he should retain his commit privileges, but I also believe he
>>> needs to participate in the dev list (at least).
>>>
>>> -Adrian
>>>
>>>
>>> --- On Fri, 8/15/08, David E Jones <jo...@hotwaxmedia.com> wrote:
>>>
>>>> From: David E Jones <jo...@hotwaxmedia.com>
>>>> Subject: Re: svn commit: r686301 - in /ofbiz/trunk/framework/webapp:
>>>> dtd/site-conf.xsd src/org/ofbiz/webapp/control/ConfigXMLReader.java
>>>> src/org/ofbiz/webapp/control/RequestHandler.java
>>>> To: dev@ofbiz.apache.org
>>>> Date: Friday, August 15, 2008, 9:01 PM
>>>> On Aug 15, 2008, at 2:20 PM, Adam Heath wrote:
>>>>
>>>>> Scott Gray wrote:
>>>>>>
>>>>>> Forwarding since Si doesn't subscribe to the
>>>>
>>>> dev list
>>>>>
>>>>> Er, he has commit access, but doesn't subscribe?
>>>>
>>>> Should this be
>>>>>
>>>>> disallowed?
>>>>
>>>> There are definitely people that have a problem with this,
>>>> and it is a
>>>> weird situation. It is true that all committers should
>>>> follow the dev
>>>> list and watch for things for them, as well as for things
>>>> that relate
>>>> to things they have worked on. They should also monitor the
>>>> commits
>>>> list to monitor all changes to areas of the project they
>>>> are familiar
>>>> with.
>>>>
>>>> Unfortunately Si seems to have chosen not to do this, and
>>>> not to stay
>>>> involved in this way with OFBiz. It's also unfortunate
>>>> that he doesn't
>>>> discuss his changes a whole lot, and issues do tend to come
>>>> up with
>>>> them that are often not resolved or not adequately
>>>> resolved. In other
>>>> words, he usually uses his commit privileges to get things
>>>> into the
>>>> project quickly for his convenience and isn't really
>>>> participating in
>>>> the community.
>>>>
>>>> While unfortunate, what to do about it is another question.
>>>> Should the
>>>> PMC really vote to remove his commit privileges? My guess
>>>> is no, that
>>>> wouldn't be a good action or conducive to community
>>>> building.
>>>>
>>>> So instead we keep a close eye on his commits, knowing that
>>>> dues to
>>>> his infrequent community interactions and commits that he
>>>> may have a
>>>> harder time with things that he puts in. Along with this,
>>>> as Scott
>>>> mentioned, he does contribute valuable things here and
>>>> there and that
>>>> is great for the project. There are other people in this
>>>> boat to, and
>>>> really all committers should review the work of other
>>>> committers for
>>>> the sake of the project.
>>>>
>>>> Anyway, it's something on the back-burner and not
>>>> something that there
>>>> seems to be something to do about right away, and whether
>>>> there is
>>>> anything the PMC could do to improve the situation or not
>>>> is still a
>>>> big question.
>>>>
>>>> -David
>>>
>>>
>>>
>>
>
>
Re: svn commit: r686301 - in /ofbiz/trunk/framework/webapp: dtd/site-conf.xsd src/org/ofbiz/webapp/control/ConfigXMLReader.java src/org/ofbiz/webapp/control/RequestHandler.java
Posted by Tim Ruppert <ti...@hotwaxmedia.com>.
My position would be that if he doesn't want to be part of the
community, why should everyone else bear the burden of watching him
more closely than anyone else? It's kinda ridiculous.
That being said, Si has made invaluable contributions throughout the
years, so my vote would be to talk with him about following the best
practices of being a committer and give him this leeway to comply.
Should he continue to decide not too, it is not the responsibility of
the rest of the community to perform additional work because of it and
his rights should be removed.
My two cents.
Cheers,
Tim
--
Tim Ruppert
HotWax Media
http://www.hotwaxmedia.com
o:801.649.6594
f:801.649.6595
On Aug 16, 2008, at 9:04 AM, Jacopo Cappellato wrote:
> I know this is an annoying situation, but since Si in the past few
> months has ignored our suggestion to discuss things in the mailing
> lists, instead of just writing uni-directional messages using Jira,
> I don't think we will have any luck in this. I am sure he
> understands this is far from an optimal setup (as I am sure that he
> would be able to create message filters for managing the volume of
> the ml traffic), and we can't (nor want) force him to do something
> he has decided to not concede us.
>
> Jacopo
>
> On Aug 16, 2008, at 4:26 PM, Adrian Crum wrote:
>
>> How about we issue a "strongly worded letter?" ;-)
>>
>> Seriously though, when I first subscribed to the lists, I balked at
>> the volume of incoming mail. I still needed to read it so I set up
>> filters to sort it. I'm sure Si could do the same.
>>
>> I agree he should retain his commit privileges, but I also believe
>> he needs to participate in the dev list (at least).
>>
>> -Adrian
>>
>>
>> --- On Fri, 8/15/08, David E Jones <jo...@hotwaxmedia.com> wrote:
>>
>>> From: David E Jones <jo...@hotwaxmedia.com>
>>> Subject: Re: svn commit: r686301 - in /ofbiz/trunk/framework/
>>> webapp: dtd/site-conf.xsd src/org/ofbiz/webapp/control/
>>> ConfigXMLReader.java src/org/ofbiz/webapp/control/
>>> RequestHandler.java
>>> To: dev@ofbiz.apache.org
>>> Date: Friday, August 15, 2008, 9:01 PM
>>> On Aug 15, 2008, at 2:20 PM, Adam Heath wrote:
>>>
>>>> Scott Gray wrote:
>>>>> Forwarding since Si doesn't subscribe to the
>>> dev list
>>>>
>>>> Er, he has commit access, but doesn't subscribe?
>>> Should this be
>>>> disallowed?
>>>
>>> There are definitely people that have a problem with this,
>>> and it is a
>>> weird situation. It is true that all committers should
>>> follow the dev
>>> list and watch for things for them, as well as for things
>>> that relate
>>> to things they have worked on. They should also monitor the
>>> commits
>>> list to monitor all changes to areas of the project they
>>> are familiar
>>> with.
>>>
>>> Unfortunately Si seems to have chosen not to do this, and
>>> not to stay
>>> involved in this way with OFBiz. It's also unfortunate
>>> that he doesn't
>>> discuss his changes a whole lot, and issues do tend to come
>>> up with
>>> them that are often not resolved or not adequately
>>> resolved. In other
>>> words, he usually uses his commit privileges to get things
>>> into the
>>> project quickly for his convenience and isn't really
>>> participating in
>>> the community.
>>>
>>> While unfortunate, what to do about it is another question.
>>> Should the
>>> PMC really vote to remove his commit privileges? My guess
>>> is no, that
>>> wouldn't be a good action or conducive to community
>>> building.
>>>
>>> So instead we keep a close eye on his commits, knowing that
>>> dues to
>>> his infrequent community interactions and commits that he
>>> may have a
>>> harder time with things that he puts in. Along with this,
>>> as Scott
>>> mentioned, he does contribute valuable things here and
>>> there and that
>>> is great for the project. There are other people in this
>>> boat to, and
>>> really all committers should review the work of other
>>> committers for
>>> the sake of the project.
>>>
>>> Anyway, it's something on the back-burner and not
>>> something that there
>>> seems to be something to do about right away, and whether
>>> there is
>>> anything the PMC could do to improve the situation or not
>>> is still a
>>> big question.
>>>
>>> -David
>>
>>
>>
>
Re: svn commit: r686301 - in /ofbiz/trunk/framework/webapp: dtd/site-conf.xsd src/org/ofbiz/webapp/control/ConfigXMLReader.java src/org/ofbiz/webapp/control/RequestHandler.java
Posted by Adrian Crum <ad...@yahoo.com>.
In case you missed my joke, the "strongly worded letter" remark was referencing the UN's inability to deal effectively with rogue nations. ;-)
-Adrian
--- On Sat, 8/16/08, Jacopo Cappellato <ja...@gmail.com> wrote:
> From: Jacopo Cappellato <ja...@gmail.com>
> Subject: Re: svn commit: r686301 - in /ofbiz/trunk/framework/webapp: dtd/site-conf.xsd src/org/ofbiz/webapp/control/ConfigXMLReader.java src/org/ofbiz/webapp/control/RequestHandler.java
> To: dev@ofbiz.apache.org
> Date: Saturday, August 16, 2008, 8:04 AM
> I know this is an annoying situation, but since Si in the
> past few
> months has ignored our suggestion to discuss things in the
> mailing
> lists, instead of just writing uni-directional messages
> using Jira, I
> don't think we will have any luck in this. I am sure he
> understands
> this is far from an optimal setup (as I am sure that he
> would be able
> to create message filters for managing the volume of the ml
> traffic),
> and we can't (nor want) force him to do something he
> has decided to
> not concede us.
>
> Jacopo
>
> On Aug 16, 2008, at 4:26 PM, Adrian Crum wrote:
>
> > How about we issue a "strongly worded
> letter?" ;-)
> >
> > Seriously though, when I first subscribed to the
> lists, I balked at
> > the volume of incoming mail. I still needed to read it
> so I set up
> > filters to sort it. I'm sure Si could do the same.
> >
> > I agree he should retain his commit privileges, but I
> also believe
> > he needs to participate in the dev list (at least).
> >
> > -Adrian
> >
> >
> > --- On Fri, 8/15/08, David E Jones
> <jo...@hotwaxmedia.com> wrote:
> >
> >> From: David E Jones
> <jo...@hotwaxmedia.com>
> >> Subject: Re: svn commit: r686301 - in
> /ofbiz/trunk/framework/
> >> webapp: dtd/site-conf.xsd
> src/org/ofbiz/webapp/control/
> >> ConfigXMLReader.java
> src/org/ofbiz/webapp/control/RequestHandler.java
> >> To: dev@ofbiz.apache.org
> >> Date: Friday, August 15, 2008, 9:01 PM
> >> On Aug 15, 2008, at 2:20 PM, Adam Heath wrote:
> >>
> >>> Scott Gray wrote:
> >>>> Forwarding since Si doesn't subscribe
> to the
> >> dev list
> >>>
> >>> Er, he has commit access, but doesn't
> subscribe?
> >> Should this be
> >>> disallowed?
> >>
> >> There are definitely people that have a problem
> with this,
> >> and it is a
> >> weird situation. It is true that all committers
> should
> >> follow the dev
> >> list and watch for things for them, as well as for
> things
> >> that relate
> >> to things they have worked on. They should also
> monitor the
> >> commits
> >> list to monitor all changes to areas of the
> project they
> >> are familiar
> >> with.
> >>
> >> Unfortunately Si seems to have chosen not to do
> this, and
> >> not to stay
> >> involved in this way with OFBiz. It's also
> unfortunate
> >> that he doesn't
> >> discuss his changes a whole lot, and issues do
> tend to come
> >> up with
> >> them that are often not resolved or not adequately
> >> resolved. In other
> >> words, he usually uses his commit privileges to
> get things
> >> into the
> >> project quickly for his convenience and isn't
> really
> >> participating in
> >> the community.
> >>
> >> While unfortunate, what to do about it is another
> question.
> >> Should the
> >> PMC really vote to remove his commit privileges?
> My guess
> >> is no, that
> >> wouldn't be a good action or conducive to
> community
> >> building.
> >>
> >> So instead we keep a close eye on his commits,
> knowing that
> >> dues to
> >> his infrequent community interactions and commits
> that he
> >> may have a
> >> harder time with things that he puts in. Along
> with this,
> >> as Scott
> >> mentioned, he does contribute valuable things here
> and
> >> there and that
> >> is great for the project. There are other people
> in this
> >> boat to, and
> >> really all committers should review the work of
> other
> >> committers for
> >> the sake of the project.
> >>
> >> Anyway, it's something on the back-burner and
> not
> >> something that there
> >> seems to be something to do about right away, and
> whether
> >> there is
> >> anything the PMC could do to improve the situation
> or not
> >> is still a
> >> big question.
> >>
> >> -David
> >
> >
> >
Re: svn commit: r686301 - in /ofbiz/trunk/framework/webapp: dtd/site-conf.xsd src/org/ofbiz/webapp/control/ConfigXMLReader.java src/org/ofbiz/webapp/control/RequestHandler.java
Posted by Jacopo Cappellato <ja...@gmail.com>.
I know this is an annoying situation, but since Si in the past few
months has ignored our suggestion to discuss things in the mailing
lists, instead of just writing uni-directional messages using Jira, I
don't think we will have any luck in this. I am sure he understands
this is far from an optimal setup (as I am sure that he would be able
to create message filters for managing the volume of the ml traffic),
and we can't (nor want) force him to do something he has decided to
not concede us.
Jacopo
On Aug 16, 2008, at 4:26 PM, Adrian Crum wrote:
> How about we issue a "strongly worded letter?" ;-)
>
> Seriously though, when I first subscribed to the lists, I balked at
> the volume of incoming mail. I still needed to read it so I set up
> filters to sort it. I'm sure Si could do the same.
>
> I agree he should retain his commit privileges, but I also believe
> he needs to participate in the dev list (at least).
>
> -Adrian
>
>
> --- On Fri, 8/15/08, David E Jones <jo...@hotwaxmedia.com> wrote:
>
>> From: David E Jones <jo...@hotwaxmedia.com>
>> Subject: Re: svn commit: r686301 - in /ofbiz/trunk/framework/
>> webapp: dtd/site-conf.xsd src/org/ofbiz/webapp/control/
>> ConfigXMLReader.java src/org/ofbiz/webapp/control/RequestHandler.java
>> To: dev@ofbiz.apache.org
>> Date: Friday, August 15, 2008, 9:01 PM
>> On Aug 15, 2008, at 2:20 PM, Adam Heath wrote:
>>
>>> Scott Gray wrote:
>>>> Forwarding since Si doesn't subscribe to the
>> dev list
>>>
>>> Er, he has commit access, but doesn't subscribe?
>> Should this be
>>> disallowed?
>>
>> There are definitely people that have a problem with this,
>> and it is a
>> weird situation. It is true that all committers should
>> follow the dev
>> list and watch for things for them, as well as for things
>> that relate
>> to things they have worked on. They should also monitor the
>> commits
>> list to monitor all changes to areas of the project they
>> are familiar
>> with.
>>
>> Unfortunately Si seems to have chosen not to do this, and
>> not to stay
>> involved in this way with OFBiz. It's also unfortunate
>> that he doesn't
>> discuss his changes a whole lot, and issues do tend to come
>> up with
>> them that are often not resolved or not adequately
>> resolved. In other
>> words, he usually uses his commit privileges to get things
>> into the
>> project quickly for his convenience and isn't really
>> participating in
>> the community.
>>
>> While unfortunate, what to do about it is another question.
>> Should the
>> PMC really vote to remove his commit privileges? My guess
>> is no, that
>> wouldn't be a good action or conducive to community
>> building.
>>
>> So instead we keep a close eye on his commits, knowing that
>> dues to
>> his infrequent community interactions and commits that he
>> may have a
>> harder time with things that he puts in. Along with this,
>> as Scott
>> mentioned, he does contribute valuable things here and
>> there and that
>> is great for the project. There are other people in this
>> boat to, and
>> really all committers should review the work of other
>> committers for
>> the sake of the project.
>>
>> Anyway, it's something on the back-burner and not
>> something that there
>> seems to be something to do about right away, and whether
>> there is
>> anything the PMC could do to improve the situation or not
>> is still a
>> big question.
>>
>> -David
>
>
>
Re: svn commit: r686301 - in /ofbiz/trunk/framework/webapp: dtd/site-conf.xsd src/org/ofbiz/webapp/control/ConfigXMLReader.java src/org/ofbiz/webapp/control/RequestHandler.java
Posted by Adrian Crum <ad...@yahoo.com>.
How about we issue a "strongly worded letter?" ;-)
Seriously though, when I first subscribed to the lists, I balked at the volume of incoming mail. I still needed to read it so I set up filters to sort it. I'm sure Si could do the same.
I agree he should retain his commit privileges, but I also believe he needs to participate in the dev list (at least).
-Adrian
--- On Fri, 8/15/08, David E Jones <jo...@hotwaxmedia.com> wrote:
> From: David E Jones <jo...@hotwaxmedia.com>
> Subject: Re: svn commit: r686301 - in /ofbiz/trunk/framework/webapp: dtd/site-conf.xsd src/org/ofbiz/webapp/control/ConfigXMLReader.java src/org/ofbiz/webapp/control/RequestHandler.java
> To: dev@ofbiz.apache.org
> Date: Friday, August 15, 2008, 9:01 PM
> On Aug 15, 2008, at 2:20 PM, Adam Heath wrote:
>
> > Scott Gray wrote:
> >> Forwarding since Si doesn't subscribe to the
> dev list
> >
> > Er, he has commit access, but doesn't subscribe?
> Should this be
> > disallowed?
>
> There are definitely people that have a problem with this,
> and it is a
> weird situation. It is true that all committers should
> follow the dev
> list and watch for things for them, as well as for things
> that relate
> to things they have worked on. They should also monitor the
> commits
> list to monitor all changes to areas of the project they
> are familiar
> with.
>
> Unfortunately Si seems to have chosen not to do this, and
> not to stay
> involved in this way with OFBiz. It's also unfortunate
> that he doesn't
> discuss his changes a whole lot, and issues do tend to come
> up with
> them that are often not resolved or not adequately
> resolved. In other
> words, he usually uses his commit privileges to get things
> into the
> project quickly for his convenience and isn't really
> participating in
> the community.
>
> While unfortunate, what to do about it is another question.
> Should the
> PMC really vote to remove his commit privileges? My guess
> is no, that
> wouldn't be a good action or conducive to community
> building.
>
> So instead we keep a close eye on his commits, knowing that
> dues to
> his infrequent community interactions and commits that he
> may have a
> harder time with things that he puts in. Along with this,
> as Scott
> mentioned, he does contribute valuable things here and
> there and that
> is great for the project. There are other people in this
> boat to, and
> really all committers should review the work of other
> committers for
> the sake of the project.
>
> Anyway, it's something on the back-burner and not
> something that there
> seems to be something to do about right away, and whether
> there is
> anything the PMC could do to improve the situation or not
> is still a
> big question.
>
> -David
Re: svn commit: r686301 - in /ofbiz/trunk/framework/webapp: dtd/site-conf.xsd src/org/ofbiz/webapp/control/ConfigXMLReader.java src/org/ofbiz/webapp/control/RequestHandler.java
Posted by David E Jones <jo...@hotwaxmedia.com>.
On Aug 15, 2008, at 2:20 PM, Adam Heath wrote:
> Scott Gray wrote:
>> Forwarding since Si doesn't subscribe to the dev list
>
> Er, he has commit access, but doesn't subscribe? Should this be
> disallowed?
There are definitely people that have a problem with this, and it is a
weird situation. It is true that all committers should follow the dev
list and watch for things for them, as well as for things that relate
to things they have worked on. They should also monitor the commits
list to monitor all changes to areas of the project they are familiar
with.
Unfortunately Si seems to have chosen not to do this, and not to stay
involved in this way with OFBiz. It's also unfortunate that he doesn't
discuss his changes a whole lot, and issues do tend to come up with
them that are often not resolved or not adequately resolved. In other
words, he usually uses his commit privileges to get things into the
project quickly for his convenience and isn't really participating in
the community.
While unfortunate, what to do about it is another question. Should the
PMC really vote to remove his commit privileges? My guess is no, that
wouldn't be a good action or conducive to community building.
So instead we keep a close eye on his commits, knowing that dues to
his infrequent community interactions and commits that he may have a
harder time with things that he puts in. Along with this, as Scott
mentioned, he does contribute valuable things here and there and that
is great for the project. There are other people in this boat to, and
really all committers should review the work of other committers for
the sake of the project.
Anyway, it's something on the back-burner and not something that there
seems to be something to do about right away, and whether there is
anything the PMC could do to improve the situation or not is still a
big question.
-David
Re: Fwd: svn commit: r686301 - in /ofbiz/trunk/framework/webapp:
dtd/site-conf.xsd src/org/ofbiz/webapp/control/ConfigXMLReader.java src/org/ofbiz/webapp/control/RequestHandler.java
Posted by Adam Heath <do...@brainfood.com>.
Scott Gray wrote:
> Forwarding since Si doesn't subscribe to the dev list
Er, he has commit access, but doesn't subscribe? Should this be disallowed?
Fwd: svn commit: r686301 - in /ofbiz/trunk/framework/webapp: dtd/site-conf.xsd src/org/ofbiz/webapp/control/ConfigXMLReader.java src/org/ofbiz/webapp/control/RequestHandler.java
Posted by Scott Gray <le...@gmail.com>.
Forwarding since Si doesn't subscribe to the dev list
---------- Forwarded message ----------
From: Bilgin Ibryam <bi...@iguanait.com>
Date: 2008/8/16
Subject: Re: svn commit: r686301 - in /ofbiz/trunk/framework/webapp:
dtd/site-conf.xsd src/org/ofbiz/webapp/control/ConfigXMLReader.java
src/org/ofbiz/webapp/control/RequestHandler.java
To: dev@ofbiz.apache.org
Hi Si,
there are errors in RequestHandler after this commit.
Can you fix/revert it, please?
Bilgin
----------------------------------------------------------------
This message was sent using IMP, the Internet Messaging Program.
Re: svn commit: r686301 - in /ofbiz/trunk/framework/webapp:
dtd/site-conf.xsd src/org/ofbiz/webapp/control/ConfigXMLReader.java
src/org/ofbiz/webapp/control/RequestHandler.java
Posted by Bilgin Ibryam <bi...@iguanait.com>.
Hi Si,
there are errors in RequestHandler after this commit.
Can you fix/revert it, please?
Bilgin
----------------------------------------------------------------
This message was sent using IMP, the Internet Messaging Program.