You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by dongjoon-hyun <gi...@git.apache.org> on 2018/10/18 06:38:44 UTC

[GitHub] spark pull request #22677: [SPARK-25683][Core] Updated the log for the first...

Github user dongjoon-hyun commented on a diff in the pull request:

    https://github.com/apache/spark/pull/22677#discussion_r226183134
  
    --- Diff: core/src/main/scala/org/apache/spark/scheduler/AsyncEventQueue.scala ---
    @@ -169,7 +169,8 @@ private class AsyncEventQueue(
               val prevLastReportTimestamp = lastReportTimestamp
               lastReportTimestamp = System.currentTimeMillis()
               val previous = new java.util.Date(prevLastReportTimestamp)
    -          logWarning(s"Dropped $droppedCount events from $name since $previous.")
    +          logWarning(s"Dropped $droppedCount events from $name since " +
    +            s"${if (prevLastReportTimestamp == 0) "start of the application" else s"$previous"}.")
    --- End diff --
    
    nit. "start of the application" -> "the application starts", @shivusondur ?


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org