You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@seatunnel.apache.org by GitBox <gi...@apache.org> on 2022/02/08 14:14:19 UTC
[GitHub] [incubator-seatunnel] bigdataf opened a new pull request #1211: [fix] In order to fix the execution problem after the flink version is upgraded to 1.13.5
bigdataf opened a new pull request #1211:
URL: https://github.com/apache/incubator-seatunnel/pull/1211
<!--
Thank you for contributing to SeaTunnel! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
## Contribution Checklist
- Make sure that the pull request corresponds to a [GITHUB issue](https://github.com/apache/incubator-seatunnel/issues).
- Name the pull request in the form "[Feature] [component] Title of the pull request", where *Feature* can be replaced by `Hotfix`, `Bug`, etc.
- Minor fixes should be named following this pattern: `[hotfix] [docs] Fix typo in README.md doc`.
-->
## Purpose of this pull request
<!-- Describe the purpose of this pull request. For example: This pull request adds checkstyle plugin.-->
## Check list
* [ ] Code changed are covered with tests, or it does not need tests for reason:
* [ ] If any new Jar binary package adding in you PR, please add License Notice according
[New License Guide](https://github.com/apache/incubator-seatunnel/blob/dev/docs/en/developement/NewLicenseGuide.md)
* [ ] If necessary, please update the documentation to describe the new feature. https://github.com/apache/incubator-seatunnel/tree/dev/docs
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] bigdataf commented on a change in pull request #1211: [Bug] [example] In order to fix run error in execute local flink batch example
Posted by GitBox <gi...@apache.org>.
bigdataf commented on a change in pull request #1211:
URL: https://github.com/apache/incubator-seatunnel/pull/1211#discussion_r802376943
##########
File path: seatunnel-apis/seatunnel-api-flink/pom.xml
##########
@@ -53,6 +53,11 @@
<groupId>org.apache.flink</groupId>
<artifactId>flink-streaming-java_${scala.binary.version}</artifactId>
</dependency>
+ <dependency>
+ <groupId>org.apache.flink</groupId>
+ <artifactId>flink-optimizer_${scala.binary.version}</artifactId>
Review comment:
[FlinkBatchExecution.java ](https://github.com/apache/incubator-seatunnel/blob/7b237befc5f723a35656fbee4aa4306300554ef0/seatunnel-apis/seatunnel-api-flink/src/main/java/org/apache/seatunnel/flink/batch/FlinkBatchExecution.java#81)
This is not necessarily required, it can also be removed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] bigdataf commented on a change in pull request #1211: [Bug] [example] In order to fix run error in execute local flink batch example
Posted by GitBox <gi...@apache.org>.
bigdataf commented on a change in pull request #1211:
URL: https://github.com/apache/incubator-seatunnel/pull/1211#discussion_r802376943
##########
File path: seatunnel-apis/seatunnel-api-flink/pom.xml
##########
@@ -53,6 +53,11 @@
<groupId>org.apache.flink</groupId>
<artifactId>flink-streaming-java_${scala.binary.version}</artifactId>
</dependency>
+ <dependency>
+ <groupId>org.apache.flink</groupId>
+ <artifactId>flink-optimizer_${scala.binary.version}</artifactId>
Review comment:
[FlinkBatchExecution.java ](https://github.com/apache/incubator-seatunnel/blob/7b237befc5f723a35656fbee4aa4306300554ef0/seatunnel-apis/seatunnel-api-flink/src/main/java/org/apache/seatunnel/flink/batch/FlinkBatchExecution.java#L81)
This is not necessarily required, it can also be removed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] leo65535 commented on pull request #1211: [fix] In order to fix run error in execute local flink batch example
Posted by GitBox <gi...@apache.org>.
leo65535 commented on pull request #1211:
URL: https://github.com/apache/incubator-seatunnel/pull/1211#issuecomment-1033396722
> @[leo65535](https://github.com/leo65535) Please review, should I set a bug?or [feature][flink]
maybe `bug` is better.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] bigdataf commented on pull request #1211: [Bug] [example] In order to fix run error in execute local flink batch example
Posted by GitBox <gi...@apache.org>.
bigdataf commented on pull request #1211:
URL: https://github.com/apache/incubator-seatunnel/pull/1211#issuecomment-1041143268
Are there any other questions, please review, thank you
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] bigdataf commented on pull request #1211: [Bug] [example] In order to fix run error in execute local flink batch example
Posted by GitBox <gi...@apache.org>.
bigdataf commented on pull request #1211:
URL: https://github.com/apache/incubator-seatunnel/pull/1211#issuecomment-1041153192
An error will be reported. The main reason is that it is used in the logger output. If we remove this log output, the batch is normal.
https://user-images.githubusercontent.com/33916394/153214099-5aa7f880-94f4-4d9d-8c4a-c82a75cb8063.png
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] bigdataf commented on pull request #1211: [fix] In order to fix the execution problem after the flink version is upgraded to 1.13.5
Posted by GitBox <gi...@apache.org>.
bigdataf commented on pull request #1211:
URL: https://github.com/apache/incubator-seatunnel/pull/1211#issuecomment-1032656627
Error when I run local batch
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] bigdataf commented on pull request #1211: [fix] In order to fix run error in execute local flink batch example
Posted by GitBox <gi...@apache.org>.
bigdataf commented on pull request #1211:
URL: https://github.com/apache/incubator-seatunnel/pull/1211#issuecomment-1033394066
@[leo65535](https://github.com/leo65535) Please review, should I set a bug?or [feature][flink]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] bigdataf commented on pull request #1211: [Bug] In order to fix run error in execute local flink batch example
Posted by GitBox <gi...@apache.org>.
bigdataf commented on pull request #1211:
URL: https://github.com/apache/incubator-seatunnel/pull/1211#issuecomment-1033397831
@[leo65535](https://github.com/leo65535) Thank you for your suggestion, it has been revised, please review if there are any other questions, thank you
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] leo65535 commented on a change in pull request #1211: [Bug] [example] In order to fix run error in execute local flink batch example
Posted by GitBox <gi...@apache.org>.
leo65535 commented on a change in pull request #1211:
URL: https://github.com/apache/incubator-seatunnel/pull/1211#discussion_r802365822
##########
File path: seatunnel-apis/seatunnel-api-flink/pom.xml
##########
@@ -53,6 +53,11 @@
<groupId>org.apache.flink</groupId>
<artifactId>flink-streaming-java_${scala.binary.version}</artifactId>
</dependency>
+ <dependency>
+ <groupId>org.apache.flink</groupId>
+ <artifactId>flink-optimizer_${scala.binary.version}</artifactId>
Review comment:
hi @bigdataf why we need this dependency?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] bigdataf commented on pull request #1211: [Bug] [example] In order to fix run error in execute local flink batch example
Posted by GitBox <gi...@apache.org>.
bigdataf commented on pull request #1211:
URL: https://github.com/apache/incubator-seatunnel/pull/1211#issuecomment-1033771320
In addition to this local example running problem, I think that upgrading to flink 1.13.5 requires some other tests. According to my previous upgrade experience, the change of version api is designed to some underlying reference problems, not only compilation can pass The problem
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] leo65535 merged pull request #1211: [Bug] [example] In order to fix run error in execute local flink batch example
Posted by GitBox <gi...@apache.org>.
leo65535 merged pull request #1211:
URL: https://github.com/apache/incubator-seatunnel/pull/1211
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] bigdataf commented on a change in pull request #1211: [Bug] [example] In order to fix run error in execute local flink batch example
Posted by GitBox <gi...@apache.org>.
bigdataf commented on a change in pull request #1211:
URL: https://github.com/apache/incubator-seatunnel/pull/1211#discussion_r802376943
##########
File path: seatunnel-apis/seatunnel-api-flink/pom.xml
##########
@@ -53,6 +53,11 @@
<groupId>org.apache.flink</groupId>
<artifactId>flink-streaming-java_${scala.binary.version}</artifactId>
</dependency>
+ <dependency>
+ <groupId>org.apache.flink</groupId>
+ <artifactId>flink-optimizer_${scala.binary.version}</artifactId>
Review comment:
[FlinkBatchExecution.java ](https://github.com/apache/incubator-seatunnel/blob/7b237befc5f723a35656fbee4aa4306300554ef0/seatunnel-apis/seatunnel-api-flink/src/main/java/org/apache/seatunnel/flink/batch/FlinkBatchExecution.java#L52)
This is not necessarily required, it can also be removed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] leo65535 edited a comment on pull request #1211: [Bug] [example] In order to fix run error in execute local flink batch example
Posted by GitBox <gi...@apache.org>.
leo65535 edited a comment on pull request #1211:
URL: https://github.com/apache/incubator-seatunnel/pull/1211#issuecomment-1041146769
The action is cancelled for timeout reason, you need to trigger the ci again.
And I have a question that if we remove `flink-optimizer` dependency, will the flink batch example run successfully?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] leo65535 commented on pull request #1211: [Bug] [example] In order to fix run error in execute local flink batch example
Posted by GitBox <gi...@apache.org>.
leo65535 commented on pull request #1211:
URL: https://github.com/apache/incubator-seatunnel/pull/1211#issuecomment-1041146769
The action is cancelled for timeout reason, you need to trigger the ci again.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] bigdataf removed a comment on pull request #1211: [Bug] [example] In order to fix run error in execute local flink batch example
Posted by GitBox <gi...@apache.org>.
bigdataf removed a comment on pull request #1211:
URL: https://github.com/apache/incubator-seatunnel/pull/1211#issuecomment-1033771320
In addition to this local example running problem, I think that upgrading to flink 1.13.5 requires some other tests. According to my previous upgrade experience, the change of version api is designed to some underlying reference problems, not only compilation can pass The problem
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] leo65535 commented on a change in pull request #1211: [Bug] [example] In order to fix run error in execute local flink batch example
Posted by GitBox <gi...@apache.org>.
leo65535 commented on a change in pull request #1211:
URL: https://github.com/apache/incubator-seatunnel/pull/1211#discussion_r802364929
##########
File path: pom.xml
##########
@@ -651,7 +663,8 @@
<failOnWarning>false</failOnWarning>
<sourceDirectory>${basedir}/src/main/scala</sourceDirectory>
<testSourceDirectory>${basedir}/src/test/scala</testSourceDirectory>
- <configLocation>${maven.multiModuleProjectDirectory}/tools/checkstyle/scalastyle-config.xml</configLocation>
+ <configLocation>${maven.multiModuleProjectDirectory}/tools/checkstyle/scalastyle-config.xml
Review comment:
please recover this change.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] leo65535 commented on pull request #1211: [fix] In order to fix the execution problem after the flink version is upgraded to 1.13.5
Posted by GitBox <gi...@apache.org>.
leo65535 commented on pull request #1211:
URL: https://github.com/apache/incubator-seatunnel/pull/1211#issuecomment-1033371235
hi @bigdataf, please modify the name of the patch, thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] leo65535 commented on a change in pull request #1211: [Bug] [example] In order to fix run error in execute local flink batch example
Posted by GitBox <gi...@apache.org>.
leo65535 commented on a change in pull request #1211:
URL: https://github.com/apache/incubator-seatunnel/pull/1211#discussion_r802396592
##########
File path: seatunnel-apis/seatunnel-api-flink/pom.xml
##########
@@ -53,6 +53,11 @@
<groupId>org.apache.flink</groupId>
<artifactId>flink-streaming-java_${scala.binary.version}</artifactId>
</dependency>
+ <dependency>
+ <groupId>org.apache.flink</groupId>
+ <artifactId>flink-optimizer_${scala.binary.version}</artifactId>
Review comment:
if we remove `flink-optimizer` dependency, will the flink batch example run successfully?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org