You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@subversion.apache.org by Paul Burba <pt...@gmail.com> on 2010/06/09 15:40:49 UTC
Re: svn commit: r952981 - /subversion/branches/1.6.x-issue3651/subversion/svn/copy-cmd.c
On Wed, Jun 9, 2010 at 8:48 AM, <st...@apache.org> wrote:
> Author: stylesen
> Date: Wed Jun 9 12:48:05 2010
> New Revision: 952981
>
> URL: http://svn.apache.org/viewvc?rev=952981&view=rev
> Log:
> On the '1.6.x-issue3651' branch:
>
> Merge from trunk r952973 and use the private API to eat peg revision,
> since this API was made public in trunk recently.
>
> Modified:
> subversion/branches/1.6.x-issue3651/subversion/svn/copy-cmd.c
>
> Modified: subversion/branches/1.6.x-issue3651/subversion/svn/copy-cmd.c
> URL: http://svn.apache.org/viewvc/subversion/branches/1.6.x-issue3651/subversion/svn/copy-cmd.c?rev=952981&r1=952980&r2=952981&view=diff
> ==============================================================================
Hi Senthil,
We want to add #include "private/svn_opt_private.h" to avoid compiler
warnings about an undefined function yes?
Paul
> --- subversion/branches/1.6.x-issue3651/subversion/svn/copy-cmd.c (original)
> +++ subversion/branches/1.6.x-issue3651/subversion/svn/copy-cmd.c Wed Jun 9 12:48:05 2010
> @@ -72,6 +72,8 @@ svn_cl__copy(apr_getopt_t *os,
> APR_ARRAY_PUSH(sources, svn_client_copy_source_t *) = source;
> }
>
> + SVN_ERR(svn_opt__eat_peg_revisions(&targets, targets, pool));
> +
> /* Figure out which type of trace editor to use.
> If the src_paths are not homogeneous, setup_copy will return an error. */
> src_path = APR_ARRAY_IDX(targets, 0, const char *);
>
>
>
Re: svn commit: r952981 - /subversion/branches/1.6.x-issue3651/subversion/svn/copy-cmd.c
Posted by Senthil Kumaran S <se...@collab.net>.
Senthil Kumaran S wrote:
> Senthil Kumaran S wrote:
>>> We want to add #include "private/svn_opt_private.h" to avoid compiler
>>> warnings about an undefined function yes?
>> I thought '#include "svn_private_config.h' will include the required private
>> header files. If that is the case then we need not explicitly include it? Also,
>> my compiler did not warn me about the function. I use "gcc (Debian 4.3.2-1.1)
>> 4.3.2".
>
> But, when I include the header file explicitly the following warning
> disappears, so I shall commit the necessary changes to the backport branch.
Done in r953296.
> Will also make your vote as +1
Done in r953301.
--
Senthil Kumaran S
http://www.stylesen.org/
Re: svn commit: r952981 - /subversion/branches/1.6.x-issue3651/subversion/svn/copy-cmd.c
Posted by Senthil Kumaran S <se...@collab.net>.
Senthil Kumaran S wrote:
>> We want to add #include "private/svn_opt_private.h" to avoid compiler
>> warnings about an undefined function yes?
>
> I thought '#include "svn_private_config.h' will include the required private
> header files. If that is the case then we need not explicitly include it? Also,
> my compiler did not warn me about the function. I use "gcc (Debian 4.3.2-1.1)
> 4.3.2".
But, when I include the header file explicitly the following warning
disappears, so I shall commit the necessary changes to the backport branch.
<snip>
../subversion/svn/copy-cmd.c: In function ‘svn_cl__copy’:
../subversion/svn/copy-cmd.c:75: warning: initialization makes pointer from
integer without a cast
</snip>
Will also make your vote as +1
Thank You.
--
Senthil Kumaran S
http://www.stylesen.org/
Re: svn commit: r952981 - /subversion/branches/1.6.x-issue3651/subversion/svn/copy-cmd.c
Posted by Senthil Kumaran S <se...@collab.net>.
Hi Paul,
Paul Burba wrote:
> On Wed, Jun 9, 2010 at 8:48 AM, <st...@apache.org> wrote:
>
>> Author: stylesen
>> Date: Wed Jun 9 12:48:05 2010
>> New Revision: 952981
>>
>> URL: http://svn.apache.org/viewvc?rev=952981&view=rev
>> Log:
>> On the '1.6.x-issue3651' branch:
>>
>> Merge from trunk r952973 and use the private API to eat peg revision,
>> since this API was made public in trunk recently.
>>
>> Modified:
>> subversion/branches/1.6.x-issue3651/subversion/svn/copy-cmd.c
>>
>> Modified: subversion/branches/1.6.x-issue3651/subversion/svn/copy-cmd.c
>> URL: http://svn.apache.org/viewvc/subversion/branches/1.6.x-issue3651/subversion/svn/copy-cmd.c?rev=952981&r1=952980&r2=952981&view=diff
>> ==============================================================================
>
> Hi Senthil,
>
> We want to add #include "private/svn_opt_private.h" to avoid compiler
> warnings about an undefined function yes?
I thought '#include "svn_private_config.h' will include the required private
header files. If that is the case then we need not explicitly include it? Also,
my compiler did not warn me about the function. I use "gcc (Debian 4.3.2-1.1)
4.3.2".
Thank You.
--
Senthil Kumaran S
http://www.stylesen.org/