You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2021/02/19 02:57:16 UTC
[GitHub] [apisix-website] Yiyiyimu opened a new pull request #193: docs: add 'gpg --import KEYS' to release guide
Yiyiyimu opened a new pull request #193:
URL: https://github.com/apache/apisix-website/pull/193
Signed-off-by: yiyiyimu <wo...@gmail.com>
Changes:
Currently in release guide, users are told to download gpg KEYS file but not use it.
Since the original template is an immutable email, the template was copied from the email to the board so we could easily fix it.
Screenshots of the change:
<!-- Add screenshots depicting the changes. -->
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-website] Yiyiyimu commented on a change in pull request #193: docs: add 'gpg --import KEYS' to release guide
Posted by GitBox <gi...@apache.org>.
Yiyiyimu commented on a change in pull request #193:
URL: https://github.com/apache/apisix-website/pull/193#discussion_r578961953
##########
File path: website/docs/release-guide.md
##########
@@ -248,7 +248,80 @@ Committed revision 37435.
### Send VOTE thread to the dev mailing list
-Click [here](https://lists.apache.org/thread.html/rf534952a6b2d23ed6efdd61f15b40fa9e4de230164a1ccf168176734%40%3Cdev.apisix.apache.org%3E) to view the reference email. There is a minimum wait of 72 hours before statistical voting results. If you get -1 vote, you need to solve the problem before you can continue.
+There is a minimum wait of 72 hours before statistical voting results. If you get -1 vote, you need to solve the problem before you can continue. The reference email is as shown below.
+
+```
+Hello, Community,
+This is a call for the vote to release Apache APISIX version 2.0.
+
+Release notes:
+
+https://github.com/apache/apisix/blob/2.0/CHANGELOG.md#200
+
+The release candidates:
+
+https://dist.apache.org/repos/dist/dev/apisix/2.0/
Review comment:
It's actually the original text copied from email template (See [email](https://lists.apache.org/thread.html/rf534952a6b2d23ed6efdd61f15b40fa9e4de230164a1ccf168176734%40%3Cdev.apisix.apache.org%3E)), and I'm not sure why there are two candidates
---
Checked some more recent vote emails, it seems only one candidate is enough.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-website] juzhiyuan merged pull request #193: docs: add 'gpg --import KEYS' to release guide
Posted by GitBox <gi...@apache.org>.
juzhiyuan merged pull request #193:
URL: https://github.com/apache/apisix-website/pull/193
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-website] juzhiyuan commented on a change in pull request #193: docs: add 'gpg --import KEYS' to release guide
Posted by GitBox <gi...@apache.org>.
juzhiyuan commented on a change in pull request #193:
URL: https://github.com/apache/apisix-website/pull/193#discussion_r578970850
##########
File path: website/docs/release-guide.md
##########
@@ -248,7 +248,80 @@ Committed revision 37435.
### Send VOTE thread to the dev mailing list
-Click [here](https://lists.apache.org/thread.html/rf534952a6b2d23ed6efdd61f15b40fa9e4de230164a1ccf168176734%40%3Cdev.apisix.apache.org%3E) to view the reference email. There is a minimum wait of 72 hours before statistical voting results. If you get -1 vote, you need to solve the problem before you can continue.
+There is a minimum wait of 72 hours before statistical voting results. If you get -1 vote, you need to solve the problem before you can continue. The reference email is as shown below.
+
+```
+Hello, Community,
+This is a call for the vote to release Apache APISIX version 2.0.
+
+Release notes:
+
+https://github.com/apache/apisix/blob/2.0/CHANGELOG.md#200
+
+The release candidates:
+
+https://dist.apache.org/repos/dist/dev/apisix/2.0/
Review comment:
Yep
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-website] Yiyiyimu commented on a change in pull request #193: docs: add 'gpg --import KEYS' to release guide
Posted by GitBox <gi...@apache.org>.
Yiyiyimu commented on a change in pull request #193:
URL: https://github.com/apache/apisix-website/pull/193#discussion_r578967227
##########
File path: website/docs/release-guide.md
##########
@@ -248,7 +248,80 @@ Committed revision 37435.
### Send VOTE thread to the dev mailing list
-Click [here](https://lists.apache.org/thread.html/rf534952a6b2d23ed6efdd61f15b40fa9e4de230164a1ccf168176734%40%3Cdev.apisix.apache.org%3E) to view the reference email. There is a minimum wait of 72 hours before statistical voting results. If you get -1 vote, you need to solve the problem before you can continue.
+There is a minimum wait of 72 hours before statistical voting results. If you get -1 vote, you need to solve the problem before you can continue. The reference email is as shown below.
+
+```
+Hello, Community,
+This is a call for the vote to release Apache APISIX version 2.0.
+
+Release notes:
+
+https://github.com/apache/apisix/blob/2.0/CHANGELOG.md#200
+
+The release candidates:
+
+https://dist.apache.org/repos/dist/dev/apisix/2.0/
+<https://dist.apache.org/repos/dist/dev/apisix/1.5-rc1/>
+
+Git tag for the release:
+
+https://github.com/apache/apisix/tree/2.0
+<https://github.com/apache/apisix/tree/v1.5>
+
+Release Commit ID:
+
+https://github.com/apache/apisix/commit/79be83dd8adfbd5a1d98e0685c5db67166adac3f
+
+Keys to verify the Release Candidate:
+
+https://dist.apache.org/repos/dist/release/apisix/KEYS
+<https://dist.apache.org/repos/dist/dev/apisix/KEYS>
+
+Steps to validating the release:
+
+1. Download the release
+
+wget
+https://dist.apache.org/repos/dist/dev/apisix/2.0/apache-apisix-2.0-src.tgz
+
+
+2. Checksums and signatures
+
+wget https://dist.apache.org/repos/dist/release/apisix/KEYS
+
+wget
+https://dist.apache.org/repos/dist/dev/apisix/2.0/apache-apisix-2.0-src.tgz.asc
+
+wget
+https://dist.apache.org/repos/dist/dev/apisix/2.0/apache-apisix-2.0-src.tgz.sha512
+
+gpg --import KEYS
+
+shasum -c apache-apisix-2.0-src.tgz.sha512
+
+gpg --verify apache-apisix-2.0-src.tgz.asc apache-apisix-2.0-src.tgz
+
+3. Unzip and Check files
+
+tar zxvf apache-apisix-2.0-src.tgz
+
+4. Build Apache APISIX:
+
+https://github.com/apache/apisix/blob/2.0/doc/how-to-build.md#installation-via-source-release
+
+The vote will be open for at least 72 hours or until necessary number of
+votes are reached.
+
+Please vote accordingly:
+
+[ ] +1 approve
+[ ] +0 no opinion
+[ ] -1 disapprove with the reason
+
+Thanks,
+Ming Wen, Apache APISIX & Apache SkyWalking
+Twitter: _WenMing
Review comment:
Removed. Thanks!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-website] Yiyiyimu commented on a change in pull request #193: docs: add 'gpg --import KEYS' to release guide
Posted by GitBox <gi...@apache.org>.
Yiyiyimu commented on a change in pull request #193:
URL: https://github.com/apache/apisix-website/pull/193#discussion_r578961953
##########
File path: website/docs/release-guide.md
##########
@@ -248,7 +248,80 @@ Committed revision 37435.
### Send VOTE thread to the dev mailing list
-Click [here](https://lists.apache.org/thread.html/rf534952a6b2d23ed6efdd61f15b40fa9e4de230164a1ccf168176734%40%3Cdev.apisix.apache.org%3E) to view the reference email. There is a minimum wait of 72 hours before statistical voting results. If you get -1 vote, you need to solve the problem before you can continue.
+There is a minimum wait of 72 hours before statistical voting results. If you get -1 vote, you need to solve the problem before you can continue. The reference email is as shown below.
+
+```
+Hello, Community,
+This is a call for the vote to release Apache APISIX version 2.0.
+
+Release notes:
+
+https://github.com/apache/apisix/blob/2.0/CHANGELOG.md#200
+
+The release candidates:
+
+https://dist.apache.org/repos/dist/dev/apisix/2.0/
Review comment:
It's actually the original text copied from email template (See [email](https://lists.apache.org/thread.html/rf534952a6b2d23ed6efdd61f15b40fa9e4de230164a1ccf168176734%40%3Cdev.apisix.apache.org%3E)), and I'm not sure why there are two candidates
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-website] Yiyiyimu commented on a change in pull request #193: docs: add 'gpg --import KEYS' to release guide
Posted by GitBox <gi...@apache.org>.
Yiyiyimu commented on a change in pull request #193:
URL: https://github.com/apache/apisix-website/pull/193#discussion_r578967155
##########
File path: website/docs/release-guide.md
##########
@@ -248,7 +248,80 @@ Committed revision 37435.
### Send VOTE thread to the dev mailing list
-Click [here](https://lists.apache.org/thread.html/rf534952a6b2d23ed6efdd61f15b40fa9e4de230164a1ccf168176734%40%3Cdev.apisix.apache.org%3E) to view the reference email. There is a minimum wait of 72 hours before statistical voting results. If you get -1 vote, you need to solve the problem before you can continue.
+There is a minimum wait of 72 hours before statistical voting results. If you get -1 vote, you need to solve the problem before you can continue. The reference email is as shown below.
+
+```
+Hello, Community,
+This is a call for the vote to release Apache APISIX version 2.0.
+
+Release notes:
+
+https://github.com/apache/apisix/blob/2.0/CHANGELOG.md#200
+
+The release candidates:
+
+https://dist.apache.org/repos/dist/dev/apisix/2.0/
+<https://dist.apache.org/repos/dist/dev/apisix/1.5-rc1/>
+
+Git tag for the release:
+
+https://github.com/apache/apisix/tree/2.0
+<https://github.com/apache/apisix/tree/v1.5>
+
+Release Commit ID:
+
+https://github.com/apache/apisix/commit/79be83dd8adfbd5a1d98e0685c5db67166adac3f
+
+Keys to verify the Release Candidate:
+
+https://dist.apache.org/repos/dist/release/apisix/KEYS
+<https://dist.apache.org/repos/dist/dev/apisix/KEYS>
+
+Steps to validating the release:
+
+1. Download the release
+
+wget
+https://dist.apache.org/repos/dist/dev/apisix/2.0/apache-apisix-2.0-src.tgz
+
+
+2. Checksums and signatures
+
+wget https://dist.apache.org/repos/dist/release/apisix/KEYS
Review comment:
It seems APISIX 2.3 use release KEYS, while dashboard 2.4 and ingress controller 0.3.0 use dev KEYS 🤣
Changed to dev.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-website] juzhiyuan commented on a change in pull request #193: docs: add 'gpg --import KEYS' to release guide
Posted by GitBox <gi...@apache.org>.
juzhiyuan commented on a change in pull request #193:
URL: https://github.com/apache/apisix-website/pull/193#discussion_r578940796
##########
File path: website/docs/release-guide.md
##########
@@ -248,7 +248,80 @@ Committed revision 37435.
### Send VOTE thread to the dev mailing list
-Click [here](https://lists.apache.org/thread.html/rf534952a6b2d23ed6efdd61f15b40fa9e4de230164a1ccf168176734%40%3Cdev.apisix.apache.org%3E) to view the reference email. There is a minimum wait of 72 hours before statistical voting results. If you get -1 vote, you need to solve the problem before you can continue.
+There is a minimum wait of 72 hours before statistical voting results. If you get -1 vote, you need to solve the problem before you can continue. The reference email is as shown below.
+
+```
+Hello, Community,
+This is a call for the vote to release Apache APISIX version 2.0.
+
+Release notes:
+
+https://github.com/apache/apisix/blob/2.0/CHANGELOG.md#200
+
+The release candidates:
+
+https://dist.apache.org/repos/dist/dev/apisix/2.0/
+<https://dist.apache.org/repos/dist/dev/apisix/1.5-rc1/>
+
+Git tag for the release:
+
+https://github.com/apache/apisix/tree/2.0
Review comment:
ditto
##########
File path: website/docs/release-guide.md
##########
@@ -248,7 +248,80 @@ Committed revision 37435.
### Send VOTE thread to the dev mailing list
-Click [here](https://lists.apache.org/thread.html/rf534952a6b2d23ed6efdd61f15b40fa9e4de230164a1ccf168176734%40%3Cdev.apisix.apache.org%3E) to view the reference email. There is a minimum wait of 72 hours before statistical voting results. If you get -1 vote, you need to solve the problem before you can continue.
+There is a minimum wait of 72 hours before statistical voting results. If you get -1 vote, you need to solve the problem before you can continue. The reference email is as shown below.
+
+```
+Hello, Community,
+This is a call for the vote to release Apache APISIX version 2.0.
+
+Release notes:
+
+https://github.com/apache/apisix/blob/2.0/CHANGELOG.md#200
+
+The release candidates:
+
+https://dist.apache.org/repos/dist/dev/apisix/2.0/
+<https://dist.apache.org/repos/dist/dev/apisix/1.5-rc1/>
+
+Git tag for the release:
+
+https://github.com/apache/apisix/tree/2.0
+<https://github.com/apache/apisix/tree/v1.5>
+
+Release Commit ID:
+
+https://github.com/apache/apisix/commit/79be83dd8adfbd5a1d98e0685c5db67166adac3f
+
+Keys to verify the Release Candidate:
+
+https://dist.apache.org/repos/dist/release/apisix/KEYS
+<https://dist.apache.org/repos/dist/dev/apisix/KEYS>
+
+Steps to validating the release:
+
+1. Download the release
+
+wget
+https://dist.apache.org/repos/dist/dev/apisix/2.0/apache-apisix-2.0-src.tgz
+
+
+2. Checksums and signatures
+
+wget https://dist.apache.org/repos/dist/release/apisix/KEYS
Review comment:
🤔 In the Voting process, we will use the KEYS from `/dev` as far as I know.
##########
File path: website/docs/release-guide.md
##########
@@ -248,7 +248,80 @@ Committed revision 37435.
### Send VOTE thread to the dev mailing list
-Click [here](https://lists.apache.org/thread.html/rf534952a6b2d23ed6efdd61f15b40fa9e4de230164a1ccf168176734%40%3Cdev.apisix.apache.org%3E) to view the reference email. There is a minimum wait of 72 hours before statistical voting results. If you get -1 vote, you need to solve the problem before you can continue.
+There is a minimum wait of 72 hours before statistical voting results. If you get -1 vote, you need to solve the problem before you can continue. The reference email is as shown below.
+
+```
+Hello, Community,
+This is a call for the vote to release Apache APISIX version 2.0.
+
+Release notes:
+
+https://github.com/apache/apisix/blob/2.0/CHANGELOG.md#200
+
+The release candidates:
+
+https://dist.apache.org/repos/dist/dev/apisix/2.0/
Review comment:
Hi, I see L263 is different from L264, please recheck.
##########
File path: website/docs/release-guide.md
##########
@@ -248,7 +248,80 @@ Committed revision 37435.
### Send VOTE thread to the dev mailing list
-Click [here](https://lists.apache.org/thread.html/rf534952a6b2d23ed6efdd61f15b40fa9e4de230164a1ccf168176734%40%3Cdev.apisix.apache.org%3E) to view the reference email. There is a minimum wait of 72 hours before statistical voting results. If you get -1 vote, you need to solve the problem before you can continue.
+There is a minimum wait of 72 hours before statistical voting results. If you get -1 vote, you need to solve the problem before you can continue. The reference email is as shown below.
+
+```
+Hello, Community,
+This is a call for the vote to release Apache APISIX version 2.0.
+
+Release notes:
+
+https://github.com/apache/apisix/blob/2.0/CHANGELOG.md#200
+
+The release candidates:
+
+https://dist.apache.org/repos/dist/dev/apisix/2.0/
+<https://dist.apache.org/repos/dist/dev/apisix/1.5-rc1/>
+
+Git tag for the release:
+
+https://github.com/apache/apisix/tree/2.0
+<https://github.com/apache/apisix/tree/v1.5>
+
+Release Commit ID:
+
+https://github.com/apache/apisix/commit/79be83dd8adfbd5a1d98e0685c5db67166adac3f
+
+Keys to verify the Release Candidate:
+
+https://dist.apache.org/repos/dist/release/apisix/KEYS
Review comment:
In general, we will use KEYS from the `/dev` folder to validate the package.
##########
File path: website/docs/release-guide.md
##########
@@ -248,7 +248,80 @@ Committed revision 37435.
### Send VOTE thread to the dev mailing list
-Click [here](https://lists.apache.org/thread.html/rf534952a6b2d23ed6efdd61f15b40fa9e4de230164a1ccf168176734%40%3Cdev.apisix.apache.org%3E) to view the reference email. There is a minimum wait of 72 hours before statistical voting results. If you get -1 vote, you need to solve the problem before you can continue.
+There is a minimum wait of 72 hours before statistical voting results. If you get -1 vote, you need to solve the problem before you can continue. The reference email is as shown below.
+
+```
+Hello, Community,
+This is a call for the vote to release Apache APISIX version 2.0.
+
+Release notes:
+
+https://github.com/apache/apisix/blob/2.0/CHANGELOG.md#200
+
+The release candidates:
+
+https://dist.apache.org/repos/dist/dev/apisix/2.0/
+<https://dist.apache.org/repos/dist/dev/apisix/1.5-rc1/>
+
+Git tag for the release:
+
+https://github.com/apache/apisix/tree/2.0
+<https://github.com/apache/apisix/tree/v1.5>
+
+Release Commit ID:
+
+https://github.com/apache/apisix/commit/79be83dd8adfbd5a1d98e0685c5db67166adac3f
+
+Keys to verify the Release Candidate:
+
+https://dist.apache.org/repos/dist/release/apisix/KEYS
+<https://dist.apache.org/repos/dist/dev/apisix/KEYS>
+
+Steps to validating the release:
+
+1. Download the release
+
+wget
+https://dist.apache.org/repos/dist/dev/apisix/2.0/apache-apisix-2.0-src.tgz
+
+
+2. Checksums and signatures
+
+wget https://dist.apache.org/repos/dist/release/apisix/KEYS
+
+wget
+https://dist.apache.org/repos/dist/dev/apisix/2.0/apache-apisix-2.0-src.tgz.asc
+
+wget
+https://dist.apache.org/repos/dist/dev/apisix/2.0/apache-apisix-2.0-src.tgz.sha512
+
+gpg --import KEYS
+
+shasum -c apache-apisix-2.0-src.tgz.sha512
+
+gpg --verify apache-apisix-2.0-src.tgz.asc apache-apisix-2.0-src.tgz
+
+3. Unzip and Check files
+
+tar zxvf apache-apisix-2.0-src.tgz
+
+4. Build Apache APISIX:
+
+https://github.com/apache/apisix/blob/2.0/doc/how-to-build.md#installation-via-source-release
+
+The vote will be open for at least 72 hours or until necessary number of
+votes are reached.
+
+Please vote accordingly:
+
+[ ] +1 approve
+[ ] +0 no opinion
+[ ] -1 disapprove with the reason
+
+Thanks,
+Ming Wen, Apache APISIX & Apache SkyWalking
+Twitter: _WenMing
Review comment:
No need this signature
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org