You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@avro.apache.org by GitBox <gi...@apache.org> on 2020/08/21 12:13:04 UTC
[GitHub] [avro] xaneesaxo opened a new pull request #951: AVRO-2925: add support for UUID in compiler
xaneesaxo opened a new pull request #951:
URL: https://github.com/apache/avro/pull/951
Make sure you have checked _all_ steps below.
### Jira
- [ ] My PR addresses the following [Avro Jira](https://issues.apache.org/jira/browse/AVRO/) issues and references them in the PR title. For example, "AVRO-1234: My Avro PR"
- https://issues.apache.org/jira/browse/AVRO-XXX
- In case you are adding a dependency, check if the license complies with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
### Tests
- [ ] My PR adds the following unit tests __OR__ does not need testing for this extremely good reason:
### Commits
- [ ] My commits all reference Jira issues in their subject lines. In addition, my commits follow the guidelines from "[How to write a good git commit message](https://chris.beams.io/posts/git-commit/)":
1. Subject is separated from body by a blank line
1. Subject is limited to 50 characters (not including Jira issue reference)
1. Subject does not end with a period
1. Subject uses the imperative mood ("add", not "adding")
1. Body wraps at 72 characters
1. Body explains "what" and "why", not "how"
### Documentation
- [ ] In case of new functionality, my PR adds documentation that describes how to use it.
- All the public functions and the classes in the PR contain Javadoc that explain what it does
- No new documentation needed
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [avro] mhowlett commented on pull request #951: AVRO-2925: add support for UUID in compiler
Posted by GitBox <gi...@apache.org>.
mhowlett commented on pull request #951:
URL: https://github.com/apache/avro/pull/951#issuecomment-679300543
+1 from me
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [avro] xaneesaxo closed pull request #951: AVRO-2925: add support for UUID in compiler
Posted by GitBox <gi...@apache.org>.
xaneesaxo closed pull request #951:
URL: https://github.com/apache/avro/pull/951
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [avro] xaneesaxo closed pull request #951: AVRO-2925: add support for UUID in compiler
Posted by GitBox <gi...@apache.org>.
xaneesaxo closed pull request #951:
URL: https://github.com/apache/avro/pull/951
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [avro] RyanSkraba merged pull request #951: AVRO-2925: add support for UUID in compiler
Posted by GitBox <gi...@apache.org>.
RyanSkraba merged pull request #951:
URL: https://github.com/apache/avro/pull/951
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [avro] xaneesaxo closed pull request #951: AVRO-2925: add support for UUID in compiler
Posted by GitBox <gi...@apache.org>.
xaneesaxo closed pull request #951:
URL: https://github.com/apache/avro/pull/951
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [avro] RyanSkraba merged pull request #951: AVRO-2925: add support for UUID in compiler
Posted by GitBox <gi...@apache.org>.
RyanSkraba merged pull request #951:
URL: https://github.com/apache/avro/pull/951
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [avro] xaneesaxo closed pull request #951: AVRO-2925: add support for UUID in compiler
Posted by GitBox <gi...@apache.org>.
xaneesaxo closed pull request #951:
URL: https://github.com/apache/avro/pull/951
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [avro] RyanSkraba commented on a change in pull request #951: AVRO-2925: add support for UUID in compiler
Posted by GitBox <gi...@apache.org>.
RyanSkraba commented on a change in pull request #951:
URL: https://github.com/apache/avro/pull/951#discussion_r485444344
##########
File path: lang/java/compiler/src/test/idl/input/uuid.avdl
##########
@@ -0,0 +1,41 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * https://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+
+
+/**
+Testing UUID fields
+*/
+
+@namespace("org.apache.avro")
+protocol MyProtocol {
+ record APlaygroundEvent {
Review comment:
```suggestion
record APlaygroundEvent {
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [avro] RyanSkraba merged pull request #951: AVRO-2925: add support for UUID in compiler
Posted by GitBox <gi...@apache.org>.
RyanSkraba merged pull request #951:
URL: https://github.com/apache/avro/pull/951
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [avro] RyanSkraba merged pull request #951: AVRO-2925: add support for UUID in compiler
Posted by GitBox <gi...@apache.org>.
RyanSkraba merged pull request #951:
URL: https://github.com/apache/avro/pull/951
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org