You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2020/08/31 17:17:10 UTC
[GitHub] [beam] jayendra13 opened a new pull request #12738: [BEAM-10615] Eliminate nullability errors from :sdks:java:extensions:sql:jdbc
jayendra13 opened a new pull request #12738:
URL: https://github.com/apache/beam/pull/12738
Fixing nullability errors from module :sdks:java:extensions:sql:jdbc
------------------------
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
- [ ] [**Choose reviewer(s)**](https://beam.apache.org/contribute/#make-your-change) and mention them in a comment (`R: @username`).
- [ ] Format the pull request title like `[BEAM-XXX] Fixes bug in ApproximateQuantiles`, where you replace `BEAM-XXX` with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.
- [ ] Update `CHANGES.md` with noteworthy changes.
- [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
See the [Contributor Guide](https://beam.apache.org/contribute) for more tips on [how to make review process smoother](https://beam.apache.org/contribute/#make-reviewers-job-easier).
Post-Commit Tests Status (on master branch)
------------------------------------------------------------------------------------------------
Lang | SDK | Dataflow | Flink | Samza | Spark | Twister2
--- | --- | --- | --- | --- | --- | ---
Go | [](https://ci-beam.apache.org/job/beam_PostCommit_Go/lastCompletedBuild/) | --- | [](https://ci-beam.apache.org/job/beam_PostCommit_Go_VR_Flink/lastCompletedBuild/) | --- | [](https://ci-beam.apache.org/job/beam_PostCommit_Go_VR_Spark/lastCompletedBuild/) | ---
Java | [](https://ci-beam.apache.org/job/beam_PostCommit_Java/lastCompletedBuild/) | [](https://ci-beam.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Dataflow/lastCompletedBuild/)<br>[](https://ci-beam.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Dataflow_Java11/lastCompletedBuild/) | [](https://ci-beam.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Flink/lastCompletedBuild/)<br>[](https://ci-beam.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Flink_Java11/lastCompletedBuild/)<br>[](https://ci-beam.apache.org/job/beam_PostCommit_Java_PVR_Flink_Batch/lastCompletedBuild/)<br>[](https://ci-beam.apache.org/job/beam_PostCommit_Java_PVR_Flink_Streaming/lastCompletedBuild/) | [](https://ci-beam.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Samza/lastCompletedBuild/) | [](https://ci-beam.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Spark/lastCompletedBuild/)<br>[](https://ci-beam.apache.org/job/beam_PostCommit_Java_PVR_Spark_Batch/lastCompletedBuild/)<br>[](https://ci-beam.apache.org/job/beam_PostCommit_Java_ValidatesRunner_SparkStructuredStreaming/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Twister2/lastCompletedBuild/)
Python | [](https://ci-beam.apache.org/job/beam_PostCommit_Python2/lastCompletedBuild/)<br>[](https://ci-beam.apache.org/job/beam_PostCommit_Python35/lastCompletedBuild/)<br>[](https://ci-beam.apache.org/job/beam_PostCommit_Python36/lastCompletedBuild/)<br>[](https://ci-beam.apache.org/job/beam_PostCommit_Python37/lastCompletedBuild/)<br>[](https://ci-beam.apache.org/job/beam_PostCommit_Python38/lastCompletedBuild/) | [](https://ci-beam.apache.org/job/beam_PostCommit_Py_VR_Dataflow/lastCompletedBuild/)<br>[](https://ci-beam.apache.org/job/beam_PostCommit_Py_VR_Dataflow_V2/lastCompletedBuild/)<br>[](https://ci-beam.apache.org/job/beam_PostCommit_Py_ValCont/lastCompletedBuild/) | [](https://ci-beam.apache.org/job/beam_PreCommit_Python2_PVR_Flink_Cron/lastCompletedBuild/)<br>[](https://ci-beam.apache.org/job/beam_PostCommit_Python35_VR_Flink/lastCompletedBuild/) | --- | [](https://ci-beam.apache.org/job/beam_PostCommit_Python_VR_Spark/lastCompletedBuild/) | ---
XLang | [](https://ci-beam.apache.org/job/beam_PostCommit_XVR_Direct/lastCompletedBuild/) | --- | [](https://ci-beam.apache.org/job/beam_PostCommit_XVR_Flink/lastCompletedBuild/) | --- | [](https://ci-beam.apache.org/job/beam_PostCommit_XVR_Spark/lastCompletedBuild/) | ---
Pre-Commit Tests Status (on master branch)
------------------------------------------------------------------------------------------------
--- |Java | Python | Go | Website | Whitespace
--- | --- | --- | --- | --- | ---
Non-portable | [](https://ci-beam.apache.org/job/beam_PreCommit_Java_Cron/lastCompletedBuild/) | [](https://ci-beam.apache.org/job/beam_PreCommit_Python_Cron/lastCompletedBuild/)<br>[](https://ci-beam.apache.org/job/beam_PreCommit_PythonLint_Cron/lastCompletedBuild/)<br>[](https://ci-beam.apache.org/job/beam_PreCommit_PythonDocker_Cron/lastCompletedBuild/) <br>[](https://ci-beam.apache.org/job/beam_PreCommit_PythonDocs_Cron/lastCompletedBuild/) | [](https://ci-beam.apache.org/job/beam_PreCommit_Go_Cron/lastCompletedBuild/) | [](https://ci-beam.apache.org/job/beam_PreCommit_Website_Cron/lastCompletedBuild/) | [](https://ci-beam.apache.org/job/beam_PreCommit_Whitespace_Cron/lastCompletedBuild/)
Portable | --- | [](https://ci-beam.apache.org/job/beam_PreCommit_Portable_Python_Cron/lastCompletedBuild/) | --- | --- | ---
See [.test-infra/jenkins/README](https://github.com/apache/beam/blob/master/.test-infra/jenkins/README.md) for trigger phrase, status and link of all Jenkins jobs.
GitHub Actions Tests Status (on master branch)
------------------------------------------------------------------------------------------------
See [CI.md](https://github.com/apache/beam/blob/master/CI.md) for more information about GitHub Actions CI.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] TheNeuralBit commented on a change in pull request #12738: [BEAM-10615] Eliminate nullability errors from :sdks:java:extensions:sql:jdbc
Posted by GitBox <gi...@apache.org>.
TheNeuralBit commented on a change in pull request #12738:
URL: https://github.com/apache/beam/pull/12738#discussion_r481309457
##########
File path: sdks/java/extensions/sql/jdbc/src/test/java/org/apache/beam/sdk/extensions/sql/jdbc/BeamSqlLineIT.java
##########
@@ -198,12 +202,15 @@ private String taxiRideJSON(
return objectNode.toString();
}
+ /** Suppressing this due to https://github.com/typetools/checker-framework/issues/979. */
+ @SuppressWarnings("return.type.incompatible")
private Future<List<List<String>>> runQueryInBackground(String[] args) {
return pool.submit(
(Callable)
() -> {
ByteArrayOutputStream outputStream = new ByteArrayOutputStream();
- BeamSqlLine.runSqlLine(args, null, outputStream, null);
+ InputStream inputStream = new ByteArrayInputStream(new byte[0]);
+ BeamSqlLine.runSqlLine(args, inputStream, outputStream, null);
Review comment:
I think actually the appropriate fix here is to make `inputStream` `@Nullable` in runSqlLine. It looks like SqlLine handles a null here: https://github.com/julianhyde/sqlline/blob/sqlline-1.4.0/src/main/java/sqlline/SqlLine.java#L717-L722
Could you try that instead?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] TheNeuralBit commented on a change in pull request #12738: [BEAM-10615] Eliminate nullability errors from :sdks:java:extensions:sql:jdbc
Posted by GitBox <gi...@apache.org>.
TheNeuralBit commented on a change in pull request #12738:
URL: https://github.com/apache/beam/pull/12738#discussion_r483084816
##########
File path: sdks/java/extensions/sql/jdbc/src/test/java/org/apache/beam/sdk/extensions/sql/jdbc/BeamSqlLineIT.java
##########
@@ -198,12 +202,15 @@ private String taxiRideJSON(
return objectNode.toString();
}
+ /** Suppressing this due to https://github.com/typetools/checker-framework/issues/979. */
+ @SuppressWarnings("return.type.incompatible")
private Future<List<List<String>>> runQueryInBackground(String[] args) {
return pool.submit(
(Callable)
() -> {
ByteArrayOutputStream outputStream = new ByteArrayOutputStream();
- BeamSqlLine.runSqlLine(args, null, outputStream, null);
+ InputStream inputStream = new ByteArrayInputStream(new byte[0]);
+ BeamSqlLine.runSqlLine(args, inputStream, outputStream, null);
Review comment:
Thank you! yeah the github actions tests on different targets seem to flake pretty often and I'm not sure how to re-run them. I think its safe to ignore.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] jayendra13 commented on a change in pull request #12738: [BEAM-10615] Eliminate nullability errors from :sdks:java:extensions:sql:jdbc
Posted by GitBox <gi...@apache.org>.
jayendra13 commented on a change in pull request #12738:
URL: https://github.com/apache/beam/pull/12738#discussion_r482677706
##########
File path: sdks/java/extensions/sql/jdbc/src/test/java/org/apache/beam/sdk/extensions/sql/jdbc/BeamSqlLineIT.java
##########
@@ -198,12 +202,15 @@ private String taxiRideJSON(
return objectNode.toString();
}
+ /** Suppressing this due to https://github.com/typetools/checker-framework/issues/979. */
+ @SuppressWarnings("return.type.incompatible")
private Future<List<List<String>>> runQueryInBackground(String[] args) {
return pool.submit(
(Callable)
() -> {
ByteArrayOutputStream outputStream = new ByteArrayOutputStream();
- BeamSqlLine.runSqlLine(args, null, outputStream, null);
+ InputStream inputStream = new ByteArrayInputStream(new byte[0]);
+ BeamSqlLine.runSqlLine(args, inputStream, outputStream, null);
Review comment:
Done. This `ubuntu-latest` Unit-Test is not failing on my local machine.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] TheNeuralBit commented on a change in pull request #12738: [BEAM-10615] Eliminate nullability errors from :sdks:java:extensions:sql:jdbc
Posted by GitBox <gi...@apache.org>.
TheNeuralBit commented on a change in pull request #12738:
URL: https://github.com/apache/beam/pull/12738#discussion_r482608677
##########
File path: sdks/java/extensions/sql/jdbc/src/test/java/org/apache/beam/sdk/extensions/sql/jdbc/BeamSqlLineIT.java
##########
@@ -198,12 +202,15 @@ private String taxiRideJSON(
return objectNode.toString();
}
+ /** Suppressing this due to https://github.com/typetools/checker-framework/issues/979. */
+ @SuppressWarnings("return.type.incompatible")
private Future<List<List<String>>> runQueryInBackground(String[] args) {
return pool.submit(
(Callable)
() -> {
ByteArrayOutputStream outputStream = new ByteArrayOutputStream();
- BeamSqlLine.runSqlLine(args, null, outputStream, null);
+ InputStream inputStream = new ByteArrayInputStream(new byte[0]);
+ BeamSqlLine.runSqlLine(args, inputStream, outputStream, null);
Review comment:
Could we add an annotation to runSqlLine to suppress that warning? That seems preferable to creating InputStream instances that aren't actually used
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] jayendra13 commented on pull request #12738: [BEAM-10615] Eliminate nullability errors from :sdks:java:extensions:sql:jdbc
Posted by GitBox <gi...@apache.org>.
jayendra13 commented on pull request #12738:
URL: https://github.com/apache/beam/pull/12738#issuecomment-684154741
R: @TheNeuralBit
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] TheNeuralBit merged pull request #12738: [BEAM-10615] Eliminate nullability errors from :sdks:java:extensions:sql:jdbc
Posted by GitBox <gi...@apache.org>.
TheNeuralBit merged pull request #12738:
URL: https://github.com/apache/beam/pull/12738
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] jayendra13 commented on a change in pull request #12738: [BEAM-10615] Eliminate nullability errors from :sdks:java:extensions:sql:jdbc
Posted by GitBox <gi...@apache.org>.
jayendra13 commented on a change in pull request #12738:
URL: https://github.com/apache/beam/pull/12738#discussion_r481581885
##########
File path: sdks/java/extensions/sql/jdbc/src/test/java/org/apache/beam/sdk/extensions/sql/jdbc/BeamSqlLineIT.java
##########
@@ -198,12 +202,15 @@ private String taxiRideJSON(
return objectNode.toString();
}
+ /** Suppressing this due to https://github.com/typetools/checker-framework/issues/979. */
+ @SuppressWarnings("return.type.incompatible")
private Future<List<List<String>>> runQueryInBackground(String[] args) {
return pool.submit(
(Callable)
() -> {
ByteArrayOutputStream outputStream = new ByteArrayOutputStream();
- BeamSqlLine.runSqlLine(args, null, outputStream, null);
+ InputStream inputStream = new ByteArrayInputStream(new byte[0]);
+ BeamSqlLine.runSqlLine(args, inputStream, outputStream, null);
Review comment:
I got your point, but it would require to annotate the `inputStream` [here](https://github.com/julianhyde/sqlline/blob/sqlline-1.4.0/src/main/java/sqlline/SqlLine.java#L615) in `begin` method with `@Nullable`, which is outside the project. What could be possible workaround here ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org