You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@aurora.apache.org by Zameer Manji <zm...@twopensource.com> on 2014/11/14 02:07:02 UTC
Review Request 28021: Remove dependency on commons-lang.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28021/
-----------------------------------------------------------
Review request for Aurora, Joshua Cohen and Kevin Sweeney.
Repository: aurora
Description
-------
Remove dependency on commons-lang.
Diffs
-----
build.gradle 3237f8dfa3e7d4249a388042dba840a939d513b3
src/main/java/org/apache/aurora/scheduler/configuration/ConfigurationManager.java 3661f8487985f631e3ea437fe6430e0296376a9e
src/main/java/org/apache/aurora/scheduler/configuration/SanitizedConfiguration.java 4eb4437b91906ae191dd105474e84ba5f40cf52e
src/main/java/org/apache/aurora/scheduler/cron/SanitizedCronJob.java 48b403e155684861ec0307a61ccb0775cdb57a32
src/main/java/org/apache/aurora/scheduler/storage/mem/MemTaskStore.java 37176237fac336413267f3c8bb4e1b9a6255150c
src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java a43e5d7748c22d60f56f03a8a3d52949faebeff2
Diff: https://reviews.apache.org/r/28021/diff/
Testing
-------
./gradlew clean build -Pq
Thanks,
Zameer Manji
Re: Review Request 28021: Remove dependency on commons-lang.
Posted by Jake Farrell <jf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28021/#review61370
-----------------------------------------------------------
Ship it!
Ship It!
- Jake Farrell
On Nov. 14, 2014, 1:07 a.m., Zameer Manji wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/28021/
> -----------------------------------------------------------
>
> (Updated Nov. 14, 2014, 1:07 a.m.)
>
>
> Review request for Aurora, Joshua Cohen and Kevin Sweeney.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Remove dependency on commons-lang.
>
>
> Diffs
> -----
>
> build.gradle 3237f8dfa3e7d4249a388042dba840a939d513b3
> src/main/java/org/apache/aurora/scheduler/configuration/ConfigurationManager.java 3661f8487985f631e3ea437fe6430e0296376a9e
> src/main/java/org/apache/aurora/scheduler/configuration/SanitizedConfiguration.java 4eb4437b91906ae191dd105474e84ba5f40cf52e
> src/main/java/org/apache/aurora/scheduler/cron/SanitizedCronJob.java 48b403e155684861ec0307a61ccb0775cdb57a32
> src/main/java/org/apache/aurora/scheduler/storage/mem/MemTaskStore.java 37176237fac336413267f3c8bb4e1b9a6255150c
> src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java a43e5d7748c22d60f56f03a8a3d52949faebeff2
>
> Diff: https://reviews.apache.org/r/28021/diff/
>
>
> Testing
> -------
>
> ./gradlew clean build -Pq
>
>
> Thanks,
>
> Zameer Manji
>
>
Re: Review Request 28021: Remove dependency on commons-lang.
Posted by Zameer Manji <zm...@twopensource.com>.
> On Nov. 14, 2014, 5:16 p.m., Kevin Sweeney wrote:
> > Ship It!
Kevin, can you please commit this? Thanks.
- Zameer
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28021/#review61588
-----------------------------------------------------------
On Nov. 13, 2014, 5:07 p.m., Zameer Manji wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/28021/
> -----------------------------------------------------------
>
> (Updated Nov. 13, 2014, 5:07 p.m.)
>
>
> Review request for Aurora, Joshua Cohen and Kevin Sweeney.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Remove dependency on commons-lang.
>
>
> Diffs
> -----
>
> build.gradle 3237f8dfa3e7d4249a388042dba840a939d513b3
> src/main/java/org/apache/aurora/scheduler/configuration/ConfigurationManager.java 3661f8487985f631e3ea437fe6430e0296376a9e
> src/main/java/org/apache/aurora/scheduler/configuration/SanitizedConfiguration.java 4eb4437b91906ae191dd105474e84ba5f40cf52e
> src/main/java/org/apache/aurora/scheduler/cron/SanitizedCronJob.java 48b403e155684861ec0307a61ccb0775cdb57a32
> src/main/java/org/apache/aurora/scheduler/storage/mem/MemTaskStore.java 37176237fac336413267f3c8bb4e1b9a6255150c
> src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java a43e5d7748c22d60f56f03a8a3d52949faebeff2
>
> Diff: https://reviews.apache.org/r/28021/diff/
>
>
> Testing
> -------
>
> ./gradlew clean build -Pq
>
>
> Thanks,
>
> Zameer Manji
>
>
Re: Review Request 28021: Remove dependency on commons-lang.
Posted by Kevin Sweeney <ke...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28021/#review61588
-----------------------------------------------------------
Ship it!
Ship It!
- Kevin Sweeney
On Nov. 13, 2014, 5:07 p.m., Zameer Manji wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/28021/
> -----------------------------------------------------------
>
> (Updated Nov. 13, 2014, 5:07 p.m.)
>
>
> Review request for Aurora, Joshua Cohen and Kevin Sweeney.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Remove dependency on commons-lang.
>
>
> Diffs
> -----
>
> build.gradle 3237f8dfa3e7d4249a388042dba840a939d513b3
> src/main/java/org/apache/aurora/scheduler/configuration/ConfigurationManager.java 3661f8487985f631e3ea437fe6430e0296376a9e
> src/main/java/org/apache/aurora/scheduler/configuration/SanitizedConfiguration.java 4eb4437b91906ae191dd105474e84ba5f40cf52e
> src/main/java/org/apache/aurora/scheduler/cron/SanitizedCronJob.java 48b403e155684861ec0307a61ccb0775cdb57a32
> src/main/java/org/apache/aurora/scheduler/storage/mem/MemTaskStore.java 37176237fac336413267f3c8bb4e1b9a6255150c
> src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java a43e5d7748c22d60f56f03a8a3d52949faebeff2
>
> Diff: https://reviews.apache.org/r/28021/diff/
>
>
> Testing
> -------
>
> ./gradlew clean build -Pq
>
>
> Thanks,
>
> Zameer Manji
>
>
Re: Review Request 28021: Remove dependency on commons-lang.
Posted by Bill Farner <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28021/#review61372
-----------------------------------------------------------
Ship it!
Ship It!
- Bill Farner
On Nov. 14, 2014, 1:07 a.m., Zameer Manji wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/28021/
> -----------------------------------------------------------
>
> (Updated Nov. 14, 2014, 1:07 a.m.)
>
>
> Review request for Aurora, Joshua Cohen and Kevin Sweeney.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Remove dependency on commons-lang.
>
>
> Diffs
> -----
>
> build.gradle 3237f8dfa3e7d4249a388042dba840a939d513b3
> src/main/java/org/apache/aurora/scheduler/configuration/ConfigurationManager.java 3661f8487985f631e3ea437fe6430e0296376a9e
> src/main/java/org/apache/aurora/scheduler/configuration/SanitizedConfiguration.java 4eb4437b91906ae191dd105474e84ba5f40cf52e
> src/main/java/org/apache/aurora/scheduler/cron/SanitizedCronJob.java 48b403e155684861ec0307a61ccb0775cdb57a32
> src/main/java/org/apache/aurora/scheduler/storage/mem/MemTaskStore.java 37176237fac336413267f3c8bb4e1b9a6255150c
> src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java a43e5d7748c22d60f56f03a8a3d52949faebeff2
>
> Diff: https://reviews.apache.org/r/28021/diff/
>
>
> Testing
> -------
>
> ./gradlew clean build -Pq
>
>
> Thanks,
>
> Zameer Manji
>
>
Re: Review Request 28021: Remove dependency on commons-lang.
Posted by Aurora ReviewBot <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28021/#review61368
-----------------------------------------------------------
Master (254e175) is green with this patch.
./build-support/jenkins/build.sh
However, it appears that it might lack test coverage.
I will refresh this build result if you post a review containing "@ReviewBot retry"
- Aurora ReviewBot
On Nov. 14, 2014, 1:07 a.m., Zameer Manji wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/28021/
> -----------------------------------------------------------
>
> (Updated Nov. 14, 2014, 1:07 a.m.)
>
>
> Review request for Aurora, Joshua Cohen and Kevin Sweeney.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Remove dependency on commons-lang.
>
>
> Diffs
> -----
>
> build.gradle 3237f8dfa3e7d4249a388042dba840a939d513b3
> src/main/java/org/apache/aurora/scheduler/configuration/ConfigurationManager.java 3661f8487985f631e3ea437fe6430e0296376a9e
> src/main/java/org/apache/aurora/scheduler/configuration/SanitizedConfiguration.java 4eb4437b91906ae191dd105474e84ba5f40cf52e
> src/main/java/org/apache/aurora/scheduler/cron/SanitizedCronJob.java 48b403e155684861ec0307a61ccb0775cdb57a32
> src/main/java/org/apache/aurora/scheduler/storage/mem/MemTaskStore.java 37176237fac336413267f3c8bb4e1b9a6255150c
> src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java a43e5d7748c22d60f56f03a8a3d52949faebeff2
>
> Diff: https://reviews.apache.org/r/28021/diff/
>
>
> Testing
> -------
>
> ./gradlew clean build -Pq
>
>
> Thanks,
>
> Zameer Manji
>
>
Re: Review Request 28021: Remove dependency on commons-lang.
Posted by Joshua Cohen <jc...@twopensource.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28021/#review61564
-----------------------------------------------------------
Ship it!
Ship It!
- Joshua Cohen
On Nov. 14, 2014, 1:07 a.m., Zameer Manji wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/28021/
> -----------------------------------------------------------
>
> (Updated Nov. 14, 2014, 1:07 a.m.)
>
>
> Review request for Aurora, Joshua Cohen and Kevin Sweeney.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Remove dependency on commons-lang.
>
>
> Diffs
> -----
>
> build.gradle 3237f8dfa3e7d4249a388042dba840a939d513b3
> src/main/java/org/apache/aurora/scheduler/configuration/ConfigurationManager.java 3661f8487985f631e3ea437fe6430e0296376a9e
> src/main/java/org/apache/aurora/scheduler/configuration/SanitizedConfiguration.java 4eb4437b91906ae191dd105474e84ba5f40cf52e
> src/main/java/org/apache/aurora/scheduler/cron/SanitizedCronJob.java 48b403e155684861ec0307a61ccb0775cdb57a32
> src/main/java/org/apache/aurora/scheduler/storage/mem/MemTaskStore.java 37176237fac336413267f3c8bb4e1b9a6255150c
> src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java a43e5d7748c22d60f56f03a8a3d52949faebeff2
>
> Diff: https://reviews.apache.org/r/28021/diff/
>
>
> Testing
> -------
>
> ./gradlew clean build -Pq
>
>
> Thanks,
>
> Zameer Manji
>
>