Re: removing redirect code from turbine (was Re: Using turbine with session-cookies disabled)

[Jon Scott Stevens <jo...@latchkey.com>]

It has been removed from the t3 code base. Just look at what I did to remove
it.

-jon

on 3/28/02 2:09 PM, "Eric Dobbs" <er...@dobbse.net> wrote:

> Ben Peter and Rodney Schneider on turbine-user are asking
> for redirect code to be removed from turbine before 2.2
> release.  Rodney has asked before.
> 
> On Thursday, March 28, 2002, at 11:21  AM, Daniel Rall wrote:
> 
>> If you think something needs to be done to the source, please send an
>> enumeration of the steps and the reasoning behind them to the
>> turbine-dev@jakara.apache.org list.
> 
> Dan,
> Peter Lynch provided patches and rationale back in October:
> <http://www.mail-archive.com/turbine-
> dev%40jakarta.apache.org/msg03660.html>
> 
> I looked over the patches this morning.  There's distracting
> whitespace changes in the patches, but they don't look too bad
> to me.  I didn't try to apply them 'cos I didn't see a
> resolution to the discussion back in October.
> 
> I think Peter made his point fairly well, and I would support
> the removal of the redirect code.  But I don't know how the
> deprecation rules fit in this case.
> 
> If deprecation policy calls for preserving the existing redirect
> functionality, then I offer the following refactoring ideas:
> 1. extract methods on the areas where Peter's patches would have
>   removed redirect code.
> 2. deprecate the newly extracted methods
> 3. add a configuration option to enable/disable the redirection
>   and make the extracted methods pay attention to the config
>   option
> 
> If deprecation policy does not apply here, then manually apply
> Peter's changes to the 2.2 code and be done with it.


--
To unsubscribe, e-mail:   <ma...@jakarta.apache.org>
For additional commands, e-mail: <ma...@jakarta.apache.org>

Re: removing redirect code from turbine (was Re: Using turbine with session-cookies disabled)

[Daniel Rall <dl...@finemaltcoding.com>]

John McNally <jm...@collab.net> writes:

> Remove it.  The problem it was meant to solve has been gone for quite a
> while.  I think it only existed on jserv1.0.  We are not supporting use
> of jserv.

+1 on removing it -- Turbine officially supports servlet api 2.2 and
+higher.  JServ was 2.0.


--
To unsubscribe, e-mail:   <ma...@jakarta.apache.org>
For additional commands, e-mail: <ma...@jakarta.apache.org>

Re: removing redirect code from turbine (was Re: Using turbine with session-cookies disabled)

[John McNally <jm...@collab.net>]

Remove it.  The problem it was meant to solve has been gone for quite a
while.  I think it only existed on jserv1.0.  We are not supporting use
of jserv.

john mcnally

Eric Dobbs wrote:
> 
> On Thursday, March 28, 2002, at 04:48  PM, Jon Scott Stevens wrote:
> 
> > It has been removed from the t3 code base. Just look at what I did to
> > remove
> > it.
> 
> Thanks, Jon.  Still unclear on one point, though.
> (maybe this should be a vote?)
> 
> Should redirection be *removed* for the 2.2 release?
> 
> OR
> 
> Should the redirection be *deprecated* 2.2 release?
> It's not part of the API, but it is behavior that
> was created purposefully to solve a specific
> problem.  It's not exactly a bug.  Should that
> behavior be preserved, but discouraged?
> 
> -Eric
> 
> --
> To unsubscribe, e-mail:   <ma...@jakarta.apache.org>
> For additional commands, e-mail: <ma...@jakarta.apache.org>

--
To unsubscribe, e-mail:   <ma...@jakarta.apache.org>
For additional commands, e-mail: <ma...@jakarta.apache.org>

Re: removing redirect code from turbine (was Re: Using turbine with session-cookies disabled)

[Eric Dobbs <er...@dobbse.net>]

On Thursday, March 28, 2002, at 04:48  PM, Jon Scott Stevens wrote:

> It has been removed from the t3 code base. Just look at what I did to 
> remove
> it.

Thanks, Jon.  Still unclear on one point, though.
(maybe this should be a vote?)

Should redirection be *removed* for the 2.2 release?

OR

Should the redirection be *deprecated* 2.2 release?
It's not part of the API, but it is behavior that
was created purposefully to solve a specific
problem.  It's not exactly a bug.  Should that
behavior be preserved, but discouraged?

-Eric

--
To unsubscribe, e-mail:   <ma...@jakarta.apache.org>
For additional commands, e-mail: <ma...@jakarta.apache.org>