You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@druid.apache.org by GitBox <gi...@apache.org> on 2022/03/09 16:45:18 UTC

[GitHub] [druid] gianm opened a new pull request #12325: Fix error message for groupByEnableMultiValueUnnesting.

gianm opened a new pull request #12325:
URL: https://github.com/apache/druid/pull/12325


   It referred to the incorrect context parameter.
   
   Also, create a dedicated exception class, to allow easier detection of this
   specific error.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org


[GitHub] [druid] gianm commented on a change in pull request #12325: Fix error message for groupByEnableMultiValueUnnesting.

Posted by GitBox <gi...@apache.org>.
gianm commented on a change in pull request #12325:
URL: https://github.com/apache/druid/pull/12325#discussion_r822863561



##########
File path: processing/src/main/java/org/apache/druid/query/groupby/epinephelinae/GroupByMergingQueryRunnerV2.java
##########
@@ -249,6 +250,7 @@ public AggregateResult call()
                                       }
                                       catch (Exception e) {
                                         log.error(e, "Exception with one of the sequences!");
+                                        Throwables.propagateIfPossible(e);

Review comment:
       FYI: purpose of this line is to avoid wrapping exceptions when not necessary. I noticed the extra wrapper exception when writing the unit test.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org


[GitHub] [druid] gianm merged pull request #12325: Fix error message for groupByEnableMultiValueUnnesting.

Posted by GitBox <gi...@apache.org>.
gianm merged pull request #12325:
URL: https://github.com/apache/druid/pull/12325


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org


[GitHub] [druid] gianm commented on a change in pull request #12325: Fix error message for groupByEnableMultiValueUnnesting.

Posted by GitBox <gi...@apache.org>.
gianm commented on a change in pull request #12325:
URL: https://github.com/apache/druid/pull/12325#discussion_r822871003



##########
File path: processing/src/test/java/org/apache/druid/query/groupby/GroupByQueryRunnerTest.java
##########
@@ -1330,12 +1334,16 @@ public void testMultiValueDimensionNotAllowed()
       ));
     } else if (!vectorize) {
       expectedException.expect(RuntimeException.class);
+      expectedException.expectCause(CoreMatchers.instanceOf(ExecutionException.class));

Review comment:
       You're right. Added that too. Thanks.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org


[GitHub] [druid] cryptoe commented on a change in pull request #12325: Fix error message for groupByEnableMultiValueUnnesting.

Posted by GitBox <gi...@apache.org>.
cryptoe commented on a change in pull request #12325:
URL: https://github.com/apache/druid/pull/12325#discussion_r822865673



##########
File path: processing/src/test/java/org/apache/druid/query/groupby/GroupByQueryRunnerTest.java
##########
@@ -1330,12 +1334,16 @@ public void testMultiValueDimensionNotAllowed()
       ));
     } else if (!vectorize) {
       expectedException.expect(RuntimeException.class);
+      expectedException.expectCause(CoreMatchers.instanceOf(ExecutionException.class));

Review comment:
       I think you missed CalciteMultiValueStringQueryTest




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org