You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by li...@apache.org on 2023/11/29 05:40:04 UTC
(skywalking-cli) branch fix-record-query created (now 2493cca)
This is an automated email from the ASF dual-hosted git repository.
liuhan pushed a change to branch fix-record-query
in repository https://gitbox.apache.org/repos/asf/skywalking-cli.git
at 2493cca Fix the record list query does not support new OAP versions
This branch includes the following new commits:
new 2493cca Fix the record list query does not support new OAP versions
The 1 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails. The revisions
listed as "add" were already present in the repository and have only
been added to this reference.
(skywalking-cli) 01/01: Fix the record list query does not support new OAP versions
Posted by li...@apache.org.
This is an automated email from the ASF dual-hosted git repository.
liuhan pushed a commit to branch fix-record-query
in repository https://gitbox.apache.org/repos/asf/skywalking-cli.git
commit 2493ccae09d81ecc306975aa5a8d3f2825e9d4c3
Author: mrproliu <74...@qq.com>
AuthorDate: Wed Nov 29 13:39:54 2023 +0800
Fix the record list query does not support new OAP versions
---
CHANGES.md | 5 +++++
internal/commands/metrics/aggregation/sampled-record.go | 2 +-
2 files changed, 6 insertions(+), 1 deletion(-)
diff --git a/CHANGES.md b/CHANGES.md
index 42bc400..8520a3e 100644
--- a/CHANGES.md
+++ b/CHANGES.md
@@ -6,6 +6,11 @@ Release Notes.
------------------
### Features
+
+### Bug Fixes
+
+* Fix the record list query does not support new OAP versions (with major version number > 9).
+
## What's Changed
* Add the sub-command `menu get` for get the ui menu items by @mrproliu in https://github.com/apache/skywalking-cli/pull/187
diff --git a/internal/commands/metrics/aggregation/sampled-record.go b/internal/commands/metrics/aggregation/sampled-record.go
index 3745de7..4f26881 100644
--- a/internal/commands/metrics/aggregation/sampled-record.go
+++ b/internal/commands/metrics/aggregation/sampled-record.go
@@ -76,7 +76,7 @@ $ swctl metrics sampled-record --name top_n_database_statement 5
}
// since 9.3.0, use new record query API
- if major >= 9 && minor >= 3 {
+ if (major == 9 && minor >= 3) || major > 9 {
condition, duration, err1 := buildReadRecordsCondition(ctx)
if err1 != nil {
return err1