You are viewing a plain text version of this content. The canonical link for it is here.
Posted to hdfs-dev@hadoop.apache.org by "Conrad Meyer (JIRA)" <ji...@apache.org> on 2012/07/18 20:37:34 UTC

[jira] [Created] (HDFS-3679) fuse_dfs notrash option sets usetrash

Conrad Meyer created HDFS-3679:
----------------------------------

             Summary: fuse_dfs notrash option sets usetrash
                 Key: HDFS-3679
                 URL: https://issues.apache.org/jira/browse/HDFS-3679
             Project: Hadoop HDFS
          Issue Type: Bug
          Components: fuse-dfs
    Affects Versions: 2.0.0-alpha, 1.0.3, 1.0.2, 1.0.1, 1.0.0
            Reporter: Conrad Meyer
            Priority: Minor


fuse_dfs sets usetrash option when the "notrash" flag is given. This is the exact opposite of the desired behavior. The "usetrash" flag sets usetrash as well, but this is correct. Here are the relevant lines from fuse_options.c, in latest HDFS HEAD[0]:

123	  case KEY_USETRASH:
124	    options.usetrash = 1;
125	    break;
126	  case KEY_NOTRASH:
127	    options.usetrash = 1;
128	    break;

This is a pretty trivial bug to fix. I'm not familiar with the process here, but I can attach a patch if needed.

[0]: https://svn.apache.org/viewvc/hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/native/fuse-dfs/fuse_options.c?view=markup

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Resolved] (HDFS-3679) fuse_dfs notrash option sets usetrash

Posted by "Suresh Srinivas (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HDFS-3679?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Suresh Srinivas resolved HDFS-3679.
-----------------------------------

       Resolution: Fixed
    Fix Version/s: 2.1.0-alpha
                   1.2.0
     Hadoop Flags: Reviewed

I committed the patch to trunk, branch-2 and branch-1. Thank you Conrad.
                
> fuse_dfs notrash option sets usetrash
> -------------------------------------
>
>                 Key: HDFS-3679
>                 URL: https://issues.apache.org/jira/browse/HDFS-3679
>             Project: Hadoop HDFS
>          Issue Type: Bug
>          Components: fuse-dfs
>    Affects Versions: 1.0.0, 1.0.1, 1.0.2, 1.0.3, 2.0.0-alpha
>            Reporter: Conrad Meyer
>            Assignee: Conrad Meyer
>            Priority: Minor
>             Fix For: 1.2.0, 2.1.0-alpha
>
>         Attachments: hdfs-3679.diff
>
>   Original Estimate: 1m
>  Remaining Estimate: 1m
>
> fuse_dfs sets usetrash option when the "notrash" flag is given. This is the exact opposite of the desired behavior. The "usetrash" flag sets usetrash as well, but this is correct. Here are the relevant lines from fuse_options.c, in latest HDFS HEAD[0]:
> 123	  case KEY_USETRASH:
> 124	    options.usetrash = 1;
> 125	    break;
> 126	  case KEY_NOTRASH:
> 127	    options.usetrash = 1;
> 128	    break;
> This is a pretty trivial bug to fix. I'm not familiar with the process here, but I can attach a patch if needed.
> [0]: https://svn.apache.org/viewvc/hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/native/fuse-dfs/fuse_options.c?view=markup

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira