You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2020/12/17 14:34:07 UTC
[GitHub] [pulsar] zymap opened a new pull request #8987: Support create and update sink with package name
zymap opened a new pull request #8987:
URL: https://github.com/apache/pulsar/pull/8987
---
Master Issue: #8676
*Motivation*
We have a new package management service that can manage all
the sink packages. We can use that in the Pulsar Sink to manage
sink packages.
*Modifications*
- Support create and update sink with the package name
- Add test for this
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] zymap commented on pull request #8987: Support create and update sink with package name
Posted by GitBox <gi...@apache.org>.
zymap commented on pull request #8987:
URL: https://github.com/apache/pulsar/pull/8987#issuecomment-752024521
@sijie This has the same issue as #8988. Please approve this also. Thanks.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] zymap commented on pull request #8987: Support create and update sink with package name
Posted by GitBox <gi...@apache.org>.
zymap commented on pull request #8987:
URL: https://github.com/apache/pulsar/pull/8987#issuecomment-748728293
/pulsarbot run-failure-checks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] zymap commented on pull request #8987: Support create and update sink with package name
Posted by GitBox <gi...@apache.org>.
zymap commented on pull request #8987:
URL: https://github.com/apache/pulsar/pull/8987#issuecomment-748913905
@codelipenghui @jiazhai @wolfstudy @sijie Please take a look when you have time. Thanks.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] jiazhai commented on pull request #8987: Support create and update sink with package name
Posted by GitBox <gi...@apache.org>.
jiazhai commented on pull request #8987:
URL: https://github.com/apache/pulsar/pull/8987#issuecomment-748760060
/pulsarbot run-failure-checks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] sijie merged pull request #8987: Support create and update sink with package name
Posted by GitBox <gi...@apache.org>.
sijie merged pull request #8987:
URL: https://github.com/apache/pulsar/pull/8987
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] sijie commented on a change in pull request #8987: Support create and update sink with package name
Posted by GitBox <gi...@apache.org>.
sijie commented on a change in pull request #8987:
URL: https://github.com/apache/pulsar/pull/8987#discussion_r547418582
##########
File path: pulsar-functions/worker/src/main/java/org/apache/pulsar/functions/worker/rest/api/SinksImpl.java
##########
@@ -317,10 +321,14 @@ public void updateSink(final String tenant,
// validate parameters
try {
if (isNotBlank(sinkPkgUrl)) {
- try {
- componentPackageFile = FunctionCommon.extractFileFromPkgURL(sinkPkgUrl);
- } catch (Exception e) {
- throw new IllegalArgumentException(String.format("Encountered error \"%s\" when getting %s package from %s", e.getMessage(), ComponentTypeUtils.toString(componentType), sinkPkgUrl));
+ if (hasPackageTypePrefix(sinkPkgUrl)) {
+ componentPackageFile = downloadPackageFile(sinkPkgUrl);
Review comment:
Same comment in apache/pulsar#8988. Why do we need to download the package?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org