You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by "cstamas (via GitHub)" <gi...@apache.org> on 2023/02/23 14:58:26 UTC
[GitHub] [maven] cstamas opened a new pull request, #1012: [MNG-7706] Deprecate 'localRepository' parameter expression (#1009)
cstamas opened a new pull request, #1012:
URL: https://github.com/apache/maven/pull/1012
This PR deprecates the 'localRepository' mojo parameter expression, and Core will emit warning if used by any Mojo.
---
https://issues.apache.org/jira/browse/MNG-7706
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven] cstamas commented on pull request #1012: [MNG-7706] Deprecate 'localRepository' parameter expression (#1009)
Posted by "cstamas (via GitHub)" <gi...@apache.org>.
cstamas commented on PR #1012:
URL: https://github.com/apache/maven/pull/1012#issuecomment-1525882346
1. drop `localRepository`, remove `buildingRequest.setLocalRepository(localRepository);`
2. instead grab RepositorySystemSession "${repositorySystemSession}"
3. on ProjectBuildingRequest setSession from 2 and remove dropped setter from 1
4. test it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven] basil commented on pull request #1012: [MNG-7706] Deprecate 'localRepository' parameter expression (#1009)
Posted by "basil (via GitHub)" <gi...@apache.org>.
basil commented on PR #1012:
URL: https://github.com/apache/maven/pull/1012#issuecomment-1525919109
This migration was poorly documented. What you asked me to do had nothing to do with the instructions in the deprecation warning. I think it was appropriate to complain about that in this PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven] basil commented on pull request #1012: [MNG-7706] Deprecate 'localRepository' parameter expression (#1009)
Posted by "basil (via GitHub)" <gi...@apache.org>.
basil commented on PR #1012:
URL: https://github.com/apache/maven/pull/1012#issuecomment-1525828731
How should https://github.com/cloudbees/maven-license-plugin/blob/b58872cc1f4062ec01ca903d9a5546cc3b85a748/src/main/java/com/cloudbees/maven/license/ProcessMojo.java#L179 be adapted? The deprecation notice says to switch to `repositorySystemSession.getLocalRepository()`, but that does not compile:
> java: incompatible types: `org.eclipse.aether.repository.LocalRepository` cannot be converted to `org.apache.maven.artifact.repository.ArtifactRepository`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven] basil commented on pull request #1012: [MNG-7706] Deprecate 'localRepository' parameter expression (#1009)
Posted by "basil (via GitHub)" <gi...@apache.org>.
basil commented on PR #1012:
URL: https://github.com/apache/maven/pull/1012#issuecomment-1525911551
> on `ProjectBuildingRequest` `setSession` from 2
The `setSession` method does not exist, but a `setRepositorySession` exists. But why should I call that when `session.getProjectBuildingRequest()` already calls it a few lines above?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven] paulwwisl commented on pull request #1012: [MNG-7706] Deprecate 'localRepository' parameter expression (#1009)
Posted by "paulwwisl (via GitHub)" <gi...@apache.org>.
paulwwisl commented on PR #1012:
URL: https://github.com/apache/maven/pull/1012#issuecomment-1509091252
solved with latest 3.0.0 https://maven.apache.org/surefire/maven-surefire-plugin/
e.g. with Spring Boot
```xml
<maven-surefire-plugin.version>3.0.0</maven-surefire-plugin.version>
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven] cstamas merged pull request #1012: [MNG-7706] Deprecate 'localRepository' parameter expression (#1009)
Posted by "cstamas (via GitHub)" <gi...@apache.org>.
cstamas merged PR #1012:
URL: https://github.com/apache/maven/pull/1012
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven] cstamas commented on pull request #1012: [MNG-7706] Deprecate 'localRepository' parameter expression (#1009)
Posted by "cstamas (via GitHub)" <gi...@apache.org>.
cstamas commented on PR #1012:
URL: https://github.com/apache/maven/pull/1012#issuecomment-1525915360
Yup, setRepositorySession... if you are sure it is there, then not needed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven] cstamas commented on pull request #1012: [MNG-7706] Deprecate 'localRepository' parameter expression (#1009)
Posted by "cstamas (via GitHub)" <gi...@apache.org>.
cstamas commented on PR #1012:
URL: https://github.com/apache/maven/pull/1012#issuecomment-1525916444
Just for future: please use ML for asks like this one :)
https://maven.apache.org/mailing-lists.html
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven] paulwwisl commented on pull request #1012: [MNG-7706] Deprecate 'localRepository' parameter expression (#1009)
Posted by "paulwwisl (via GitHub)" <gi...@apache.org>.
paulwwisl commented on PR #1012:
URL: https://github.com/apache/maven/pull/1012#issuecomment-1508963129
Does this has to do with warning for test phase, when actually there are no tests at all?
mvn version 3.9.1
```
[INFO] --- surefire:2.22.2:test (default-test) @ ..... ---
[WARNING] Parameter 'localRepository' is deprecated core expression; Avoid use of ArtifactRepository type. If you need access to local repository, switch to '${repositorySystemSession}' expression and get LRM from it instead.
[INFO] No tests to run.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org