You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@falcon.apache.org by so...@apache.org on 2016/05/05 22:55:50 UTC

falcon git commit: FALCON-1932 Extension CLI should support common options

Repository: falcon
Updated Branches:
  refs/heads/master a83a141d6 -> 44c10981e


FALCON-1932 Extension CLI should support common options

Tested CLI command with common options.

Author: yzheng-hortonworks <yz...@hortonworks.com>

Reviewers: "Balu Vellanki <ba...@apache.org>, Sowmya Ramesh <so...@apache.org>"

Closes #124 from yzheng-hortonworks/FALCON-1932


Project: http://git-wip-us.apache.org/repos/asf/falcon/repo
Commit: http://git-wip-us.apache.org/repos/asf/falcon/commit/44c10981
Tree: http://git-wip-us.apache.org/repos/asf/falcon/tree/44c10981
Diff: http://git-wip-us.apache.org/repos/asf/falcon/diff/44c10981

Branch: refs/heads/master
Commit: 44c10981e6d448855156802e36a4c8bdad56d469
Parents: a83a141
Author: yzheng-hortonworks <yz...@hortonworks.com>
Authored: Thu May 5 15:55:41 2016 -0700
Committer: Sowmya Ramesh <sr...@hortonworks.com>
Committed: Thu May 5 15:55:41 2016 -0700

----------------------------------------------------------------------
 .../main/java/org/apache/falcon/cli/FalconExtensionCLI.java | 9 +++++++--
 1 file changed, 7 insertions(+), 2 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/falcon/blob/44c10981/cli/src/main/java/org/apache/falcon/cli/FalconExtensionCLI.java
----------------------------------------------------------------------
diff --git a/cli/src/main/java/org/apache/falcon/cli/FalconExtensionCLI.java b/cli/src/main/java/org/apache/falcon/cli/FalconExtensionCLI.java
index 6496106..ecab5f7 100644
--- a/cli/src/main/java/org/apache/falcon/cli/FalconExtensionCLI.java
+++ b/cli/src/main/java/org/apache/falcon/cli/FalconExtensionCLI.java
@@ -167,6 +167,10 @@ public class FalconExtensionCLI {
         group.addOption(delete);
         extensionOptions.addOptionGroup(group);
 
+        Option url = new Option(FalconCLIConstants.URL_OPTION, true, "Falcon URL");
+        Option doAs = new Option(FalconCLIConstants.DO_AS_OPT, true, "doAs user");
+        Option debug = new Option(FalconCLIConstants.DEBUG_OPTION, false,
+                "Use debug mode to see debugging statements on stdout");
         Option extensionName = new Option(ENTENSION_NAME_OPT, true, "Extension name");
         Option jobName = new Option(JOB_NAME_OPT, true, "Extension job name");
         Option instanceStatus = new Option(FalconCLIConstants.INSTANCE_STATUS_OPT, true, "Instance status");
@@ -175,13 +179,15 @@ public class FalconExtensionCLI {
         Option numResults = new Option(FalconCLIConstants.NUM_RESULTS_OPT, true,
                 "Number of results to return per request");
         Option fields = new Option(FalconCLIConstants.FIELDS_OPT, true, "Entity fields to show for a request");
-        Option doAs = new Option(FalconCLIConstants.DO_AS_OPT, true, "doAs user");
         Option start = new Option(FalconCLIConstants.START_OPT, true, "Start time of instances");
         Option end = new Option(FalconCLIConstants.END_OPT, true, "End time of instances");
         Option status = new Option(FalconCLIConstants.STATUS_OPT, true, "Filter returned instances by status");
         Option orderBy = new Option(FalconCLIConstants.ORDER_BY_OPT, true, "Order returned instances by this field");
         Option filePath = new Option(FalconCLIConstants.FILE_PATH_OPT, true, "File path of extension parameters");
 
+        extensionOptions.addOption(url);
+        extensionOptions.addOption(doAs);
+        extensionOptions.addOption(debug);
         extensionOptions.addOption(extensionName);
         extensionOptions.addOption(jobName);
         extensionOptions.addOption(instanceStatus);
@@ -189,7 +195,6 @@ public class FalconExtensionCLI {
         extensionOptions.addOption(offset);
         extensionOptions.addOption(numResults);
         extensionOptions.addOption(fields);
-        extensionOptions.addOption(doAs);
         extensionOptions.addOption(start);
         extensionOptions.addOption(end);
         extensionOptions.addOption(status);