You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by aditivin <gi...@git.apache.org> on 2016/08/03 15:50:27 UTC

[GitHub] flink pull request #2331: [FLINK-4282] [streaming] Added an offset parameter...

GitHub user aditivin opened a pull request:

    https://github.com/apache/flink/pull/2331

    [FLINK-4282] [streaming] Added an offset parameter for processing time window ass\u2026

    Added offset parameter for the processing time window assigners:
    - ProcessingTimeSessionWindows
    - SlidingProcessingTimeWindows
    - TumblingProcessingTimeWindows
    
    The offset is an optional parameter that can be added while creating these classes, and it can be supplied as a long value or a TimeZone.
    
    Test cases for the change are present in WindowAssignerOffsetTest. There are tests for positive, negative and TimeZone offsets for each of the classes.
    
    All Travis CI jobs passed.
    
    I haven't done it for the event time window assigners yet - I can add that if this is all right.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/aditivin/flink FLINK-4282

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/flink/pull/2331.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2331
    
----
commit 6b57c17a7b207b9e862d14afcc7c890377113d77
Author: zentol <ch...@apache.org>
Date:   2016-07-22T15:50:10Z

    [FLINK-4282] Added an offset parameter for processing time window assigners

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] flink issue #2331: [FLINK-4282] [streaming] Added an offset parameter for pr...

Posted by aljoscha <gi...@git.apache.org>.
Github user aljoscha commented on the issue:

    https://github.com/apache/flink/pull/2331
  
    Your commit contains a lot of unrelated changes. This is probably caused by the fact that your changes are not rebased on top of the current master branch. Could you please do that.



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] flink pull request #2331: [FLINK-4282] [streaming] Added an offset parameter...

Posted by aditivin <gi...@git.apache.org>.
Github user aditivin closed the pull request at:

    https://github.com/apache/flink/pull/2331


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---