You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by "wulangcode (via GitHub)" <gi...@apache.org> on 2023/03/03 16:48:54 UTC
[GitHub] [skywalking-java] wulangcode opened a new pull request, #468: Fix clickhouse0.3.2 plugin executeBatch method
wulangcode opened a new pull request, #468:
URL: https://github.com/apache/skywalking-java/pull/468
The executeBatch method of the current plugin does not record sql
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-java] wu-sheng commented on pull request #468: Fix clickhouse0.3.2 plugin executeBatch method
Posted by "wu-sheng (via GitHub)" <gi...@apache.org>.
wu-sheng commented on PR #468:
URL: https://github.com/apache/skywalking-java/pull/468#issuecomment-1454359244
It could be very huge, 1000+ statements are common. Usually, we don't recommend tracing all SQLs.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-java] wu-sheng commented on pull request #468: Fix clickhouse0.3.2 plugin executeBatch method
Posted by "wu-sheng (via GitHub)" <gi...@apache.org>.
wu-sheng commented on PR #468:
URL: https://github.com/apache/skywalking-java/pull/468#issuecomment-1454256137
Batch SQLs? It should be a long SQL list.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-java] wulangcode commented on pull request #468: Fix clickhouse0.3.2 plugin executeBatch method
Posted by "wulangcode (via GitHub)" <gi...@apache.org>.
wulangcode commented on PR #468:
URL: https://github.com/apache/skywalking-java/pull/468#issuecomment-1454290944
> Batch SQLs? It should be a long SQL list.
Shouldn't Batch SQLs be logged? Or to limit the length?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-java] wulangcode closed pull request #468: Fix clickhouse0.3.2 plugin executeBatch method
Posted by "wulangcode (via GitHub)" <gi...@apache.org>.
wulangcode closed pull request #468: Fix clickhouse0.3.2 plugin executeBatch method
URL: https://github.com/apache/skywalking-java/pull/468
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org