You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by GitBox <gi...@apache.org> on 2020/10/26 13:52:21 UTC
[GitHub] [incubator-doris] xinghuayu007 opened a new pull request #4796: [BUG] Catch retry submit exception
xinghuayu007 opened a new pull request #4796:
URL: https://github.com/apache/incubator-doris/pull/4796
## Proposed changes
When `Load Job Task Queue` is filled, continue to submit more jobs to the queue will cause `RejectedExecutionException`. But `callback.onTaskFailed` function does not catch the exception, that will cause re-submitting job failed, and status is not updated to failed.
issue: #4795
## Types of changes
What types of changes does your code introduce to Doris?
_Put an `x` in the boxes that apply_
- [x] Bugfix (non-breaking change which fixes an issue)
- [] New feature (non-breaking change which adds functionality)
- [] Breaking change (fix or feature that would cause existing functionality to not work as expected)
- [] Documentation Update (if none of the other choices apply)
- [] Code refactor (Modify the code structure, format the code, etc...)
## Checklist
_Put an `x` in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code._
- [x] I have create an issue on (Fix #ISSUE), and have described the bug/feature there in detail
- [x] Compiling and unit tests pass locally with my changes
- [x] I have added tests that prove my fix is effective or that my feature works
- [x] If this change need a document change, I have updated the document
- [x] Any dependent changes have been merged
## Further comments
If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] xinghuayu007 commented on a change in pull request #4796: [BUG] Catch retry submit exception
Posted by GitBox <gi...@apache.org>.
xinghuayu007 commented on a change in pull request #4796:
URL: https://github.com/apache/incubator-doris/pull/4796#discussion_r512420821
##########
File path: fe/fe-core/src/main/java/org/apache/doris/load/loadv2/BulkLoadJob.java
##########
@@ -233,7 +233,32 @@ public void onTaskFailed(long taskId, FailMsg failMsg) {
loadTask.updateRetryInfo();
idToTasks.put(loadTask.getSignature(), loadTask);
// load id will be added to loadStatistic when executing this task
- Catalog.getCurrentCatalog().getLoadTaskScheduler().submit(loadTask);
+ boolean retrySuccessFlag = false;
+ while (loadTask.getRetryTime() > 0) {
+ try {
+ Catalog.getCurrentCatalog().getLoadTaskScheduler().submit(loadTask);
+ retrySuccessFlag = true;
+ break;
+ } catch (Exception e) {
+ try {
+ Thread.sleep(100);
+ } catch (InterruptedException ex) {
+ LOG.warn("retry sublit task sleep failed. task_id:{}", id);
+ }
+ // retry task
Review comment:
ＯＫ，Ｉmodified it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] kangkaisen commented on a change in pull request #4796: [BUG] Catch retry submit exception
Posted by GitBox <gi...@apache.org>.
kangkaisen commented on a change in pull request #4796:
URL: https://github.com/apache/incubator-doris/pull/4796#discussion_r512373415
##########
File path: fe/fe-core/src/main/java/org/apache/doris/load/loadv2/BulkLoadJob.java
##########
@@ -233,7 +233,32 @@ public void onTaskFailed(long taskId, FailMsg failMsg) {
loadTask.updateRetryInfo();
idToTasks.put(loadTask.getSignature(), loadTask);
// load id will be added to loadStatistic when executing this task
- Catalog.getCurrentCatalog().getLoadTaskScheduler().submit(loadTask);
+ boolean retrySuccessFlag = false;
+ while (loadTask.getRetryTime() > 0) {
+ try {
+ Catalog.getCurrentCatalog().getLoadTaskScheduler().submit(loadTask);
+ retrySuccessFlag = true;
+ break;
+ } catch (Exception e) {
+ try {
+ Thread.sleep(100);
+ } catch (InterruptedException ex) {
+ LOG.warn("retry sublit task sleep failed. task_id:{}", id);
+ }
+ // retry task
Review comment:
The code is redundant:
```
idToTasks.remove(loadTask.getSignature());
if (loadTask instanceof LoadLoadingTask) {
loadStatistic.removeLoad(((LoadLoadingTask) loadTask).getLoadId());
}
loadTask.updateRetryInfo();
idToTasks.put(loadTask.getSignature(), loadTask);
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] xinghuayu007 commented on a change in pull request #4796: [BUG] Catch retry submit exception
Posted by GitBox <gi...@apache.org>.
xinghuayu007 commented on a change in pull request #4796:
URL: https://github.com/apache/incubator-doris/pull/4796#discussion_r513164269
##########
File path: fe/fe-core/src/main/java/org/apache/doris/load/loadv2/BulkLoadJob.java
##########
@@ -233,7 +233,32 @@ public void onTaskFailed(long taskId, FailMsg failMsg) {
loadTask.updateRetryInfo();
idToTasks.put(loadTask.getSignature(), loadTask);
// load id will be added to loadStatistic when executing this task
- Catalog.getCurrentCatalog().getLoadTaskScheduler().submit(loadTask);
+ boolean retrySuccessFlag = false;
+ while (loadTask.getRetryTime() > 0) {
+ try {
+ Catalog.getCurrentCatalog().getLoadTaskScheduler().submit(loadTask);
+ retrySuccessFlag = true;
+ break;
+ } catch (Exception e) {
+ try {
+ Thread.sleep(100);
+ } catch (InterruptedException ex) {
+ LOG.warn("retry sublit task sleep failed. task_id:{}", id);
+ }
+ // retry task
Review comment:
> The code is redundant:
>
> ```
> idToTasks.remove(loadTask.getSignature());
> if (loadTask instanceof LoadLoadingTask) {
> loadStatistic.removeLoad(((LoadLoadingTask) loadTask).getLoadId());
> }
> loadTask.updateRetryInfo();
> idToTasks.put(loadTask.getSignature(), loadTask);
> ```
Maybe, it is better to catch the exception in `fe-core/src/main/java/org/apache/doris/task/MasterTaskExecutor.java#submit` and return false. But currently, too many calls refer this function, may need too much modfication.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] morningman merged pull request #4796: [BUG] Catch retry submit exception
Posted by GitBox <gi...@apache.org>.
morningman merged pull request #4796:
URL: https://github.com/apache/incubator-doris/pull/4796
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org