You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "LuciferYang (via GitHub)" <gi...@apache.org> on 2024/08/29 05:32:04 UTC
[PR] [SPARK-49455][SQL][TESTS] Refactor `StagingInMemoryTableCatalog` to override the non-deprecated functions [spark]
LuciferYang opened a new pull request, #47924:
URL: https://github.com/apache/spark/pull/47924
### What changes were proposed in this pull request?
This PR refactors `StagingInMemoryTableCatalog` by overriding the following three methods to replace the three deprecated methods with the same names:
- `stageCreate(Identifier, StructType, Transform[], Map)` -> `stageCreate(Identifier, Column[], Transform[], Map)`
- `stageReplace(Identifier, StructType, Transform[], Map)` -> `stageReplace(Identifier, Column[], Transform[], Map)`
- `stageCreateOrReplace(Identifier, StructType, Transform[], Map)` -> `stageCreateOrReplace(Identifier, Column[], Transform[], Map)`
### Why are the changes needed?
Clean up the usage of deprecated APIs within Spark
### Does this PR introduce _any_ user-facing change?
No, just internal test code
### How was this patch tested?
Pass GitHub Actions
### Was this patch authored or co-authored using generative AI tooling?
No
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-49455][SQL][TESTS] Refactor `StagingInMemoryTableCatalog` to override the non-deprecated functions [spark]
Posted by "LuciferYang (via GitHub)" <gi...@apache.org>.
LuciferYang closed pull request #47924: [SPARK-49455][SQL][TESTS] Refactor `StagingInMemoryTableCatalog` to override the non-deprecated functions
URL: https://github.com/apache/spark/pull/47924
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-49455][SQL][TESTS] Refactor `StagingInMemoryTableCatalog` to override the non-deprecated functions [spark]
Posted by "LuciferYang (via GitHub)" <gi...@apache.org>.
LuciferYang commented on PR #47924:
URL: https://github.com/apache/spark/pull/47924#issuecomment-2323741535
Thanks @yaooqinn
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-49455][SQL][TESTS] Refactor `StagingInMemoryTableCatalog` to override the non-deprecated functions [spark]
Posted by "LuciferYang (via GitHub)" <gi...@apache.org>.
LuciferYang commented on PR #47924:
URL: https://github.com/apache/spark/pull/47924#issuecomment-2323862483
Merged into master. Thanks @yaooqinn again
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org