You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Qian Zhang <zh...@gmail.com> on 2018/03/06 07:36:43 UTC
Review Request 65917: Added a test
`TaskValidationTest.TaskMissingDockerInfo`.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65917/
-----------------------------------------------------------
Review request for mesos and Gilbert Song.
Bugs: MESOS-8640
https://issues.apache.org/jira/browse/MESOS-8640
Repository: mesos
Description
-------
Added a test `TaskValidationTest.TaskMissingDockerInfo`.
Diffs
-----
src/tests/master_validation_tests.cpp 77ec7fb37c9b9c168013d1d81ca862617682af6d
Diff: https://reviews.apache.org/r/65917/diff/1/
Testing
-------
sudo make check
Thanks,
Qian Zhang
Re: Review Request 65917: Added a test
`TaskValidationTest.TaskMissingDockerInfo`.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65917/#review198682
-----------------------------------------------------------
PASS: Mesos patch 65917 was successfully built and tested.
Reviews applied: `['65915', '65916', '65917']`
All the build artifacts available at: http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/65917
- Mesos Reviewbot Windows
On March 6, 2018, 7:36 a.m., Qian Zhang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65917/
> -----------------------------------------------------------
>
> (Updated March 6, 2018, 7:36 a.m.)
>
>
> Review request for mesos and Gilbert Song.
>
>
> Bugs: MESOS-8640
> https://issues.apache.org/jira/browse/MESOS-8640
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added a test `TaskValidationTest.TaskMissingDockerInfo`.
>
>
> Diffs
> -----
>
> src/tests/master_validation_tests.cpp 77ec7fb37c9b9c168013d1d81ca862617682af6d
>
>
> Diff: https://reviews.apache.org/r/65917/diff/1/
>
>
> Testing
> -------
>
> sudo make check
>
>
> Thanks,
>
> Qian Zhang
>
>
Re: Review Request 65917: Added a test
`TaskValidationTest.TaskMissingDockerInfo`.
Posted by Gilbert Song <so...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65917/#review199059
-----------------------------------------------------------
Ship it!
Ship It!
- Gilbert Song
On March 5, 2018, 11:36 p.m., Qian Zhang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65917/
> -----------------------------------------------------------
>
> (Updated March 5, 2018, 11:36 p.m.)
>
>
> Review request for mesos and Gilbert Song.
>
>
> Bugs: MESOS-8640
> https://issues.apache.org/jira/browse/MESOS-8640
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added a test `TaskValidationTest.TaskMissingDockerInfo`.
>
>
> Diffs
> -----
>
> src/tests/master_validation_tests.cpp 77ec7fb37c9b9c168013d1d81ca862617682af6d
>
>
> Diff: https://reviews.apache.org/r/65917/diff/1/
>
>
> Testing
> -------
>
> sudo make check
>
>
> Thanks,
>
> Qian Zhang
>
>
Re: Review Request 65917: Added a test
`TaskValidationTest.TaskMissingDockerInfo`.
Posted by Mesos Reviewbot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65917/#review198683
-----------------------------------------------------------
Patch looks great!
Reviews applied: [65915, 65916, 65917]
Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose --disable-libtool-wrappers' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh
- Mesos Reviewbot
On March 6, 2018, 3:36 p.m., Qian Zhang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65917/
> -----------------------------------------------------------
>
> (Updated March 6, 2018, 3:36 p.m.)
>
>
> Review request for mesos and Gilbert Song.
>
>
> Bugs: MESOS-8640
> https://issues.apache.org/jira/browse/MESOS-8640
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added a test `TaskValidationTest.TaskMissingDockerInfo`.
>
>
> Diffs
> -----
>
> src/tests/master_validation_tests.cpp 77ec7fb37c9b9c168013d1d81ca862617682af6d
>
>
> Diff: https://reviews.apache.org/r/65917/diff/1/
>
>
> Testing
> -------
>
> sudo make check
>
>
> Thanks,
>
> Qian Zhang
>
>