You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2020/11/23 21:41:34 UTC
[GitHub] [spark] imback82 opened a new pull request #30475: [SPARK-33522][SQL] Improve exception messages while handling UnresolvedTable
imback82 opened a new pull request #30475:
URL: https://github.com/apache/spark/pull/30475
<!--
Thanks for sending a pull request! Here are some tips for you:
1. If this is your first time, please read our contributor guidelines: https://spark.apache.org/contributing.html
2. Ensure you have added or run the appropriate tests for your PR: https://spark.apache.org/developer-tools.html
3. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP][SPARK-XXXX] Your PR title ...'.
4. Be sure to keep the PR description updated to reflect all changes.
5. Please write your PR title to summarize what this PR proposes.
6. If possible, provide a concise example to reproduce the issue for a faster review.
7. If you want to add a new configuration, please read the guideline first for naming configurations in
'core/src/main/scala/org/apache/spark/internal/config/ConfigEntry.scala'.
-->
### What changes were proposed in this pull request?
<!--
Please clarify what changes you are proposing. The purpose of this section is to outline the changes and how this PR fixes the issue.
If possible, please consider writing useful notes for better and faster reviews in your PR. See the examples below.
1. If you refactor some codes with changing classes, showing the class hierarchy will help reviewers.
2. If you fix some SQL features, you can provide some references of other DBMSes.
3. If there is design documentation, please add the link.
4. If there is a discussion in the mailing list, please add the link.
-->
This PR proposes to improve the exception messages while `UnresolvedTableOrView` is handled based on this suggestion: https://github.com/apache/spark/pull/30321#discussion_r521127001.
Currently, when an identifier is resolved to a temp view when a table/permanent view is expected, the following exception message is displayed (e.g., for `SHOW CREATE TABLE`):
```
t is a temp view not table or permanent view.
```
After this PR, the message will be:
```
t is a temp view. 'SHOW CREATE TABLE' expects a table or permanent view.
```
Also, if an identifier is not resolved, the following exception message is currently used:
```
Table or view not found: t
```
After this PR, the message will be:
```
Table or permanent view not found for 'SHOW CREATE TABLE': t
```
### Why are the changes needed?
<!--
Please clarify why the changes are needed. For instance,
1. If you propose a new API, clarify the use case for a new API.
2. If you fix a bug, you can clarify why it is a bug.
-->
To improve the exception message.
### Does this PR introduce _any_ user-facing change?
<!--
Note that it means *any* user-facing change including all aspects such as the documentation fix.
If yes, please clarify the previous behavior and the change this PR proposes - provide the console output, description and/or an example to show the behavior difference if possible.
If possible, please also clarify if this is a user-facing change compared to the released Spark versions or within the unreleased branches such as master.
If no, write 'No'.
-->
Yes, the exception message will be changed as described above.
### How was this patch tested?
<!--
If tests were added, say they were added here. Please make sure to add some test cases that check the changes thoroughly including negative and positive cases if possible.
If it was tested in a way different from regular unit tests, please clarify how you tested step by step, ideally copy and paste-able, so that other reviewers can test and check, and descendants can verify in the future.
If tests were not added, please describe why they were not added and/or why it was difficult to add.
-->
Updated existing tests.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] imback82 commented on pull request #30475: [SPARK-33522][SQL] Improve exception messages while handling UnresolvedTableOrView
Posted by GitBox <gi...@apache.org>.
imback82 commented on pull request #30475:
URL: https://github.com/apache/spark/pull/30475#issuecomment-733505521
retest this please
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #30475: [SPARK-33522][SQL] Improve exception messages while handling UnresolvedTable
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #30475:
URL: https://github.com/apache/spark/pull/30475#issuecomment-732472346
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #30475: [SPARK-33522][SQL] Improve exception messages while handling UnresolvedTable
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30475:
URL: https://github.com/apache/spark/pull/30475#issuecomment-732443410
**[Test build #131574 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/131574/testReport)** for PR 30475 at commit [`fd2eb37`](https://github.com/apache/spark/commit/fd2eb372642c55c4823702536c76bfd03fd1f208).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #30475: [SPARK-33522][SQL] Improve exception messages while handling UnresolvedTable
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #30475:
URL: https://github.com/apache/spark/pull/30475#issuecomment-732480437
Merged build finished. Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan commented on a change in pull request #30475: [SPARK-33522][SQL] Improve exception messages while handling UnresolvedTableOrView
Posted by GitBox <gi...@apache.org>.
cloud-fan commented on a change in pull request #30475:
URL: https://github.com/apache/spark/pull/30475#discussion_r529219203
##########
File path: sql/core/src/test/scala/org/apache/spark/sql/connector/DataSourceV2SQLSuite.scala
##########
@@ -729,7 +729,7 @@ class DataSourceV2SQLSuite
val ex = intercept[AnalysisException] {
sql("DROP TABLE testcat.db.notbl")
}
- assert(ex.getMessage.contains("Table or view not found: testcat.db.notbl"))
+ assert(ex.getMessage.contains("Table or view not found for 'DROP TABLE': testcat.db.notbl"))
Review comment:
Sorry I don't get it. In this case, `testcat.db.notbl` is not a permanent view, but a non-existing relation.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan closed pull request #30475: [SPARK-33522][SQL] Improve exception messages while handling UnresolvedTableOrView
Posted by GitBox <gi...@apache.org>.
cloud-fan closed pull request #30475:
URL: https://github.com/apache/spark/pull/30475
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #30475: [SPARK-33522][SQL] Improve exception messages while handling UnresolvedTableOrView
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #30475:
URL: https://github.com/apache/spark/pull/30475#issuecomment-734000687
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] imback82 commented on a change in pull request #30475: [SPARK-33522][SQL] Improve exception messages while handling UnresolvedTableOrView
Posted by GitBox <gi...@apache.org>.
imback82 commented on a change in pull request #30475:
URL: https://github.com/apache/spark/pull/30475#discussion_r529744265
##########
File path: sql/core/src/test/scala/org/apache/spark/sql/connector/DataSourceV2SQLSuite.scala
##########
@@ -729,7 +729,7 @@ class DataSourceV2SQLSuite
val ex = intercept[AnalysisException] {
sql("DROP TABLE testcat.db.notbl")
}
- assert(ex.getMessage.contains("Table or view not found: testcat.db.notbl"))
+ assert(ex.getMessage.contains("Table or view not found for 'DROP TABLE': testcat.db.notbl"))
Review comment:
v2 `DROP TABLE` only handles `ResolvedTable`. If it's resolved to a view, it will be handled in `ResolveSessionCatalog` and tested here:
https://github.com/apache/spark/blob/fdd6c73b3cfac5af30c789c7f70b92367a79f7e7/sql/hive/src/test/scala/org/apache/spark/sql/hive/execution/HiveDDLSuite.scala#L1056-L1070
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #30475: [SPARK-33522][SQL] Improve exception messages while handling UnresolvedTableOrView
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30475:
URL: https://github.com/apache/spark/pull/30475#issuecomment-733964777
**[Test build #131808 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/131808/testReport)** for PR 30475 at commit [`147c654`](https://github.com/apache/spark/commit/147c654408749db637825462f7324ce4629f93b6).
* This patch **fails Spark unit tests**.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] imback82 commented on a change in pull request #30475: [SPARK-33522][SQL] Improve exception messages while handling UnresolvedTable
Posted by GitBox <gi...@apache.org>.
imback82 commented on a change in pull request #30475:
URL: https://github.com/apache/spark/pull/30475#discussion_r529022520
##########
File path: sql/core/src/test/scala/org/apache/spark/sql/connector/DataSourceV2SQLSuite.scala
##########
@@ -729,7 +729,7 @@ class DataSourceV2SQLSuite
val ex = intercept[AnalysisException] {
sql("DROP TABLE testcat.db.notbl")
}
- assert(ex.getMessage.contains("Table or view not found: testcat.db.notbl"))
+ assert(ex.getMessage.contains("Table or view not found for 'DROP TABLE': testcat.db.notbl"))
Review comment:
This message could be misleading since `DROP TABLE` supports table and a temporary view. To fix this, we can add `allowPermanentView` as the following and update `Analyzer` accordingly:
```scala
case class UnresolvedTableOrView(
multipartIdentifier: Seq[String],
commandName: String,
allowTempView: Boolean = true,
allowPermanentView: Boolean = true) extends LeafNode {
require(allowTempView || allowPermanentView)
override lazy val resolved: Boolean = false
override def output: Seq[Attribute] = Nil
}
```
such that the exception message can be updated to
`Table or temporary view not found for 'DROP TABLE': t`.
One downside is that if `t` is resolved to a view, the message will become:
```
t is a permanent view. 'DROP TABLE' expects a table or temporary view.
```
instead of (current message):
```
Cannot drop a view with DROP TABLE. Please use DROP VIEW instead
```
, meaning it will lose the "hint" (which we can add it to `Unresolved*` if required).
@cloud-fan WDYT? If you are OK with introducing `allowPermanentView`, I can do it as a separate PR.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #30475: [SPARK-33522][SQL] Improve exception messages while handling UnresolvedTableOrView
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #30475:
URL: https://github.com/apache/spark/pull/30475#issuecomment-733901113
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #30475: [SPARK-33522][SQL] Improve exception messages while handling UnresolvedTableOrView
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #30475:
URL: https://github.com/apache/spark/pull/30475#issuecomment-734789238
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #30475: [SPARK-33522][SQL] Improve exception messages while handling UnresolvedTableOrView
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30475:
URL: https://github.com/apache/spark/pull/30475#issuecomment-733512605
**[Test build #131748 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/131748/testReport)** for PR 30475 at commit [`68ee277`](https://github.com/apache/spark/commit/68ee277cbde9ecb466b1480af676a2f831e11236).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #30475: [SPARK-33522][SQL] Improve exception messages while handling UnresolvedTableOrView
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #30475:
URL: https://github.com/apache/spark/pull/30475#issuecomment-732789363
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #30475: [SPARK-33522][SQL] Improve exception messages while handling UnresolvedTable
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30475:
URL: https://github.com/apache/spark/pull/30475#issuecomment-732480246
**[Test build #131574 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/131574/testReport)** for PR 30475 at commit [`fd2eb37`](https://github.com/apache/spark/commit/fd2eb372642c55c4823702536c76bfd03fd1f208).
* This patch **fails Spark unit tests**.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] imback82 commented on a change in pull request #30475: [SPARK-33522][SQL] Improve exception messages while handling UnresolvedTableOrView
Posted by GitBox <gi...@apache.org>.
imback82 commented on a change in pull request #30475:
URL: https://github.com/apache/spark/pull/30475#discussion_r529260212
##########
File path: sql/core/src/test/scala/org/apache/spark/sql/connector/DataSourceV2SQLSuite.scala
##########
@@ -729,7 +729,7 @@ class DataSourceV2SQLSuite
val ex = intercept[AnalysisException] {
sql("DROP TABLE testcat.db.notbl")
}
- assert(ex.getMessage.contains("Table or view not found: testcat.db.notbl"))
+ assert(ex.getMessage.contains("Table or view not found for 'DROP TABLE': testcat.db.notbl"))
Review comment:
When I read `Table or view not found for 'DROP TABLE': t`, it sounded like `DROP TABLE` also supports permanent views.
So, I was suggesting `Table or temporary view not found for 'DROP TABLE': t` since `DROP TABLE` requires either a table or temporary view. But, I guess `Table or view not found` sounds better if we want to point out the non-existing relation.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #30475: [SPARK-33522][SQL] Improve exception messages while handling UnresolvedTableOrView
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30475:
URL: https://github.com/apache/spark/pull/30475#issuecomment-734757974
**[Test build #131878 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/131878/testReport)** for PR 30475 at commit [`46a4c4e`](https://github.com/apache/spark/commit/46a4c4e138c2d649889dced98caabab2db750096).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #30475: [SPARK-33522][SQL] Improve exception messages while handling UnresolvedTable
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30475:
URL: https://github.com/apache/spark/pull/30475#issuecomment-732501425
**[Test build #131578 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/131578/testReport)** for PR 30475 at commit [`fd2eb37`](https://github.com/apache/spark/commit/fd2eb372642c55c4823702536c76bfd03fd1f208).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #30475: [SPARK-33522][SQL] Improve exception messages while handling UnresolvedTableOrView
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #30475:
URL: https://github.com/apache/spark/pull/30475#issuecomment-734734868
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #30475: [SPARK-33522][SQL] Improve exception messages while handling UnresolvedTable
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #30475:
URL: https://github.com/apache/spark/pull/30475#issuecomment-732472346
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #30475: [SPARK-33522][SQL] Improve exception messages while handling UnresolvedTableOrView
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #30475:
URL: https://github.com/apache/spark/pull/30475#issuecomment-732641805
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan commented on a change in pull request #30475: [SPARK-33522][SQL] Improve exception messages while handling UnresolvedTableOrView
Posted by GitBox <gi...@apache.org>.
cloud-fan commented on a change in pull request #30475:
URL: https://github.com/apache/spark/pull/30475#discussion_r529296497
##########
File path: sql/core/src/test/scala/org/apache/spark/sql/connector/DataSourceV2SQLSuite.scala
##########
@@ -729,7 +729,7 @@ class DataSourceV2SQLSuite
val ex = intercept[AnalysisException] {
sql("DROP TABLE testcat.db.notbl")
}
- assert(ex.getMessage.contains("Table or view not found: testcat.db.notbl"))
+ assert(ex.getMessage.contains("Table or view not found for 'DROP TABLE': testcat.db.notbl"))
Review comment:
> since DROP TABLE requires either a table or temporary view
Do we have such a test case for v2 DROP TABLE?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #30475: [SPARK-33522][SQL] Improve exception messages while handling UnresolvedTableOrView
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #30475:
URL: https://github.com/apache/spark/pull/30475#issuecomment-734789238
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #30475: [SPARK-33522][SQL] Improve exception messages while handling UnresolvedTableOrView
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #30475:
URL: https://github.com/apache/spark/pull/30475#issuecomment-734831751
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #30475: [SPARK-33522][SQL] Improve exception messages while handling UnresolvedTableOrView
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30475:
URL: https://github.com/apache/spark/pull/30475#issuecomment-734708523
**[Test build #131872 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/131872/testReport)** for PR 30475 at commit [`46a4c4e`](https://github.com/apache/spark/commit/46a4c4e138c2d649889dced98caabab2db750096).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #30475: [SPARK-33522][SQL] Improve exception messages while handling UnresolvedTableOrView
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #30475:
URL: https://github.com/apache/spark/pull/30475#issuecomment-732789363
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #30475: [SPARK-33522][SQL] Improve exception messages while handling UnresolvedTable
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #30475:
URL: https://github.com/apache/spark/pull/30475#issuecomment-732443410
**[Test build #131574 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/131574/testReport)** for PR 30475 at commit [`fd2eb37`](https://github.com/apache/spark/commit/fd2eb372642c55c4823702536c76bfd03fd1f208).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #30475: [SPARK-33522][SQL] Improve exception messages while handling UnresolvedTableOrView
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #30475:
URL: https://github.com/apache/spark/pull/30475#issuecomment-734757974
**[Test build #131878 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/131878/testReport)** for PR 30475 at commit [`46a4c4e`](https://github.com/apache/spark/commit/46a4c4e138c2d649889dced98caabab2db750096).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #30475: [SPARK-33522][SQL] Improve exception messages while handling UnresolvedTableOrView
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #30475:
URL: https://github.com/apache/spark/pull/30475#issuecomment-732536779
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #30475: [SPARK-33522][SQL] Improve exception messages while handling UnresolvedTableOrView
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #30475:
URL: https://github.com/apache/spark/pull/30475#issuecomment-732536779
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #30475: [SPARK-33522][SQL] Improve exception messages while handling UnresolvedTableOrView
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30475:
URL: https://github.com/apache/spark/pull/30475#issuecomment-732584295
**[Test build #131609 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/131609/testReport)** for PR 30475 at commit [`b97c925`](https://github.com/apache/spark/commit/b97c9250b64aaecdbecc9df28e21f61ec76fc318).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #30475: [SPARK-33522][SQL] Improve exception messages while handling UnresolvedTableOrView
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30475:
URL: https://github.com/apache/spark/pull/30475#issuecomment-732636852
**[Test build #131609 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/131609/testReport)** for PR 30475 at commit [`b97c925`](https://github.com/apache/spark/commit/b97c9250b64aaecdbecc9df28e21f61ec76fc318).
* This patch **fails Spark unit tests**.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #30475: [SPARK-33522][SQL] Improve exception messages while handling UnresolvedTableOrView
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #30475:
URL: https://github.com/apache/spark/pull/30475#issuecomment-734831751
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #30475: [SPARK-33522][SQL] Improve exception messages while handling UnresolvedTableOrView
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #30475:
URL: https://github.com/apache/spark/pull/30475#issuecomment-733901113
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #30475: [SPARK-33522][SQL] Improve exception messages while handling UnresolvedTableOrView
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #30475:
URL: https://github.com/apache/spark/pull/30475#issuecomment-733512605
**[Test build #131748 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/131748/testReport)** for PR 30475 at commit [`68ee277`](https://github.com/apache/spark/commit/68ee277cbde9ecb466b1480af676a2f831e11236).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #30475: [SPARK-33522][SQL] Improve exception messages while handling UnresolvedTableOrView
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #30475:
URL: https://github.com/apache/spark/pull/30475#issuecomment-733972117
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #30475: [SPARK-33522][SQL] Improve exception messages while handling UnresolvedTableOrView
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #30475:
URL: https://github.com/apache/spark/pull/30475#issuecomment-733988632
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #30475: [SPARK-33522][SQL] Improve exception messages while handling UnresolvedTableOrView
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #30475:
URL: https://github.com/apache/spark/pull/30475#issuecomment-733173015
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan commented on pull request #30475: [SPARK-33522][SQL] Improve exception messages while handling UnresolvedTableOrView
Posted by GitBox <gi...@apache.org>.
cloud-fan commented on pull request #30475:
URL: https://github.com/apache/spark/pull/30475#issuecomment-734759321
GA passed, merging to master, thanks!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #30475: [SPARK-33522][SQL] Improve exception messages while handling UnresolvedTableOrView
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #30475:
URL: https://github.com/apache/spark/pull/30475#issuecomment-733922687
**[Test build #131808 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/131808/testReport)** for PR 30475 at commit [`147c654`](https://github.com/apache/spark/commit/147c654408749db637825462f7324ce4629f93b6).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #30475: [SPARK-33522][SQL] Improve exception messages while handling UnresolvedTableOrView
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #30475:
URL: https://github.com/apache/spark/pull/30475#issuecomment-732638287
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #30475: [SPARK-33522][SQL] Improve exception messages while handling UnresolvedTableOrView
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30475:
URL: https://github.com/apache/spark/pull/30475#issuecomment-733123537
**[Test build #131686 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/131686/testReport)** for PR 30475 at commit [`68ee277`](https://github.com/apache/spark/commit/68ee277cbde9ecb466b1480af676a2f831e11236).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #30475: [SPARK-33522][SQL] Improve exception messages while handling UnresolvedTableOrView
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30475:
URL: https://github.com/apache/spark/pull/30475#issuecomment-732641184
**[Test build #131578 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/131578/testReport)** for PR 30475 at commit [`fd2eb37`](https://github.com/apache/spark/commit/fd2eb372642c55c4823702536c76bfd03fd1f208).
* This patch **fails Spark unit tests**.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #30475: [SPARK-33522][SQL] Improve exception messages while handling UnresolvedTable
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #30475:
URL: https://github.com/apache/spark/pull/30475#issuecomment-732480443
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/131574/
Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #30475: [SPARK-33522][SQL] Improve exception messages while handling UnresolvedTableOrView
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30475:
URL: https://github.com/apache/spark/pull/30475#issuecomment-734831372
**[Test build #131878 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/131878/testReport)** for PR 30475 at commit [`46a4c4e`](https://github.com/apache/spark/commit/46a4c4e138c2d649889dced98caabab2db750096).
* This patch **fails Spark unit tests**.
* This patch merges cleanly.
* This patch adds the following public classes _(experimental)_:
* `case class CoalesceShufflePartitions(session: SparkSession) extends CustomShuffleReaderRule `
* `trait CustomShuffleReaderRule extends Rule[SparkPlan] `
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan commented on pull request #30475: [SPARK-33522][SQL] Improve exception messages while handling UnresolvedTableOrView
Posted by GitBox <gi...@apache.org>.
cloud-fan commented on pull request #30475:
URL: https://github.com/apache/spark/pull/30475#issuecomment-734744883
retest this please
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #30475: [SPARK-33522][SQL] Improve exception messages while handling UnresolvedTableOrView
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30475:
URL: https://github.com/apache/spark/pull/30475#issuecomment-733966841
**[Test build #131813 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/131813/testReport)** for PR 30475 at commit [`82cda10`](https://github.com/apache/spark/commit/82cda108c558d5923838fd8b0db8522c84bab6fe).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #30475: [SPARK-33522][SQL] Improve exception messages while handling UnresolvedTableOrView
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30475:
URL: https://github.com/apache/spark/pull/30475#issuecomment-733899176
**[Test build #131802 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/131802/testReport)** for PR 30475 at commit [`68ee277`](https://github.com/apache/spark/commit/68ee277cbde9ecb466b1480af676a2f831e11236).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #30475: [SPARK-33522][SQL] Improve exception messages while handling UnresolvedTableOrView
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #30475:
URL: https://github.com/apache/spark/pull/30475#issuecomment-733966630
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #30475: [SPARK-33522][SQL] Improve exception messages while handling UnresolvedTableOrView
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #30475:
URL: https://github.com/apache/spark/pull/30475#issuecomment-733123537
**[Test build #131686 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/131686/testReport)** for PR 30475 at commit [`68ee277`](https://github.com/apache/spark/commit/68ee277cbde9ecb466b1480af676a2f831e11236).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #30475: [SPARK-33522][SQL] Improve exception messages while handling UnresolvedTableOrView
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #30475:
URL: https://github.com/apache/spark/pull/30475#issuecomment-733173015
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #30475: [SPARK-33522][SQL] Improve exception messages while handling UnresolvedTableOrView
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #30475:
URL: https://github.com/apache/spark/pull/30475#issuecomment-733966841
**[Test build #131813 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/131813/testReport)** for PR 30475 at commit [`82cda10`](https://github.com/apache/spark/commit/82cda108c558d5923838fd8b0db8522c84bab6fe).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #30475: [SPARK-33522][SQL] Improve exception messages while handling UnresolvedTableOrView
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30475:
URL: https://github.com/apache/spark/pull/30475#issuecomment-733901098
**[Test build #131802 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/131802/testReport)** for PR 30475 at commit [`68ee277`](https://github.com/apache/spark/commit/68ee277cbde9ecb466b1480af676a2f831e11236).
* This patch **fails to build**.
* This patch merges cleanly.
* This patch adds the following public classes _(experimental)_:
* `case class TruncateTable(`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #30475: [SPARK-33522][SQL] Improve exception messages while handling UnresolvedTableOrView
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30475:
URL: https://github.com/apache/spark/pull/30475#issuecomment-733515605
**[Test build #131748 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/131748/testReport)** for PR 30475 at commit [`68ee277`](https://github.com/apache/spark/commit/68ee277cbde9ecb466b1480af676a2f831e11236).
* This patch **fails to build**.
* This patch merges cleanly.
* This patch adds the following public classes _(experimental)_:
* `case class TruncateTable(`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #30475: [SPARK-33522][SQL] Improve exception messages while handling UnresolvedTableOrView
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #30475:
URL: https://github.com/apache/spark/pull/30475#issuecomment-734739096
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #30475: [SPARK-33522][SQL] Improve exception messages while handling UnresolvedTableOrView
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #30475:
URL: https://github.com/apache/spark/pull/30475#issuecomment-734708523
**[Test build #131872 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/131872/testReport)** for PR 30475 at commit [`46a4c4e`](https://github.com/apache/spark/commit/46a4c4e138c2d649889dced98caabab2db750096).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #30475: [SPARK-33522][SQL] Improve exception messages while handling UnresolvedTable
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30475:
URL: https://github.com/apache/spark/pull/30475#issuecomment-732472332
Kubernetes integration test status success
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/36175/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #30475: [SPARK-33522][SQL] Improve exception messages while handling UnresolvedTableOrView
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #30475:
URL: https://github.com/apache/spark/pull/30475#issuecomment-732641805
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #30475: [SPARK-33522][SQL] Improve exception messages while handling UnresolvedTable
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #30475:
URL: https://github.com/apache/spark/pull/30475#issuecomment-732480437
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #30475: [SPARK-33522][SQL] Improve exception messages while handling UnresolvedTableOrView
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #30475:
URL: https://github.com/apache/spark/pull/30475#issuecomment-733515623
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #30475: [SPARK-33522][SQL] Improve exception messages while handling UnresolvedTableOrView
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #30475:
URL: https://github.com/apache/spark/pull/30475#issuecomment-733966630
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #30475: [SPARK-33522][SQL] Improve exception messages while handling UnresolvedTableOrView
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #30475:
URL: https://github.com/apache/spark/pull/30475#issuecomment-734030847
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #30475: [SPARK-33522][SQL] Improve exception messages while handling UnresolvedTableOrView
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #30475:
URL: https://github.com/apache/spark/pull/30475#issuecomment-733899176
**[Test build #131802 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/131802/testReport)** for PR 30475 at commit [`68ee277`](https://github.com/apache/spark/commit/68ee277cbde9ecb466b1480af676a2f831e11236).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #30475: [SPARK-33522][SQL] Improve exception messages while handling UnresolvedTableOrView
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30475:
URL: https://github.com/apache/spark/pull/30475#issuecomment-734023941
**[Test build #131813 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/131813/testReport)** for PR 30475 at commit [`82cda10`](https://github.com/apache/spark/commit/82cda108c558d5923838fd8b0db8522c84bab6fe).
* This patch **fails PySpark unit tests**.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #30475: [SPARK-33522][SQL] Improve exception messages while handling UnresolvedTableOrView
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #30475:
URL: https://github.com/apache/spark/pull/30475#issuecomment-732501425
**[Test build #131578 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/131578/testReport)** for PR 30475 at commit [`fd2eb37`](https://github.com/apache/spark/commit/fd2eb372642c55c4823702536c76bfd03fd1f208).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #30475: [SPARK-33522][SQL] Improve exception messages while handling UnresolvedTable
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30475:
URL: https://github.com/apache/spark/pull/30475#issuecomment-732462065
Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/36175/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #30475: [SPARK-33522][SQL] Improve exception messages while handling UnresolvedTableOrView
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #30475:
URL: https://github.com/apache/spark/pull/30475#issuecomment-733401990
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #30475: [SPARK-33522][SQL] Improve exception messages while handling UnresolvedTableOrView
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30475:
URL: https://github.com/apache/spark/pull/30475#issuecomment-733922687
**[Test build #131808 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/131808/testReport)** for PR 30475 at commit [`147c654`](https://github.com/apache/spark/commit/147c654408749db637825462f7324ce4629f93b6).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #30475: [SPARK-33522][SQL] Improve exception messages while handling UnresolvedTableOrView
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #30475:
URL: https://github.com/apache/spark/pull/30475#issuecomment-732584295
**[Test build #131609 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/131609/testReport)** for PR 30475 at commit [`b97c925`](https://github.com/apache/spark/commit/b97c9250b64aaecdbecc9df28e21f61ec76fc318).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #30475: [SPARK-33522][SQL] Improve exception messages while handling UnresolvedTableOrView
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #30475:
URL: https://github.com/apache/spark/pull/30475#issuecomment-733401990
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] imback82 commented on pull request #30475: [SPARK-33522][SQL] Improve exception messages while handling UnresolvedTableOrView
Posted by GitBox <gi...@apache.org>.
imback82 commented on pull request #30475:
URL: https://github.com/apache/spark/pull/30475#issuecomment-733881455
retest this please
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #30475: [SPARK-33522][SQL] Improve exception messages while handling UnresolvedTableOrView
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30475:
URL: https://github.com/apache/spark/pull/30475#issuecomment-733156509
**[Test build #131686 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/131686/testReport)** for PR 30475 at commit [`68ee277`](https://github.com/apache/spark/commit/68ee277cbde9ecb466b1480af676a2f831e11236).
* This patch **fails Spark unit tests**.
* This patch merges cleanly.
* This patch adds the following public classes _(experimental)_:
* `case class TruncateTable(`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #30475: [SPARK-33522][SQL] Improve exception messages while handling UnresolvedTableOrView
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30475:
URL: https://github.com/apache/spark/pull/30475#issuecomment-734734636
**[Test build #131872 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/131872/testReport)** for PR 30475 at commit [`46a4c4e`](https://github.com/apache/spark/commit/46a4c4e138c2d649889dced98caabab2db750096).
* This patch **fails Spark unit tests**.
* This patch merges cleanly.
* This patch adds the following public classes _(experimental)_:
* `case class CoalesceShufflePartitions(session: SparkSession) extends CustomShuffleReaderRule `
* `trait CustomShuffleReaderRule extends Rule[SparkPlan] `
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #30475: [SPARK-33522][SQL] Improve exception messages while handling UnresolvedTableOrView
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #30475:
URL: https://github.com/apache/spark/pull/30475#issuecomment-733645712
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #30475: [SPARK-33522][SQL] Improve exception messages while handling UnresolvedTableOrView
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #30475:
URL: https://github.com/apache/spark/pull/30475#issuecomment-732638287
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org