You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ozone.apache.org by "anuragp010 (via GitHub)" <gi...@apache.org> on 2026/10/14 15:50:47 UTC
[PR] HDDS-16041. Support picking a configurable StorageType on the DN when StorageType passed is null [ozone]
anuragp010 opened a new pull request, #11538:
URL: https://github.com/apache/ozone/pull/11538
Co-authored-by: https://github.com/xichen01
## What changes were proposed in this pull request?
`AbstractStorageTypeChoosingPolicy.chooseVolume` currently will pick a volume of any `StorageType` if the `StorageType` passed is `null`. In the scenario, where we have an older client (which doesn't have the StorageType proto fields), but latest OM, SCM, DN - A key would be created based on the default `OzoneStoragePolicy` - `WARM`. Meaning SCM would createContainer with `StorageType` as `DISK`. But this `StorageType` field would get dropped over the wire due to an older client not having these proto fields resulting in a volume being chosen regardless of the `StorageType` with which SCM has created the container. To ensure DN container creation stays consistent with the SCM, this PR ensures `AbstractStorageTypeChoosingPolicy` chooses a volume based on a default `StorageType` when the passed `StorageType` is `null`.
## What is the link to the Apache JIRA
[HDDS-16041](https://issues.apache.org/jira/browse/HDDS-16041)
## How was this patch tested?
1. Unit Tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
Re: [PR] HDDS-16041. Support picking a configurable StorageType on the DN when StorageType passed is null [ozone]
Posted by "devmadhuu (via GitHub)" <gi...@apache.org>.
devmadhuu commented on PR #11538:
URL: https://github.com/apache/ozone/pull/11538#issuecomment-6411113141
cc: @xichen01 if you would like to have a look further and advise.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
Re: [PR] HDDS-16041. Support picking a configurable StorageType on the DN when StorageType passed is null [ozone]
Posted by "anuragp010 (via GitHub)" <gi...@apache.org>.
anuragp010 commented on PR #11538:
URL: https://github.com/apache/ozone/pull/11538#issuecomment-6411604309
Thanks @devmadhuu !
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
Re: [PR] HDDS-16041. Support picking a configurable StorageType on the DN when StorageType passed is null [ozone]
Posted by "devmadhuu (via GitHub)" <gi...@apache.org>.
devmadhuu commented on PR #11538:
URL: https://github.com/apache/ozone/pull/11538#issuecomment-6193834547
@xichen01 do you have any review comments ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
Re: [PR] HDDS-16041. Support picking a configurable StorageType on the DN when StorageType passed is null [ozone]
Posted by "devmadhuu (via GitHub)" <gi...@apache.org>.
devmadhuu merged PR #11538:
URL: https://github.com/apache/ozone/pull/11538
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org