You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/01/17 05:53:23 UTC
[GitHub] [arrow-datafusion] gaojun2048 opened a new pull request #1593: Add support show tables and show columns for ballista
gaojun2048 opened a new pull request #1593:
URL: https://github.com/apache/arrow-datafusion/pull/1593
# Which issue does this PR close?
<!--
We generally require a GitHub issue to be filed for all bug fixes and enhancements and this helps us generate change logs for our releases. You can link an issue to this PR using the GitHub syntax. For example `Closes #123` indicates that this PR will close issue #123.
-->
Closes #.
# Rationale for this change
<!--
Why are you proposing this change? If this is already explained clearly in the issue then this section is not needed.
Explaining clearly why changes are proposed helps reviewers understand your changes and offer better suggestions for fixes.
-->
# What changes are included in this PR?
<!--
There is no need to duplicate the description in the issue here but it is sometimes worth providing a summary of the individual changes in this PR.
-->
# Are there any user-facing changes?
<!--
If there are user-facing changes then we may require documentation to be updated before approving the PR.
-->
<!--
If there are any breaking changes to public APIs, please add the `api change` label.
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] gaojun2048 commented on a change in pull request #1593: Add support show tables and show columns for ballista
Posted by GitBox <gi...@apache.org>.
gaojun2048 commented on a change in pull request #1593:
URL: https://github.com/apache/arrow-datafusion/pull/1593#discussion_r786473700
##########
File path: ballista/rust/client/src/context.rs
##########
@@ -256,6 +288,14 @@ impl BallistaContext {
)
};
+ let is_show = self.is_show_statement(sql).await?;
Review comment:
Datafusion supports show tables only when with_information_schema=true. Currently, users cannot specify the with_information_schema parameter of datafusion when creating a ballista context. I can add a with_information_schema parameter in BallistaConfig, the default value is false, when users need to use show tables in ballista, users can turn on this function through with_information_schema(true).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] alamb commented on a change in pull request #1593: Add support show tables and show columns for ballista
Posted by GitBox <gi...@apache.org>.
alamb commented on a change in pull request #1593:
URL: https://github.com/apache/arrow-datafusion/pull/1593#discussion_r786025309
##########
File path: ballista/rust/client/src/context.rs
##########
@@ -256,6 +288,14 @@ impl BallistaContext {
)
};
+ let is_show = self.is_show_statement(sql).await?;
Review comment:
I wonder if there is some reason not to always use the `with_information_schema`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] gaojun2048 commented on a change in pull request #1593: Add support show tables and show columns for ballista
Posted by GitBox <gi...@apache.org>.
gaojun2048 commented on a change in pull request #1593:
URL: https://github.com/apache/arrow-datafusion/pull/1593#discussion_r786473700
##########
File path: ballista/rust/client/src/context.rs
##########
@@ -256,6 +288,14 @@ impl BallistaContext {
)
};
+ let is_show = self.is_show_statement(sql).await?;
Review comment:
Datafusion supports show tables only when with_information_schema=true. Currently, users cannot specify the with_information_schema parameter of datafusion when creating a ballista context. I can add a with_information_schema parameter in BallistaConfig, the default value is false, when users need to use show tables in ballista, users can turn on this function through with_information_schema(true)
whether
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] alamb merged pull request #1593: Add support show tables and show columns for ballista
Posted by GitBox <gi...@apache.org>.
alamb merged pull request #1593:
URL: https://github.com/apache/arrow-datafusion/pull/1593
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] Ted-Jiang commented on a change in pull request #1593: Add support show tables and show columns for ballista
Posted by GitBox <gi...@apache.org>.
Ted-Jiang commented on a change in pull request #1593:
URL: https://github.com/apache/arrow-datafusion/pull/1593#discussion_r786376908
##########
File path: ballista/rust/client/src/context.rs
##########
@@ -256,6 +288,14 @@ impl BallistaContext {
)
};
+ let is_show = self.is_show_statement(sql).await?;
Review comment:
Is it ok set ` information_schema: true,` by default ? if not may i ask which situation need block this for user 😊
https://github.com/apache/arrow-datafusion/blob/82e80036d9dbcf1bacac8e94eb10d5c60a8016a7/datafusion/src/execution/context.rs#L930
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org