You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "stefankandic (via GitHub)" <gi...@apache.org> on 2024/10/30 11:53:25 UTC
Re: [PR] [SPARK-50175][SQL] Change collation precedence calculation [spark]
stefankandic commented on code in PR #48663:
URL: https://github.com/apache/spark/pull/48663#discussion_r1822460302
##########
sql/core/src/test/scala/org/apache/spark/sql/collation/CollationTypePrecedenceSuite.scala:
##########
@@ -33,6 +33,318 @@ class CollationTypePrecedenceSuite extends DatasourceV2SQLBase with AdaptiveSpar
assert(exception.getCondition === errorClass)
}
+ private def assertExplicitMismatch(df: => DataFrame): Unit =
Review Comment:
@srielau can you look at the tests to see if there is maybe something that I missed?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org