[GitHub] [lucene-solr] johtani opened a new pull request #935: LUCENE-4056: Japanese Tokenizer (Kuromoji) cannot build UniDic dictionary

[GitBox <gi...@apache.org>]

johtani opened a new pull request #935: LUCENE-4056: Japanese Tokenizer (Kuromoji) cannot build UniDic dictionary
URL: https://github.com/apache/lucene-solr/pull/935
 
 
   # Description
   
   UniDic has a bit different column and unk.def from ipadic.
   Currently if we use UniDic, then we get some error for building dictionary.
   We can build UniDic after changing build.xml. I left some comments in build.xml.
   
   If we use UniDic, we should change stoptags.txt and also add an example for part of speech filter.
   UniDic has different part of speech tags from ipadic.
   
   # Solution
   
   Added some logic for adjusting UniDic csv and unk.def.
   And also changing build.xml for downloading and building UniDic.
   
   # Tests
   
   Unfortunately there is no tests for DictionaryBuilder.
   
   # Checklist
   
   Please review the following and check all that apply:
   
   - [x] I have reviewed the guidelines for [How to Contribute](https://wiki.apache.org/solr/HowToContribute) and my code conforms to the standards described there to the best of my ability.
   - [x] I have created a Jira issue and added the issue ID to my pull request title.
   - [x] I am authorized to contribute this code to the ASF and have removed any code I do not have a license to distribute.
   - [x] I have given Solr maintainers [access](https://help.github.com/en/articles/allowing-changes-to-a-pull-request-branch-created-from-a-fork) to contribute to my PR branch. (optional but recommended)
   - [x] I have developed this patch against the `master` branch.
   - [ ] I have run `ant precommit` and the appropriate test suite.
   - [ ] I have added tests for my changes.
   - [ ] I have added documentation for the [Ref Guide](https://github.com/apache/lucene-solr/tree/master/solr/solr-ref-guide) (for Solr changes only).
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org