You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@kylin.apache.org by li...@apache.org on 2016/04/08 05:27:30 UTC

kylin git commit: minor bug fix in project L2 cache rebuilding

Repository: kylin
Updated Branches:
  refs/heads/master f23e8084f -> d6cfffa3d


minor bug fix in project L2 cache rebuilding


Project: http://git-wip-us.apache.org/repos/asf/kylin/repo
Commit: http://git-wip-us.apache.org/repos/asf/kylin/commit/d6cfffa3
Tree: http://git-wip-us.apache.org/repos/asf/kylin/tree/d6cfffa3
Diff: http://git-wip-us.apache.org/repos/asf/kylin/diff/d6cfffa3

Branch: refs/heads/master
Commit: d6cfffa3d3fba18bcf4c80a04e68539f7b5dde79
Parents: f23e808
Author: Hongbin Ma <ma...@apache.org>
Authored: Fri Apr 8 11:27:20 2016 +0800
Committer: Hongbin Ma <ma...@apache.org>
Committed: Fri Apr 8 11:27:20 2016 +0800

----------------------------------------------------------------------
 .../src/main/java/org/apache/kylin/metadata/MetadataManager.java | 4 ++++
 .../apache/kylin/rest/controller/ExternalFilterController.java   | 1 +
 .../main/java/org/apache/kylin/rest/service/CacheService.java    | 2 +-
 .../java/org/apache/kylin/rest/service/ExtFilterService.java     | 2 --
 4 files changed, 6 insertions(+), 3 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/kylin/blob/d6cfffa3/core-metadata/src/main/java/org/apache/kylin/metadata/MetadataManager.java
----------------------------------------------------------------------
diff --git a/core-metadata/src/main/java/org/apache/kylin/metadata/MetadataManager.java b/core-metadata/src/main/java/org/apache/kylin/metadata/MetadataManager.java
index d0fadd5..28402a3 100644
--- a/core-metadata/src/main/java/org/apache/kylin/metadata/MetadataManager.java
+++ b/core-metadata/src/main/java/org/apache/kylin/metadata/MetadataManager.java
@@ -353,6 +353,10 @@ public class MetadataManager {
         return t;
     }
 
+    public void reloadExtFilter(String extFilterName) throws IOException {
+        reloadExternalFilterAt(ExternalFilterDesc.concatResourcePath(extFilterName));
+    }
+
     public void reloadSourceTableExt(String tableIdentity) throws IOException {
         reloadSourceTableExdAt(TableDesc.concatExdResourcePath(tableIdentity));
     }

http://git-wip-us.apache.org/repos/asf/kylin/blob/d6cfffa3/server/src/main/java/org/apache/kylin/rest/controller/ExternalFilterController.java
----------------------------------------------------------------------
diff --git a/server/src/main/java/org/apache/kylin/rest/controller/ExternalFilterController.java b/server/src/main/java/org/apache/kylin/rest/controller/ExternalFilterController.java
index cc56059..0d41847 100644
--- a/server/src/main/java/org/apache/kylin/rest/controller/ExternalFilterController.java
+++ b/server/src/main/java/org/apache/kylin/rest/controller/ExternalFilterController.java
@@ -71,6 +71,7 @@ public class ExternalFilterController extends BasicController {
         Map<String, String> result = new HashMap();
         ExternalFilterDesc desc = JsonUtil.readValue(request.getExtFilter(), ExternalFilterDesc.class);
         extFilterService.updateExternalFilter(desc);
+        extFilterService.syncExtFilterToProject(new String[] { desc.getName() }, request.getProject());
         result.put("success", "true");
         return result;
     }

http://git-wip-us.apache.org/repos/asf/kylin/blob/d6cfffa3/server/src/main/java/org/apache/kylin/rest/service/CacheService.java
----------------------------------------------------------------------
diff --git a/server/src/main/java/org/apache/kylin/rest/service/CacheService.java b/server/src/main/java/org/apache/kylin/rest/service/CacheService.java
index 4ec2116..48afde6 100644
--- a/server/src/main/java/org/apache/kylin/rest/service/CacheService.java
+++ b/server/src/main/java/org/apache/kylin/rest/service/CacheService.java
@@ -201,7 +201,7 @@ public class CacheService extends BasicService {
                 CubeDescManager.clearCache();
                 break;
             case EXTERNAL_FILTER:
-                getMetadataManager().reloadTableCache(cacheKey);
+                getMetadataManager().reloadExtFilter(cacheKey);
                 IIDescManager.clearCache();
                 CubeDescManager.clearCache();
                 break;

http://git-wip-us.apache.org/repos/asf/kylin/blob/d6cfffa3/server/src/main/java/org/apache/kylin/rest/service/ExtFilterService.java
----------------------------------------------------------------------
diff --git a/server/src/main/java/org/apache/kylin/rest/service/ExtFilterService.java b/server/src/main/java/org/apache/kylin/rest/service/ExtFilterService.java
index 7e72d9a..576ece9 100644
--- a/server/src/main/java/org/apache/kylin/rest/service/ExtFilterService.java
+++ b/server/src/main/java/org/apache/kylin/rest/service/ExtFilterService.java
@@ -62,8 +62,6 @@ public class ExtFilterService extends BasicService {
         getMetadataManager().removeExternalFilter(name);
     }
 
-
-
     @PreAuthorize(Constant.ACCESS_HAS_ROLE_ADMIN)
     public void syncExtFilterToProject(String[] filters, String project) throws IOException {
         getProjectManager().addExtFilterToProject(filters, project);