You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/10/22 10:51:21 UTC

[GitHub] [arrow-datafusion] alamb opened a new issue, #3928: Implement serialization for `ScalarValue::FixedSizeBinary`

alamb opened a new issue, #3928:
URL: https://github.com/apache/arrow-datafusion/issues/3928

   **Is your feature request related to a problem or challenge? Please describe what you are trying to do.**
   
   @maxburke's PR added `ScalarFixedSizeBinary` support:  https://github.com/apache/arrow-datafusion/pull/3911 
   
   
   
   However, it did not implement the serialization code to send `ScalarValue::FixedSizeBinary` over the network 
   
   
   **Describe the solution you'd like**
   
   
   Fill out the code in datafusion/proto/src/to_proto.rs
   
   ```rust
               scalar::ScalarValue::FixedSizeBinary(_, _) => {
                   return Err(Error::General(
                       "FixedSizeBinary is not yet implemented".to_owned(),
                   ))
               }
   ```
   
   And add a test for round trip serialization
   
   
   **Describe alternatives you've considered**
   A clear and concise description of any alternative solutions or features you've considered.
   
   **Additional context**
   Add any other context or screenshots about the feature request here.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [arrow-datafusion] retikulum commented on issue #3928: Implement serialization for `ScalarValue::FixedSizeBinary`

Posted by GitBox <gi...@apache.org>.
retikulum commented on issue #3928:
URL: https://github.com/apache/arrow-datafusion/issues/3928#issuecomment-1288108295

   It looks interesting. Can you assign it to me?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [arrow-datafusion] alamb closed issue #3928: Implement serialization for `ScalarValue::FixedSizeBinary`

Posted by GitBox <gi...@apache.org>.
alamb closed issue #3928: Implement serialization for `ScalarValue::FixedSizeBinary`
URL: https://github.com/apache/arrow-datafusion/issues/3928


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [arrow-datafusion] alamb commented on issue #3928: Implement serialization for `ScalarValue::FixedSizeBinary`

Posted by GitBox <gi...@apache.org>.
alamb commented on issue #3928:
URL: https://github.com/apache/arrow-datafusion/issues/3928#issuecomment-1288159111

   See also- https://github.com/apache/arrow-datafusion/pull/3612 - the serialization code is a bit of a mess now but hopefully we can get it better


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [arrow-datafusion] alamb commented on issue #3928: Implement serialization for `ScalarValue::FixedSizeBinary`

Posted by GitBox <gi...@apache.org>.
alamb commented on issue #3928:
URL: https://github.com/apache/arrow-datafusion/issues/3928#issuecomment-1287759552

   Should be a good first issue as there are plenty of other examples to follow along


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org