You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@datafusion.apache.org by "ctsk (via GitHub)" <gi...@apache.org> on 2025/05/08 08:52:57 UTC
[PR] Box field to reduce DatafusionError size [datafusion]
ctsk opened a new pull request, #15990:
URL: https://github.com/apache/datafusion/pull/15990
The `field: Column` field in SchemaError::AmbiguousReference grew the size of DatafusionError from 72 bytes to 112 bytes. Putting it on the heap fixes that.
## Are there any user-facing changes?
Yes, as SchemaError is `pub` (don't know how to apply a label)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] Box field to reduce DatafusionError size [datafusion]
Posted by "comphead (via GitHub)" <gi...@apache.org>.
comphead commented on PR #15990:
URL: https://github.com/apache/datafusion/pull/15990#issuecomment-2866897984
112 bytes is still okay to be on stack?
is there any issue causing this change?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] Box field to reduce DatafusionError size [datafusion]
Posted by "ctsk (via GitHub)" <gi...@apache.org>.
ctsk commented on PR #15990:
URL: https://github.com/apache/datafusion/pull/15990#issuecomment-2867666348
That seems reasonable. Closing.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] Box field to reduce DatafusionError size [datafusion]
Posted by "ctsk (via GitHub)" <gi...@apache.org>.
ctsk closed pull request #15990: Box field to reduce DatafusionError size
URL: https://github.com/apache/datafusion/pull/15990
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] Box field to reduce DatafusionError size [datafusion]
Posted by "ctsk (via GitHub)" <gi...@apache.org>.
ctsk commented on PR #15990:
URL: https://github.com/apache/datafusion/pull/15990#issuecomment-2867591550
No, there's no particular issue motivating this change. I just think it's good practice to not have enum variants differ in size so much. In addition, `SchemaError::FieldNotFound` already boxes a field of type `Column`.
Clippy has a lint that is not quite yet triggered: [clippy::result_large_err](https://rust-lang.github.io/rust-clippy/master/#result_large_err)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] Box field to reduce DatafusionError size [datafusion]
Posted by "comphead (via GitHub)" <gi...@apache.org>.
comphead commented on PR #15990:
URL: https://github.com/apache/datafusion/pull/15990#issuecomment-2867598303
api change are pretty expensive from the user migration point of view, I'd vote to keep this as is until we get an issue justifying the change
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org