You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cloudstack.apache.org by "sureshanaparti (via GitHub)" <gi...@apache.org> on 2025/07/22 09:12:41 UTC
[PR] Config 'vm.network.nic.max.secondary.ipaddresses' - Update default value (and value if not set) to 10 as per the config description and default value in parseInt of the config [cloudstack]
sureshanaparti opened a new pull request, #11256:
URL: https://github.com/apache/cloudstack/pull/11256
### Description
This PR updates the config 'vm.network.nic.max.secondary.ipaddresses' default value (and value if not set) to 10 as per the config description (as per the last relevant commit: https://github.com/apache/cloudstack/commit/0b956bbc1f198f72ad5a60ade21e42c0e23ec15c) and default value in parseInt of the config (here: https://github.com/apache/cloudstack/commit/4925b9f6a126454215531998c461bf376ac6ab67).
<!--- Describe your changes in DETAIL - And how has behaviour functionally changed. -->
<!-- For new features, provide link to FS, dev ML discussion etc. -->
<!-- In case of bug fix, the expected and actual behaviours, steps to reproduce. -->
<!-- When "Fixes: #<id>" is specified, the issue/PR will automatically be closed when this PR gets merged -->
<!-- For addressing multiple issues/PRs, use multiple "Fixes: #<id>" -->
<!-- Fixes: # -->
<!--- ******************************************************************************* -->
<!--- NOTE: AUTOMATION USES THE DESCRIPTIONS TO SET LABELS AND PRODUCE DOCUMENTATION. -->
<!--- PLEASE PUT AN 'X' in only **ONE** box -->
<!--- ******************************************************************************* -->
### Types of changes
- [ ] Breaking change (fix or feature that would cause existing functionality to change)
- [ ] New feature (non-breaking change which adds functionality)
- [x] Bug fix (non-breaking change which fixes an issue)
- [ ] Enhancement (improves an existing feature and functionality)
- [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
- [ ] build/CI
- [ ] test (unit or integration test code)
### Feature/Enhancement Scale or Bug Severity
#### Feature/Enhancement Scale
- [ ] Major
- [ ] Minor
#### Bug Severity
- [ ] BLOCKER
- [ ] Critical
- [ ] Major
- [x] Minor
- [ ] Trivial
### Screenshots (if appropriate):
### How Has This Been Tested?
Verified the config 'vm.network.nic.max.secondary.ipaddresses' default value & value.
<!-- Please describe in detail how you tested your changes. -->
<!-- Include details of your testing environment, and the tests you ran to -->
#### How did you try to break this feature and the system with this change?
<!-- see how your change affects other areas of the code, etc. -->
<!-- Please read the [CONTRIBUTING](https://github.com/apache/cloudstack/blob/main/CONTRIBUTING.md) document -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Config 'vm.network.nic.max.secondary.ipaddresses' - Update default value (and value if not set) to 10 as per the config description and default value in parseInt of the config [cloudstack]
Posted by "sureshanaparti (via GitHub)" <gi...@apache.org>.
sureshanaparti closed pull request #11256: Config 'vm.network.nic.max.secondary.ipaddresses' - Update default value (and value if not set) to 10 as per the config description and default value in parseInt of the config
URL: https://github.com/apache/cloudstack/pull/11256
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Config 'vm.network.nic.max.secondary.ipaddresses' - Update default value (and value if not set) to 10 as per the config description and default value in parseInt of the config [cloudstack]
Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #11256:
URL: https://github.com/apache/cloudstack/pull/11256#issuecomment-3101831669
## [Codecov](https://app.codecov.io/gh/apache/cloudstack/pull/11256?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
All modified and coverable lines are covered by tests :white_check_mark:
> Project coverage is 4.00%. Comparing base [(`23de6c7`)](https://app.codecov.io/gh/apache/cloudstack/commit/23de6c7db4db4f63c95b9f7a95aae1576cc0b583?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) to head [(`07edabe`)](https://app.codecov.io/gh/apache/cloudstack/commit/07edabe35728c8f89d860ea13fd87ea1d8fbe21a?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
> :exclamation: There is a different number of reports uploaded between BASE (23de6c7) and HEAD (07edabe). Click for more details.
>
> <details><summary>HEAD has 1 upload less than BASE</summary>
>
>| Flag | BASE (23de6c7) | HEAD (07edabe) |
>|------|------|------|
>|unittests|1|0|
></details>
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## 4.20 #11256 +/- ##
=============================================
- Coverage 16.16% 4.00% -12.17%
=============================================
Files 5656 402 -5254
Lines 497791 32612 -465179
Branches 60365 5791 -54574
=============================================
- Hits 80456 1305 -79151
+ Misses 408381 31158 -377223
+ Partials 8954 149 -8805
```
| [Flag](https://app.codecov.io/gh/apache/cloudstack/pull/11256/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [uitests](https://app.codecov.io/gh/apache/cloudstack/pull/11256/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `4.00% <ø> (ø)` | |
| [unittests](https://app.codecov.io/gh/apache/cloudstack/pull/11256/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
</details>
[:umbrella: View full report in Codecov by Sentry](https://app.codecov.io/gh/apache/cloudstack/pull/11256?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
:loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
- :package: [JS Bundle Analysis](https://docs.codecov.com/docs/javascript-bundle-analysis): Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Config 'vm.network.nic.max.secondary.ipaddresses' - Update default value (and value if not set) to 10 as per the config description and default value in parseInt of the config [cloudstack]
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #11256:
URL: https://github.com/apache/cloudstack/pull/11256#issuecomment-3113388395
@sureshanaparti a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Config 'vm.network.nic.max.secondary.ipaddresses' - Update default value (and value if not set) to 10 as per the config description and default value in parseInt of the config [cloudstack]
Posted by "DaanHoogland (via GitHub)" <gi...@apache.org>.
DaanHoogland commented on PR #11256:
URL: https://github.com/apache/cloudstack/pull/11256#issuecomment-3108679189
This will need some upgrade testing @sureshanaparti :
- 4.19 -> 4.21
- 4.20.1 -> 4.21
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Config 'vm.network.nic.max.secondary.ipaddresses' - Update default value (and value if not set) to 10 as per the config description and default value in parseInt of the config [cloudstack]
Posted by "sureshanaparti (via GitHub)" <gi...@apache.org>.
sureshanaparti commented on PR #11256:
URL: https://github.com/apache/cloudstack/pull/11256#issuecomment-3101862934
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Config 'vm.network.nic.max.secondary.ipaddresses' - Update default value (and value if not set) to 10 as per the config description and default value in parseInt of the config [cloudstack]
Posted by "sureshanaparti (via GitHub)" <gi...@apache.org>.
sureshanaparti commented on PR #11256:
URL: https://github.com/apache/cloudstack/pull/11256#issuecomment-3106196249
@blueorangutan test
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Config 'vm.network.nic.max.secondary.ipaddresses' - Update default value (and value if not set) to 10 as per the config description and default value in parseInt of the config [cloudstack]
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #11256:
URL: https://github.com/apache/cloudstack/pull/11256#issuecomment-3113758688
Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 14353
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Config 'vm.network.nic.max.secondary.ipaddresses' - Update default value (and value if not set) to 10 as per the config description and default value in parseInt of the config [cloudstack]
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #11256:
URL: https://github.com/apache/cloudstack/pull/11256#issuecomment-3106205871
@sureshanaparti a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Config 'vm.network.nic.max.secondary.ipaddresses' - Update default value (and value if not set) to 10 as per the config description and default value in parseInt of the config [cloudstack]
Posted by "sureshanaparti (via GitHub)" <gi...@apache.org>.
sureshanaparti commented on PR #11256:
URL: https://github.com/apache/cloudstack/pull/11256#issuecomment-3101829852
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Config 'vm.network.nic.max.secondary.ipaddresses' - Update default value (and value if not set) to 10 as per the config description and default value in parseInt of the config [cloudstack]
Posted by "Copilot (via GitHub)" <gi...@apache.org>.
Copilot commented on code in PR #11256:
URL: https://github.com/apache/cloudstack/pull/11256#discussion_r2221860168
##########
server/src/main/java/com/cloud/network/NetworkServiceImpl.java:
##########
@@ -907,7 +907,7 @@ public NicSecondaryIp allocateSecondaryGuestIP(final long nicId, IpAddresses req
throw new InvalidParameterValueException("Invalid network id is given");
}
- int maxAllowedIpsPerNic = NumbersUtil.parseInt(_configDao.getValue(Config.MaxNumberOfSecondaryIPsPerNIC.key()), 10);
+ int maxAllowedIpsPerNic = NumbersUtil.parseInt(_configDao.getValue(Config.MaxNumberOfSecondaryIPsPerNIC.key()), Integer.parseInt(Config.MaxNumberOfSecondaryIPsPerNIC.getDefaultValue()));
Review Comment:
The Integer.parseInt(Config.MaxNumberOfSecondaryIPsPerNIC.getDefaultValue()) call is executed on every method invocation. Consider caching this value or using a static final field since the default value doesn't change at runtime.
```suggestion
int maxAllowedIpsPerNic = MAX_ALLOWED_IPS_PER_NIC;
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Config 'vm.network.nic.max.secondary.ipaddresses' - Update default value (and value if not set) to 10 as per the config description and default value in parseInt of the config [cloudstack]
Posted by "DaanHoogland (via GitHub)" <gi...@apache.org>.
DaanHoogland commented on PR #11256:
URL: https://github.com/apache/cloudstack/pull/11256#issuecomment-3117018974
upgrades tested from 4.19 and 4.20
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Config 'vm.network.nic.max.secondary.ipaddresses' - Update default value (and value if not set) to 10 as per the config description and default value in parseInt of the config [cloudstack]
Posted by "DaanHoogland (via GitHub)" <gi...@apache.org>.
DaanHoogland merged PR #11256:
URL: https://github.com/apache/cloudstack/pull/11256
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Config 'vm.network.nic.max.secondary.ipaddresses' - Update default value (and value if not set) to 10 as per the config description and default value in parseInt of the config [cloudstack]
Posted by "DaanHoogland (via GitHub)" <gi...@apache.org>.
DaanHoogland commented on PR #11256:
URL: https://github.com/apache/cloudstack/pull/11256#issuecomment-3112989460
After a bit of backtalk with @sureshanaparti , we agreed to move this to 4.21 as 4.20.1 -> 4.20.2 -> 4.21 upgrades for this will be tricky and this is only a minor issue.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Config 'vm.network.nic.max.secondary.ipaddresses' - Update default value (and value if not set) to 10 as per the config description and default value in parseInt of the config [cloudstack]
Posted by "sureshanaparti (via GitHub)" <gi...@apache.org>.
sureshanaparti commented on PR #11256:
URL: https://github.com/apache/cloudstack/pull/11256#issuecomment-3113385265
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Config 'vm.network.nic.max.secondary.ipaddresses' - Update default value (and value if not set) to 10 as per the config description and default value in parseInt of the config [cloudstack]
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #11256:
URL: https://github.com/apache/cloudstack/pull/11256#issuecomment-3102231940
Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 14292
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Config 'vm.network.nic.max.secondary.ipaddresses' - Update default value (and value if not set) to 10 as per the config description and default value in parseInt of the config [cloudstack]
Posted by "sureshanaparti (via GitHub)" <gi...@apache.org>.
sureshanaparti closed pull request #11256: Config 'vm.network.nic.max.secondary.ipaddresses' - Update default value (and value if not set) to 10 as per the config description and default value in parseInt of the config
URL: https://github.com/apache/cloudstack/pull/11256
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Config 'vm.network.nic.max.secondary.ipaddresses' - Update default value (and value if not set) to 10 as per the config description and default value in parseInt of the config [cloudstack]
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #11256:
URL: https://github.com/apache/cloudstack/pull/11256#issuecomment-3101864480
@sureshanaparti a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Config 'vm.network.nic.max.secondary.ipaddresses' - Update default value (and value if not set) to 10 as per the config description and default value in parseInt of the config [cloudstack]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #11256:
URL: https://github.com/apache/cloudstack/pull/11256#issuecomment-3113375211
This pull request has merge conflicts. Dear author, please fix the conflicts and sync your branch with the base branch.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Config 'vm.network.nic.max.secondary.ipaddresses' - Update default value (and value if not set) to 10 as per the config description and default value in parseInt of the config [cloudstack]
Posted by "sureshanaparti (via GitHub)" <gi...@apache.org>.
sureshanaparti commented on PR #11256:
URL: https://github.com/apache/cloudstack/pull/11256#issuecomment-3113376301
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Config 'vm.network.nic.max.secondary.ipaddresses' - Update default value (and value if not set) to 10 as per the config description and default value in parseInt of the config [cloudstack]
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #11256:
URL: https://github.com/apache/cloudstack/pull/11256#issuecomment-3111244783
<b>[SF] Trillian test result (tid-13850)</b>
Environment: kvm-ol8 (x2), Advanced Networking with Mgmt server ol8
Total time taken: 55399 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr11256-t13850-kvm-ol8.zip
Smoke tests completed. 141 look OK, 0 have errors, 0 did not run
Only failed and skipped tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org