You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2021/03/05 03:30:18 UTC

[GitHub] [spark] eddyxu commented on pull request #31735: [WIP][SPARK-34600][Pyspark][SQL] Return User-defined types from Pandas UDF

eddyxu commented on pull request #31735:
URL: https://github.com/apache/spark/pull/31735#issuecomment-791125244


   Thanks for the reviews, @HyukjinKwon.  
   
   * For a regular Python UDF, not the arrow-based pandas UDF,  this code path is not used.  The UDT to StructType conversion only happens in `ArrowStreamPandasUDFSerializer`. 
   * For a pandas UDF with regular spark types,  this is guarded by a ["has_udt" flag]( https://github.com/apache/spark/pull/31735/files#diff-f488fb6f95fc62225d12b7895ca4a17081a7de2f6c4dc77272c7bd6694649706R180) . This flag is initialized once during `ArrowStreamPandasUDFSerializer` [creation](https://github.com/apache/spark/pull/31735/files#diff-f488fb6f95fc62225d12b7895ca4a17081a7de2f6c4dc77272c7bd6694649706R120).
   
   Performance wise , i will do some benchmarks and look into a way to erase UDT without much type dispatching. 
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org