You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@iotdb.apache.org by GitBox <gi...@apache.org> on 2020/08/31 12:23:36 UTC

[GitHub] [incubator-iotdb] jixuan1989 commented on pull request #1661: - Made it possible to load the config from the classpath

jixuan1989 commented on pull request #1661:
URL: https://github.com/apache/incubator-iotdb/pull/1661#issuecomment-683745877


   > But while working on this ... I did notice the tests sometimes created directories and resources outside the "target" directory. This is considered not good practice as a failing test will prevent a cleanup ... in my case I couldn't do a new build till I found them all as otherwise the RAT test would have failed the build.
   
   Agree with you. I will do the refactor in the following days.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org