You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@systemds.apache.org by "cs-ally (via GitHub)" <gi...@apache.org> on 2024/08/01 14:30:52 UTC

Re: [PR] Optimization of I/O path of python interface [systemds]

cs-ally commented on code in PR #2032:
URL: https://github.com/apache/systemds/pull/2032#discussion_r1700306926


##########
src/main/java/org/apache/sysds/runtime/util/Py4jConverterUtils.java:
##########
@@ -114,6 +120,82 @@ public static MatrixBlock convertPy4JArrayToMB(byte[] data, int rlen, int clen,
 		return mb;
 	}
 
+	public static Array<?> convert(byte[] data, int numElements, Types.ValueType valueType) {

Review Comment:
   I wasn’t able to find existing tests for the Py4jConverterUtils class. Could you please advise where I should add new tests?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@systemds.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org