[GitHub] [incubator-pekko-persistence-r2dbc] mdedetrich commented on a diff in pull request #8: Update package and conf to pekko

["mdedetrich (via GitHub)" <gi...@apache.org>]

mdedetrich commented on code in PR #8:
URL: https://github.com/apache/incubator-pekko-persistence-r2dbc/pull/8#discussion_r1158930062


##########
core/src/main/scala/org/apache/pekko/persistence/r2dbc/state/javadsl/R2dbcDurableStateStore.scala:
##########
@@ -44,6 +45,9 @@ class R2dbcDurableStateStore[A](scalaStore: ScalaR2dbcDurableStateStore[A])(impl
   override def deleteObject(persistenceId: String): CompletionStage[Done] =
     scalaStore.deleteObject(persistenceId).toJava
 
+  override def deleteObject(persistenceId: String, revision: Long): CompletionStage[Done] =

Review Comment:
   I had to add this implementation because the originally this project used an older version of akka-projection which didn't have this method in their interface.
   
   On the other hand the the latest akka BSL version of akka-persistence (and hence pekko-persistence) has this method which has to be implemented.
   
   I copied the implementation from `pekko-persistence-jdbc` which seems to ignore the `revision` parameter https://github.com/apache/incubator-pekko-persistence-jdbc/blob/db5733e60fffb99d3d822d3d60199ec2f0890278/core/src/main/scala/org/apache/pekko/persistence/jdbc/state/scaladsl/JdbcDurableStateStore.scala#L117-L118



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org