You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by "MaksimAniskov (via GitHub)" <gi...@apache.org> on 2025/10/23 14:27:29 UTC
[PR] [FLINK-38552] [Helm] Fix FlinkStateSnapshot when operator's namespace not in watchNamespaces [flink-kubernetes-operator]
MaksimAniskov opened a new pull request, #1038:
URL: https://github.com/apache/flink-kubernetes-operator/pull/1038
This change fixes support for _FlinkStateSnapshot_ CRDs getting disabled if the operator deployed using [the Helm chart](https://github.com/apache/flink-kubernetes-operator/tree/main/helm/flink-kubernetes-operator) and the operator's namespace not listed in [_watchNamespaces_ value](https://github.com/apache/flink-kubernetes-operator/blob/release-1.13/helm/flink-kubernetes-operator/values.yaml#L23).
The operator's [isCrdInstalled](https://github.com/apache/flink-kubernetes-operator/blob/release-1.13/flink-kubernetes-operator/src/main/java/org/apache/flink/kubernetes/operator/utils/KubernetesClientUtils.java#L73) check requires _list_ permission for _flinkstatesnaphots_ verb in the operator's namespace.
When the namespace listed in _watchNamespaces_, lines 24-32 of _helm/flink-kubernetes-operator/templates/rbac/role.yaml_ create the Kubernetes role with necessary permission as defined in helm/flink-kubernetes-operator/templates/rbac/_helpers.tpl
When the operator's namespace isn't in _watchNamespaces_, another part of the template defines the role. This part should also define the permission.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [FLINK-38552] [Helm] Fix FlinkStateSnapshot when operator's namespace not in watchNamespaces [flink-kubernetes-operator]
Posted by "gyfora (via GitHub)" <gi...@apache.org>.
gyfora merged PR #1038:
URL: https://github.com/apache/flink-kubernetes-operator/pull/1038
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [FLINK-38552] [Helm] Fix FlinkStateSnapshot when operator's namespace not in watchNamespaces [flink-kubernetes-operator]
Posted by "MaksimAniskov (via GitHub)" <gi...@apache.org>.
MaksimAniskov commented on PR #1038:
URL: https://github.com/apache/flink-kubernetes-operator/pull/1038#issuecomment-3442296886
@mateczagany I saw that _isCrdInstalled_ is scheduled for deleting. If the check gets deleted, that will solve the issue.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [FLINK-38552] [Helm] Fix FlinkStateSnapshot when operator's namespace not in watchNamespaces [flink-kubernetes-operator]
Posted by "mateczagany (via GitHub)" <gi...@apache.org>.
mateczagany commented on PR #1038:
URL: https://github.com/apache/flink-kubernetes-operator/pull/1038#issuecomment-3441957918
Thank you for this fix, @MaksimAniskov
This check was added when introducing FlinkStateSnapshot in release 1.10 to make sure that we don't break existing deployments where the CRD is not yet installed by creating a controller. I think it should be safe to remove this check altogether in the next release of 1.14, so the Helm chart change might not even be needed. WDYT?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org