You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@pegasus.apache.org by "empiredan (via GitHub)" <gi...@apache.org> on 2025/07/17 08:52:02 UTC
[PR] feat: support client RPC connection pool to each server address [incubator-pegasus]
empiredan opened a new pull request, #2272:
URL: https://github.com/apache/incubator-pegasus/pull/2272
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org
For additional commands, e-mail: dev-help@pegasus.apache.org
Re: [PR] perf(network): support client RPC connection pool to each server address [incubator-pegasus]
Posted by "acelyc111 (via GitHub)" <gi...@apache.org>.
acelyc111 commented on PR #2272:
URL: https://github.com/apache/incubator-pegasus/pull/2272#issuecomment-3172402568
Could you please describe the changes and design simply?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org
For additional commands, e-mail: dev-help@pegasus.apache.org
Re: [PR] perf(network): support client RPC connection pool to each server address [incubator-pegasus]
Posted by "empiredan (via GitHub)" <gi...@apache.org>.
empiredan commented on code in PR #2272:
URL: https://github.com/apache/incubator-pegasus/pull/2272#discussion_r2297289137
##########
src/rpc/asio_net_provider.cpp:
##########
@@ -122,17 +123,17 @@ asio_network_provider::~asio_network_provider()
error_code asio_network_provider::start(rpc_channel channel, int port, bool client_only)
{
- if (_acceptor != nullptr)
+ if (_acceptor != nullptr) {
return ERR_SERVICE_ALREADY_RUNNING;
+ }
- for (int i = 0; i < FLAGS_io_service_worker_count; i++) {
+ for (auto i = _workers.size(); _workers.size() < FLAGS_io_service_worker_count; ++i) {
Review Comment:
OK. Done.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org
For additional commands, e-mail: dev-help@pegasus.apache.org
Re: [PR] perf(network): support client RPC connection pool to each server address [incubator-pegasus]
Posted by "empiredan (via GitHub)" <gi...@apache.org>.
empiredan merged PR #2272:
URL: https://github.com/apache/incubator-pegasus/pull/2272
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org
For additional commands, e-mail: dev-help@pegasus.apache.org
Re: [PR] perf(network): support client RPC connection pool to each server address [incubator-pegasus]
Posted by "acelyc111 (via GitHub)" <gi...@apache.org>.
acelyc111 commented on code in PR #2272:
URL: https://github.com/apache/incubator-pegasus/pull/2272#discussion_r2265130392
##########
src/rpc/asio_net_provider.cpp:
##########
@@ -122,17 +123,17 @@ asio_network_provider::~asio_network_provider()
error_code asio_network_provider::start(rpc_channel channel, int port, bool client_only)
{
- if (_acceptor != nullptr)
+ if (_acceptor != nullptr) {
return ERR_SERVICE_ALREADY_RUNNING;
+ }
- for (int i = 0; i < FLAGS_io_service_worker_count; i++) {
+ for (auto i = _workers.size(); _workers.size() < FLAGS_io_service_worker_count; ++i) {
Review Comment:
Why changes to start from _workers.size()? Please add some comments.
##########
src/rpc/asio_net_provider.cpp:
##########
@@ -462,14 +469,14 @@ error_code asio_udp_provider::start(rpc_channel channel, int port, bool client_o
_hp = ::dsn::host_port::from_address(_address);
LOG_WARNING_IF(!_hp, "'{}' can not be reverse resolved", _address);
- for (int i = 0; i < FLAGS_io_service_worker_count; i++) {
+ for (auto i = _workers.size(); _workers.size() < FLAGS_io_service_worker_count; ++i) {
Review Comment:
Ditto
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org
For additional commands, e-mail: dev-help@pegasus.apache.org
Re: [PR] perf(network): support client RPC connection pool to each server address [incubator-pegasus]
Posted by "empiredan (via GitHub)" <gi...@apache.org>.
empiredan commented on PR #2272:
URL: https://github.com/apache/incubator-pegasus/pull/2272#issuecomment-3173870546
> Could you please describe the changes and design simply?
@acelyc111 Sorry for the missing information about this PR, which now have been added to the description.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org
For additional commands, e-mail: dev-help@pegasus.apache.org